From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCFB7CAC5AA for ; Tue, 17 Sep 2024 22:15:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A60F10E02A; Tue, 17 Sep 2024 22:15:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="KK6XeQUh"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id B22DF10E02A; Tue, 17 Sep 2024 22:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726611309; x=1758147309; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=P5WFfwZzkAYklouxdgtYq3K+vJjCTJn2RRne7SyovsA=; b=KK6XeQUhfzHgIMlwoqjQ+wqU7y+xNUiKsZR5306a1E9Encp6rvBxelfv 4hz7LD8xKHXEm9snVyXHjSoVQYvHU1RlwzBdpGJznVpImG984NwpwXip7 wJIYxu7X4jsXLOCwMgQoxzUvMYZDxMtoeQu8PUtHTr7TanBTyCVmxkcMM ChnLqtItLLDTGqpYrYxJgTXCqpnICE8ydZ5YjsbJfkkuJLBg9dhkqiFqV Uz0HweBVioddL0KRBkI1Y3Qirxn87cRnAQzILPQjNDrax+KY8L5UtpDG0 t3hc7MSpMiqjgkrfukWup/kEBjNtP1Dbj7R8CRnGyFSaEYXhc/dvyTps6 A==; X-CSE-ConnectionGUID: 8ytlWTEsTIyDStDosPxbQA== X-CSE-MsgGUID: HWxe7+gcQcyp5/8XsN629w== X-IronPort-AV: E=McAfee;i="6700,10204,11198"; a="25657336" X-IronPort-AV: E=Sophos;i="6.10,235,1719903600"; d="scan'208";a="25657336" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2024 15:15:09 -0700 X-CSE-ConnectionGUID: 8sNniQVsRYKobJmeaI8deQ== X-CSE-MsgGUID: eML0wqRWRsmXVmgwpsnIHA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,235,1719903600"; d="scan'208";a="69433331" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmviesa008.fm.intel.com with SMTP; 17 Sep 2024 15:15:05 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Sep 2024 01:15:05 +0300 Date: Wed, 18 Sep 2024 01:15:05 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maarten Lankhorst Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/xe: Fix DSB buffer coherency Message-ID: References: <20240913114754.7956-1-maarten.lankhorst@linux.intel.com> <20240913114754.7956-2-maarten.lankhorst@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240913114754.7956-2-maarten.lankhorst@linux.intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, Sep 13, 2024 at 01:47:53PM +0200, Maarten Lankhorst wrote: > Add the scanout flag to force WC caching, and add the memory barrier > where needed. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/xe/display/xe_dsb_buffer.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c > index f99d901a3214f..f7949bf5426af 100644 > --- a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c > +++ b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c > @@ -48,11 +48,12 @@ bool intel_dsb_buffer_create(struct intel_crtc *crtc, struct intel_dsb_buffer *d > if (!vma) > return false; > > + /* Set scanout flag for WC mapping */ > obj = xe_bo_create_pin_map(xe, xe_device_get_root_tile(xe), > NULL, PAGE_ALIGN(size), > ttm_bo_type_kernel, > XE_BO_FLAG_VRAM_IF_DGFX(xe_device_get_root_tile(xe)) | > - XE_BO_FLAG_GGTT); > + XE_BO_FLAG_SCANOUT | XE_BO_FLAG_GGTT); > if (IS_ERR(obj)) { > kfree(vma); > return false; > @@ -73,5 +74,5 @@ void intel_dsb_buffer_cleanup(struct intel_dsb_buffer *dsb_buf) > > void intel_dsb_buffer_flush_map(struct intel_dsb_buffer *dsb_buf) > { > - /* TODO: add xe specific flush_map() for dsb buffer object. */ > + xe_device_wmb(dsb_buf->vma->bo->tile->xe); With some kind of comment added that this may be needed on !x86 architectures to flush the WC buffer: Reviewed-by: Ville Syrjälä > } > -- > 2.45.2 -- Ville Syrjälä Intel