From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F37CF34CF for ; Thu, 3 Oct 2024 22:49:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E28A10E0B0; Thu, 3 Oct 2024 22:49:03 +0000 (UTC) X-Greylist: delayed 963 seconds by postgrey-1.36 at gabe; Thu, 03 Oct 2024 22:49:01 UTC Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD41710E0B0 for ; Thu, 3 Oct 2024 22:49:01 +0000 (UTC) Received: from localhost (88-113-25-87.elisa-laajakaista.fi [88.113.25.87]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 6ccef329-81d7-11ef-995b-005056bd6ce9; Fri, 04 Oct 2024 01:32:55 +0300 (EEST) From: Andy Shevchenko Date: Fri, 4 Oct 2024 01:32:50 +0300 To: Daniel Gomez Cc: Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Greg Kroah-Hartman , Jiri Slaby , Nick Desaulniers , Bill Wendling , Justin Stitt , Simona Vetter , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, speakup@linux-speakup.org, selinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-serial@vger.kernel.org, llvm@lists.linux.dev, Finn Behrens , "Daniel Gomez (Samsung)" , gost.dev@samsung.com Subject: Re: [PATCH v2 2/8] file2alias: fix uuid_t definitions for macos Message-ID: References: <20240906-macos-build-support-v2-0-06beff418848@samsung.com> <20240906-macos-build-support-v2-2-06beff418848@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240906-macos-build-support-v2-2-06beff418848@samsung.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Fri, Sep 06, 2024 at 01:01:29PM +0200, Daniel Gomez kirjoitti: > The uuid_t struct defined in sys/types.h on macOS hosts conflicts with > the one defined in file2alias, resulting in the typedef redefinition > error below. To resolve this conflict, define the _UUID_T and > __GETHOSTUUID_ in file2alias HOSTCFLAGS. > > Error: > HOSTCC scripts/mod/file2alias.o scripts/mod/file2alias.c:45:3: > error: typedef redefinition with different types ('struct uuid_t' vs > '__darwin_uuid_t' (aka 'unsigned char[16]')) 45 | } uuid_t; | > ^ > /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ > sys/_types/_uuid_t.h:31:25: note: previous definition is here 31 | > typedef __darwin_uuid_t uuid_t; | ^ > scripts/mod/file2alias.c:1354:7: error: member reference base > type 'typeof (((struct tee_client_device_id *)0)->uuid)' (aka > 'unsigned char[16]') is not a structure or union 1354 | > uuid->b[0], uuid->b[1], uuid->b[2], uuid->b[3], uuid->b[4], | > ~~~~^ ~ > /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ > secure/_stdio.h:47:56: note: expanded from macro 'sprintf' 47 | > __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__) > | ^~~~~~~~~~~ > scripts/mod/file2alias.c:1354:19: error: member reference base > type 'typeof (((struct tee_client_device_id *)0)->uuid)' (aka > 'unsigned char[16]') is not a structure or union 1354 | > uuid->b[0], uuid->b[1], uuid->b[2], uuid->b[3], uuid->b[4], | > ~~~~^ ~ > /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ > secure/_stdio.h:47:56: note: expanded from macro 'sprintf' 47 | > __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__) > | ^~~~~~~~~~~ Please, shrink this to the valuable ~3-5 lines. No need to repeat the same for each case! -- With Best Regards, Andy Shevchenko