Re: [CI 00/12] Debug g2h timeout issue

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Sep 23, 2024 at 12:45:18PM -0700, John Harrison wrote:
> On 9/20/2024 07:48, Jani Nikula wrote:
> > On Fri, 20 Sep 2024, Badal Nilawar <badal.nilawar@intel.com> wrote:
> > > Do not review
> > Explanation would go here.
> > 
> > [CI] Usually means everything's reviewed, and this is just a resend for
> > CI. And there's no need to resend multiple times for that. Patchwork has
> > a "test again" button.
> > 
> > Finally, the patches are missing your Signed-off-by.
> > 
> > BR,
> > Jani.
> I think the intention here is to just get extra CI runs with more debug
> output to debug a failure that is only happening inside CI and cannot be
> reproduced locally. Although it is generally simpler/clearer to just squash
> the patches down into a single "Add extra debug for CI failures" patch
> rather than re-submitting an entire series.
> 
> Of course, the ideal would be to actually get all this extremely useful
> stuff merged and then it wouldn't need to be reposted over and over to get
> more CI results with it enabled.

yeap, the lack of try-bot in xe side. But yes, next time please squash them all...

> 
> John.
> 
> 
> > 
> > > John Harrison (10):
> > >    drm/xe/guc: Remove spurious line feed in debug print
> > >    drm/xe/devcoredump: Use drm_puts and already cached local variables
> > >    drm/xe/devcoredump: Improve section headings and add tile info
> > >    drm/xe/devcoredump: Add ASCII85 dump helper function
> > >    drm/xe/guc: Copy GuC log prior to dumping
> > >    drm/xe/guc: Use a two stage dump for GuC logs and add more info
> > >    drm/xe/guc: Dead CT helper
> > >    drm/xe/guc: Dump entire CTB on errors
> > >    drm/xe/guc: Add GuC log to devcoredump captures
> > >    drm/xe/guc: Add a helper function for dumping GuC log to dmesg
> > > 
> > > Michal Wajdeczko (1):
> > >    drm/print: Introduce drm_line_printer
> > > 
> > > bnilawar (1):
> > >    [For CI] Debug prints/logs to debug G2H timeout issue
> > > 
> > >   drivers/gpu/drm/drm_print.c                   |  14 +
> > >   .../drm/xe/abi/guc_communication_ctb_abi.h    |   1 +
> > >   drivers/gpu/drm/xe/regs/xe_guc_regs.h         |   1 +
> > >   drivers/gpu/drm/xe/xe_devcoredump.c           | 144 +++++-
> > >   drivers/gpu/drm/xe/xe_devcoredump.h           |   6 +
> > >   drivers/gpu/drm/xe/xe_devcoredump_types.h     |  13 +-
> > >   drivers/gpu/drm/xe/xe_device.c                |   1 +
> > >   drivers/gpu/drm/xe/xe_guc.c                   |   6 +-
> > >   drivers/gpu/drm/xe/xe_guc_ct.c                | 416 ++++++++++++++----
> > >   drivers/gpu/drm/xe/xe_guc_ct.h                |  10 +-
> > >   drivers/gpu/drm/xe/xe_guc_ct_types.h          |  29 +-
> > >   drivers/gpu/drm/xe/xe_guc_log.c               | 208 ++++++++-
> > >   drivers/gpu/drm/xe/xe_guc_log.h               |   5 +
> > >   drivers/gpu/drm/xe/xe_guc_log_types.h         |  27 ++
> > >   drivers/gpu/drm/xe/xe_guc_submit.c            |   2 +-
> > >   drivers/gpu/drm/xe/xe_hw_engine.c             |   1 -
> > >   include/drm/drm_print.h                       |  64 +++
> > >   17 files changed, 804 insertions(+), 144 deletions(-)
>