Re: [PATCH v2 2/2] drm/xe/ufence: Warn if mmget_not_zero() fails

[Francois Dugast <francois.dugast@intel.com>]

On Fri, Oct 18, 2024 at 03:41:16PM +0200, Nirmoy Das wrote:
> Hi Francois,
> 
> On 10/16/2024 10:23 AM, Nirmoy Das wrote:
> > This shouldn't happen but seen this while debugging ufence timeout
> > issue time to time so log it to isolate this particular case.
> >
> > v2: s/XE_WARN_ON/drm_dbg(Maarten)
> >
> > Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
> > Cc: Francois Dugast <francois.dugast@intel.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Reviewed-by: Francois Dugast <francois.dugast@intel.com> #v1
> 
> 
> is your r-b valid for v2 as well ?

Yes it is.

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> 
> 
> Regards,
> 
> Nirmoy
> 
> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_sync.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
> > index 2e72c06fd40d..a90480c6aecf 100644
> > --- a/drivers/gpu/drm/xe/xe_sync.c
> > +++ b/drivers/gpu/drm/xe/xe_sync.c
> > @@ -83,6 +83,8 @@ static void user_fence_worker(struct work_struct *w)
> >  			XE_WARN_ON("Copy to user failed");
> >  		kthread_unuse_mm(ufence->mm);
> >  		mmput(ufence->mm);
> > +	} else {
> > +		drm_dbg(&ufence->xe->drm, "mmget_not_zero() failed, ufence wasn't signaled\n");
> >  	}
> >  
> >  	wake_up_all(&ufence->xe->ufence_wq);