From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>
Subject: Re: [PATCH v2 2/3] drm/intel/pciids: rename i915_pciids.h to just pciids.h
Date: Tue, 22 Oct 2024 17:03:55 +0200 [thread overview]
Message-ID: <Zxe-29RohklKnA8E@ashyti-mobl2.lan> (raw)
In-Reply-To: <835143845faa5310e4bb58405a8a0848392bbf06.1729590029.git.jani.nikula@intel.com>
Hi Jani,
...
> Could be intel_pciids.h too, but it's already in include/drm/intel
If we met in the coffee corner and you asked me, I would have
said that intel_pciids.h would be better, but I won't complain if
you keep it as it is.
> subdirectory.
...
> -#ifndef _I915_PCIIDS_H
> -#define _I915_PCIIDS_H
> +#ifndef __PCIIDS_H__
> +#define __PCIIDS_H__
>
> #ifdef __KERNEL__
> #define INTEL_VGA_DEVICE(_id, _info) { \
> @@ -822,4 +822,4 @@
> MACRO__(0xB0A1, ## __VA_ARGS__), \
> MACRO__(0xB0A2, ## __VA_ARGS__)
>
> -#endif /* _I915_PCIIDS_H */
> +#endif /* __PCIIDS_H__ */
Should this be __INTEL_PCIIDS_H__ anyway?
Andi
next prev parent reply other threads:[~2024-10-22 15:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 9:41 [PATCH v2 0/3] drm/i915 & drm/xe: shared PCI ID macros Jani Nikula
2024-10-22 9:41 ` [PATCH v2 1/3] drm/i915/pciids: add PVC " Jani Nikula
2024-10-22 9:41 ` [PATCH v2 2/3] drm/intel/pciids: rename i915_pciids.h to just pciids.h Jani Nikula
2024-10-22 15:03 ` Andi Shyti [this message]
2024-10-29 8:50 ` Jani Nikula
2024-10-22 9:41 ` [PATCH v2 3/3] drm/xe: switch to common PCI ID macros Jani Nikula
2024-10-22 9:47 ` ✓ CI.Patch_applied: success for drm/i915 & drm/xe: shared PCI ID macros (rev2) Patchwork
2024-10-22 9:48 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-22 9:49 ` ✓ CI.KUnit: success " Patchwork
2024-10-22 10:00 ` ✓ CI.Build: " Patchwork
2024-10-22 10:03 ` ✓ CI.Hooks: " Patchwork
2024-10-22 10:04 ` ✗ CI.checksparse: warning " Patchwork
2024-10-22 10:26 ` ✓ CI.BAT: success " Patchwork
2024-10-22 12:52 ` ✗ CI.FULL: failure " Patchwork
2024-10-22 15:04 ` [PATCH v2 0/3] drm/i915 & drm/xe: shared PCI ID macros Andi Shyti
2024-10-29 8:51 ` Jani Nikula
2024-10-29 13:32 ` Rodrigo Vivi
2024-10-29 14:35 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxe-29RohklKnA8E@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox