Re: [PATCH] drm/xe/oa: Fix "Missing outer runtime PM protection" warning

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Nov 08, 2024 at 07:20:03PM -0800, Ashutosh Dixit wrote:
> Fix the following drm_WARN:
> 
> [953.586396] xe 0000:00:02.0: [drm] Missing outer runtime PM protection
> ...
> <4> [953.587090]  ? xe_pm_runtime_get_noresume+0x8d/0xa0 [xe]
> <4> [953.587208]  guc_exec_queue_add_msg+0x28/0x130 [xe]
> <4> [953.587319]  guc_exec_queue_fini+0x3a/0x40 [xe]
> <4> [953.587425]  xe_exec_queue_destroy+0xb3/0xf0 [xe]
> <4> [953.587515]  xe_oa_release+0x9c/0xc0 [xe]
> 
> Suggested-by: John Harrison <john.c.harrison@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Fixes: e936f885f1e9 ("drm/xe/oa/uapi: Expose OA stream fd")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_oa.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 53d2946ea3052..b0928daf2f308 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -1615,9 +1615,11 @@ static int xe_oa_release(struct inode *inode, struct file *file)
>  	struct xe_oa_stream *stream = file->private_data;
>  	struct xe_gt *gt = stream->gt;
>  
> +	xe_pm_runtime_get(gt_to_xe(gt));
>  	mutex_lock(&gt->oa.gt_lock);
>  	xe_oa_destroy_locked(stream);
>  	mutex_unlock(&gt->oa.gt_lock);
> +	xe_pm_runtime_put(gt_to_xe(gt));
>  
>  	/* Release the reference the OA stream kept on the driver */
>  	drm_dev_put(&gt_to_xe(gt)->drm);
> -- 
> 2.41.0
>