From: Matthew Brost <matthew.brost@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
<intel-xe@lists.freedesktop.org>,
<umesh.nerlige.ramappa@intel.com>, <riana.tauro@intel.com>
Subject: Re: [PATCH 1/3] drm/xe: Add XE_BO_FLAG_PINNED_WONTNEED
Date: Wed, 30 Oct 2024 22:10:33 -0700 [thread overview]
Message-ID: <ZyMRSQZi15zckEbG@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <7dcm67332fipskakin6uhqd3yjt6eykpnlz34c322omhdatk5n@2cflr6hqujod>
On Wed, Oct 30, 2024 at 11:23:40PM -0500, Lucas De Marchi wrote:
> On Tue, Oct 29, 2024 at 02:55:11PM +0000, Matthew Brost wrote:
> > On Tue, Oct 29, 2024 at 09:30:50AM -0400, Rodrigo Vivi wrote:
> > > On Mon, Oct 28, 2024 at 05:32:22PM -0700, Matthew Brost wrote:
> > > > Not all BOs need to restored on resume / d3cold exit, add
> > > > XE_BO_FLAG_PINNED_WONTNEED which skips restoring of BOs rather just
> > > > allocates VRAM for the BO. This should slighly speedup resume / d3cold
> > > > exit flows.
> > > >
> > > > Marking GuC ADS, GuC CT, GuC log, GuC PC, and SA as WONTNEED.
> > >
> > > What about s/WONTNEED/NORESTORE ?
>
> since you are renaming, can you quantify "This should slighly speedup
> resume"?
>
> I think you can just trace xe_bo_evict_pinned and xe_bo_restore_pinned
> and see how much it improves...
>
Sure. Probably will drop patch 1, 3 for now though as 2 fixes an issue
in our downstream driver. I've distracted myself with other work but
when I revive 1, 3 agree it would be to quantify the actual improvement
here.
Matt
> Lucas De Marchi
next prev parent reply other threads:[~2024-10-31 5:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 0:32 [PATCH 0/3] Suspend, resume, and d3cold tweaks Matthew Brost
2024-10-29 0:32 ` [PATCH 1/3] drm/xe: Add XE_BO_FLAG_PINNED_WONTNEED Matthew Brost
2024-10-29 13:30 ` Rodrigo Vivi
2024-10-29 14:55 ` Matthew Brost
2024-10-31 4:23 ` Lucas De Marchi
2024-10-31 5:10 ` Matthew Brost [this message]
2024-10-29 0:32 ` [PATCH 2/3] drm/xe: Restore system memory GGTT mappings Matthew Brost
2024-10-29 9:44 ` Matthew Auld
2024-10-29 14:57 ` Matthew Brost
2024-10-30 11:53 ` Matthew Auld
2024-10-31 0:49 ` Matthew Brost
2024-10-31 8:44 ` Matthew Auld
2024-10-29 0:32 ` [PATCH 3/3] drm/xe: Add XE_BO_FLAG_PINNED_NEED_LOAD Matthew Brost
2024-10-29 1:07 ` Matthew Brost
2024-10-29 0:44 ` ✓ CI.Patch_applied: success for Suspend, resume, and d3cold tweaks Patchwork
2024-10-29 0:45 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-29 0:46 ` ✓ CI.KUnit: success " Patchwork
2024-10-29 0:58 ` ✓ CI.Build: " Patchwork
2024-10-29 1:00 ` ✓ CI.Hooks: " Patchwork
2024-10-29 1:01 ` ✓ CI.checksparse: " Patchwork
2024-10-29 1:29 ` ✗ CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyMRSQZi15zckEbG@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox