Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
	"thierrycantindemers@gmail.com" <thierrycantindemers@gmail.com>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Kahola,  Mika" <mika.kahola@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/psr: Disable eDP Panel Replay on XPS 16 DA16260 (LG 0x07C5)
Date: Mon, 20 Jul 2026 10:31:46 +0000	[thread overview]
Message-ID: <a036e63561333e3f36896ac0919feab509553bdc.camel@intel.com> (raw)
In-Reply-To: <20260708134252.11854-1-thierrycantindemers@gmail.com>

On Wed, 2026-07-08 at 09:42 -0400, Thierry Cantin-Demers wrote:
> The Dell XPS 16 DA16260 ships in more than one panel variant. The
> existing
> quirk entry only matches the LG Display panel with DPCD sink OUI
> 00:22:b9.
> Another variant of the same laptop (subsystem 1028:0dba) uses an LG
> Display
> 0x07C5 panel with sink OUI 00:aa:01, which is not matched, so eDP
> Panel
> Replay stays enabled and the panel hits a persistent PANEL-REPLAY
> Link CRC
> error, dropping the internal display to ~5 fps.

Thank you for pointing this out.

These symptoms look different compared to what we saw originally.
Please file gitlab ticket:

https://drm.pages.freedesktop.org/intel-docs/how-to-file-i915-bugs.html

BR,
Jouni Högander


> 
> Add a quirk entry for OUI 00:aa:01 so this variant also gets eDP
> Panel
> Replay disabled. Confirmed xe.enable_panel_replay=0 resolves the
> issue.
> 
> Fixes: cb8d155b0806 ("drm/i915/psr: Disable Panel Replay on Dell XPS
> 16 DA16260 as a quirk")
> Signed-off-by: Thierry Cantin-Demers <thierrycantindemers@gmail.com>
> Tested-by: Thierry Cantin-Demers <thierrycantindemers@gmail.com>
> ---
>  drivers/gpu/drm/i915/display/intel_quirks.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c
> b/drivers/gpu/drm/i915/display/intel_quirks.c
> index 33245f44c0d5..e452235832fe 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> @@ -286,6 +286,14 @@ static const struct intel_dpcd_quirk
> intel_dpcd_quirks[] = {
>  		.sink_oui = SINK_OUI(0x00, 0x22, 0xb9),
>  		.hook = quirk_disable_edp_panel_replay,
>  	},
> +	/* Dell XPS 16 DA16260 (LG Display 0x07C5, OUI 00:aa:01) */
> +	{
> +		.device = DEVICE_ID_ANY,
> +		.subsystem_vendor = 0x1028,
> +		.subsystem_device = 0x0dba,
> +		.sink_oui = SINK_OUI(0x00, 0xaa, 0x01),
> +		.hook = quirk_disable_edp_panel_replay,
> +	},
>  };
>  
>  void intel_init_quirks(struct intel_display *display)


      parent reply	other threads:[~2026-07-20 10:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 13:42 [PATCH] drm/i915/psr: Disable eDP Panel Replay on XPS 16 DA16260 (LG 0x07C5) Thierry Cantin-Demers
2026-07-08 13:52 ` ✗ LGCI.VerificationFailed: failure for " Patchwork
2026-07-20 10:31 ` Hogander, Jouni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a036e63561333e3f36896ac0919feab509553bdc.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.kahola@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thierrycantindemers@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox