Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Chauhan, Shekhar" <shekhar.chauhan@intel.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	<lucas.demarchi@intel.com>
Cc: <ogabbay@kernel.org>, <thomas.hellstrom@linux.intel.com>,
	<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
	<tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>,
	<intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] drm/xe/irq: remove unneeded semicolon
Date: Mon, 15 Apr 2024 09:46:13 +0530	[thread overview]
Message-ID: <a10be737-2f2f-4132-9793-3a6a6adf90ea@intel.com> (raw)
In-Reply-To: <20240415032733.39584-1-jiapeng.chong@linux.alibaba.com>


On 4/15/2024 08:57, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon.

Specifying a specific line number in a commit message might not be the 
most resilient approach as it could become outdated.

Maybe rewrite it as:
"Remove unnecessary semicolon in pick_engine_gt()"

With that,
Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/gpu/drm/xe/xe_irq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 996806353171..5b1a2f46a1b2 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
>   			return tile->media_gt;
>   		default:
>   			break;
> -		};
> +		}
>   		fallthrough;
>   	default:
>   		return tile->primary_gt;

-- 
-shekhar


  reply	other threads:[~2024-04-15  4:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15  3:27 [PATCH] drm/xe/irq: remove unneeded semicolon Jiapeng Chong
2024-04-15  4:16 ` Chauhan, Shekhar [this message]
2024-04-15 18:04 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-15 18:04 ` ✓ CI.checkpatch: " Patchwork
2024-04-15 18:05 ` ✓ CI.KUnit: " Patchwork
2024-04-15 18:17 ` ✓ CI.Build: " Patchwork
2024-04-15 18:19 ` ✓ CI.Hooks: " Patchwork
2024-04-15 18:21 ` ✓ CI.checksparse: " Patchwork
2024-04-16  5:53 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a10be737-2f2f-4132-9793-3a6a6adf90ea@intel.com \
    --to=shekhar.chauhan@intel.com \
    --cc=abaci@linux.alibaba.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ogabbay@kernel.org \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox