Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Summers, Stuart" <stuart.summers@intel.com>
To: "Brost, Matthew" <matthew.brost@intel.com>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Summers, Stuart" <stuart.summers@intel.com>
Subject: Re: [PATCH 6/7] drm/xe: Kick start GPU scheduler on teardown
Date: Mon, 13 Oct 2025 22:32:57 +0000	[thread overview]
Message-ID: <a20a8b50c04ee8fd531dfe1a416a34785321618c.camel@intel.com> (raw)
In-Reply-To: <20251013223135.189357-7-stuart.summers@intel.com>

On Mon, 2025-10-13 at 22:31 +0000, Stuart Summers wrote:
> Ensure all remaining GPU scheduler messages are processed
> on teardown. We already have a wait here, but if the
> scheduler was stopped while we have outstanding transactions,
> those queues will never be fully drained.
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 5ec1e4a83d68..c923f13a13ef 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -276,6 +276,12 @@ static void guc_submit_fini(struct drm_device
> *drm, void *arg)
>         struct xe_gt *gt = guc_to_gt(guc);
>         int ret;
>  
> +       /*
> +        * Kick start the scheduler here to ensure any remaining
> +        * messages are processed
> +        */
> +       xe_guc_submit_start(guc);

Let me know what you think here Matt. We can also extend the below
timeout. I'm hoping this covers both the case I have and your VF
submission drain case.

Thanks,
Stuart

> +
>         ret = wait_event_timeout(guc->submission_state.fini_wq,
>                                  xa_empty(&guc-
> >submission_state.exec_queue_lookup),
>                                  HZ * 5);


  reply	other threads:[~2025-10-13 22:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13 22:31 [PATCH 0/7] Fix a couple of wedge corner-case memory leaks Stuart Summers
2025-10-13 22:31 ` [PATCH 1/7] drm/xe: Add additional trace points for LRCs Stuart Summers
2025-10-13 22:31 ` [PATCH 2/7] drm/xe: Add a trace point for VM close Stuart Summers
2025-10-13 22:31 ` [PATCH 3/7] drm/xe: Add the BO pointer info to the BO trace Stuart Summers
2025-10-13 22:31 ` [PATCH 4/7] drm/xe: Add new exec queue trace points Stuart Summers
2025-10-13 22:31 ` [PATCH 5/7] drm/xe: Correct migration VM teardown order Stuart Summers
2025-10-13 22:31 ` [PATCH 6/7] drm/xe: Kick start GPU scheduler on teardown Stuart Summers
2025-10-13 22:32   ` Summers, Stuart [this message]
2025-10-14  2:07     ` Matthew Brost
2025-10-13 22:31 ` [PATCH 7/7] drm/xe: Check for GuC responses on disabling scheduling Stuart Summers
2025-10-14  2:09   ` Matthew Brost
2025-10-14  3:10     ` Summers, Stuart
2025-10-14  1:04 ` ✗ CI.checkpatch: warning for Fix a couple of wedge corner-case memory leaks (rev3) Patchwork
2025-10-14  1:05 ` ✓ CI.KUnit: success " Patchwork
2025-10-14  1:50 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-10-14 10:02 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a20a8b50c04ee8fd531dfe1a416a34785321618c.camel@intel.com \
    --to=stuart.summers@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox