Already logging errno, no need log again, drop ERR_PTR(err)Replace memirq_err() calls with xe_log_err() using the MEMIRQ component tag for memory-based IRQ failures Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> --- drivers/gpu/drm/xe/xe_memirq.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c index 9dfe965cb46e..45eae58d418f 100644 --- a/drivers/gpu/drm/xe/xe_memirq.c +++ b/drivers/gpu/drm/xe/xe_memirq.c @@ -15,6 +15,7 @@ #include "xe_gt.h" #include "xe_guc.h" #include "xe_hw_engine.h" +#include "xe_log.h" #include "xe_memirq.h" #include "xe_tile_printk.h" @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq) return 0; out: - memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err)); + xe_log_err(xe, MEMIRQ, err, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err));
dittoreturn err; } @@ -370,7 +371,7 @@ int xe_memirq_init_guc(struct xe_memirq *memirq, struct xe_guc *guc) return 0; failed: - memirq_err(memirq, "Failed to setup report pages in %s (%pe)\n", + xe_log_err(memirq_to_xe(memirq), MEMIRQ, err, "Failed to setup report pages in %s (%pe)\n", guc_name(guc), ERR_PTR(err));
return err; }