From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88FD6FE51F1 for ; Fri, 24 Apr 2026 09:19:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4603710F458; Fri, 24 Apr 2026 09:19:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="FXE6wexs"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id E614210E3A4; Fri, 24 Apr 2026 09:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777022382; x=1808558382; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=XhQAxsgKi7+J2rPiUPbGk2W4vS2G8988IUhHZAJFDXg=; b=FXE6wexsR8eDAsE40TyjoW4rUTDJrXmOMTU95KV2lKTsSZO1xCqAlkjZ wYbQWkb8ISxmqKbFFHdEIM26w8MgS//34LGvDAbChJl3NWoNgqlmne3ek iDep/mmk4Q7tAWERaQQwA0JEj2BMBc8jKqzFjdqRcJcoOewF0y1w9Gder zASQz6qPRV1iNEZExRC2jcYf6V4T3tDsLNhiqmvW4+5OahwYGTEy/ReqS RA1ytnvcnLvaoUiTAXWzR3GZX3vr1Hfi+2/B18spiv5FZuwumIi0iBPiJ ZVJV+rIbXj8zA6jg63xJyJQxzfiRyrwn3xlW/uXkWOM3a3o9FzbiM2XUy A==; X-CSE-ConnectionGUID: 5uzm3JZFTTGt5h4pttAoLw== X-CSE-MsgGUID: 1LFXj//2Qt+UuAqZrcIcFA== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="81607216" X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="81607216" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 02:19:41 -0700 X-CSE-ConnectionGUID: sCShZh9HTru4u5O4hp804Q== X-CSE-MsgGUID: I5xUjv8QRMOlw6S/YrRoVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="231902003" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.89]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 02:19:40 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 03/16] drm/i915: Move the i915_dpt_offset()==0 assert In-Reply-To: <20260423165346.20884-4-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260423165346.20884-1-ville.syrjala@linux.intel.com> <20260423165346.20884-4-ville.syrjala@linux.intel.com> Date: Fri, 24 Apr 2026 12:19:37 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 23 Apr 2026, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Move the i915_dpt_offset() check into the lower level > intel_fb_pin_to_dpt() function. Clears out some of the unnecessary > junk from the higher level code, making it easier to introduce > the new fb_pin parent interface. > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_fb_pin.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_fb_pin.c b/drivers/gpu/drm/i915/i9= 15_fb_pin.c > index b800b55530a5..400ad8768c11 100644 > --- a/drivers/gpu/drm/i915/i915_fb_pin.c > +++ b/drivers/gpu/drm/i915/i915_fb_pin.c > @@ -101,6 +101,12 @@ intel_fb_pin_to_dpt(struct drm_gem_object *_obj, str= uct intel_dpt *dpt, > i915_gem_object_flush_if_display(obj); >=20=20 > i915_vma_get(vma); > + > + /* > + * The DPT object contains only one vma, and there is no VT-d > + * guard, so the VMA's offset within the DPT is always 0. > + */ > + drm_WARN_ON(&i915->drm, i915_dpt_offset(vma)); > err: > atomic_dec(&i915->pending_fb_pin); >=20=20 > @@ -255,7 +261,6 @@ int intel_plane_pin_fb(struct intel_plane_state *plan= e_state, > const struct intel_plane_state *old_plane_state) > { > struct intel_display *display =3D to_intel_display(plane_state); > - struct drm_i915_private *i915 =3D to_i915(plane_state->uapi.plane->dev); > struct intel_plane *plane =3D to_intel_plane(plane_state->uapi.plane); > const struct intel_framebuffer *fb =3D > to_intel_framebuffer(plane_state->hw.fb); > @@ -304,12 +309,6 @@ int intel_plane_pin_fb(struct intel_plane_state *pla= ne_state, > plane_state->dpt_vma =3D vma; >=20=20 > WARN_ON(plane_state->ggtt_vma =3D=3D plane_state->dpt_vma); > - > - /* > - * The DPT object contains only one vma, and there is no VT-d > - * guard, so the VMA's offset within the DPT is always 0. > - */ > - drm_WARN_ON(&i915->drm, i915_dpt_offset(plane_state->dpt_vma)); > } >=20=20 > /* --=20 Jani Nikula, Intel