From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF87D26D60 for ; Fri, 9 Jan 2026 15:41:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C120710E26D; Fri, 9 Jan 2026 15:41:56 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="VeSOrcvY"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 657BC10E26D for ; Fri, 9 Jan 2026 15:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767973316; x=1799509316; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=V+lI06df00RNRu+ig2TU7tGPJaQRwSM4wG6jQYCT01M=; b=VeSOrcvYVQAkw1JnBQiw+oVZ9sGDLz9tJog9y6cPb/OrIj/jdZPRudXQ 7Ok18iVvztVXwg44MJry4cri5WtU4D1z8qd4tvz+qUp6Pvly8+YJYkxW5 Q9CLbFGCQhezRi39M7jxqPrY1ijuoeGwrURmGpxVINQqaCQfvQFwvXrih NZlZ8Cd0SVxqwHYmgbGSVr2ZpaLfRwFmo55+Dxwz+JjCWodr+9lYbJDpW UP85PSYmKKPxUpUlrB/dKrIIU6a1o2CLTWdtJFtCGj/kmGp59d1EgsJti YDSydp0PTfuiUdwYYhYBW8y6IsL1NNVrgFLA15OzOBDYruFNdW0/4Kee/ w==; X-CSE-ConnectionGUID: u0I3pijOSJqfb3ZgZnrlxw== X-CSE-MsgGUID: Q1gnz9kUSTWGrT4RlVX3ZA== X-IronPort-AV: E=McAfee;i="6800,10657,11666"; a="69340861" X-IronPort-AV: E=Sophos;i="6.21,214,1763452800"; d="scan'208";a="69340861" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2026 07:41:56 -0800 X-CSE-ConnectionGUID: HyCfsHQ0TdecAL/wjZf8GA== X-CSE-MsgGUID: fCCHlIdDT2u5SeXnLIiCOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,214,1763452800"; d="scan'208";a="234195761" Received: from mjarzebo-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.143]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2026 07:41:53 -0800 From: Jani Nikula To: Matt Roper Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 5/5] drm/xe: improve header check In-Reply-To: <27255b05de3d18ac6b55cb139bcc8115f5812e1c@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260107155401.2379127-1-jani.nikula@intel.com> <20260107155401.2379127-5-jani.nikula@intel.com> <20260107180051.GT1180203@mdroper-desk1.amr.corp.intel.com> <27255b05de3d18ac6b55cb139bcc8115f5812e1c@intel.com> Date: Fri, 09 Jan 2026 17:41:50 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 09 Jan 2026, Jani Nikula wrote: > On Wed, 07 Jan 2026, Matt Roper wrote: >> On Wed, Jan 07, 2026 at 05:54:01PM +0200, Jani Nikula wrote: >>> Improve header check: Remove unused -DHDRTEST. Include the header twice >>> to check for include guards. Run kernel-doc on the header. >>> >>> Signed-off-by: Jani Nikula >> >> Reviewed-by: Matt Roper >> >> Didn't we used to have kerneldoc checks running in a CI.Hooks task on >> pre-merge? It seems like those vanished at some point and these >> mistakes started creeping in... > > I think they were running the full Sphinx build, which only checks > kernel-doc comments that are actually incorporated in the documentation > build. Everything else was ignored. But then there were a lot of > failures in the hook too [1]. I don't know what happened. Anyway, thanks for the reviews, merged to drm-xe-next. > > BR, > Jani. > > > [1] https://lore.kernel.org/r/175854145966.353633.13388139741450056729@1538d3639d33 > >> >> >> Matt >> >>> --- >>> drivers/gpu/drm/xe/Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile >>> index 2b20c79d7ec9..b39cbb756232 100644 >>> --- a/drivers/gpu/drm/xe/Makefile >>> +++ b/drivers/gpu/drm/xe/Makefile >>> @@ -370,7 +370,8 @@ always-$(CONFIG_DRM_XE_WERROR) += \ >>> $(patsubst %.h,%.hdrtest, $(shell cd $(src) && find * -name '*.h' $(hdrtest_find_args))) >>> >>> quiet_cmd_hdrtest = HDRTEST $(patsubst %.hdrtest,%.h,$@) >>> - cmd_hdrtest = $(CC) -DHDRTEST $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $<; touch $@ >>> + cmd_hdrtest = $(CC) $(filter-out $(CFLAGS_GCOV), $(c_flags)) -S -o /dev/null -x c /dev/null -include $< -include $<; \ >>> + $(srctree)/scripts/kernel-doc -none -Werror $<; touch $@ >>> >>> $(obj)/%.hdrtest: $(src)/%.h FORCE >>> $(call if_changed_dep,hdrtest) >>> -- >>> 2.47.3 >>> -- Jani Nikula, Intel