From: SRINIVASAN SHANMUGAM <srinivasan.shanmugam@amd.com>
To: Matthew Brost <matthew.brost@intel.com>, sashiko-reviews@lists.linux.dev
Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v8 1/3] drm: Add drm_work_fence helper
Date: Wed, 9 Sep 2026 08:30:33 +0530 [thread overview]
Message-ID: <a7ad31f9-262a-4d85-b4d0-051b722147a8@amd.com> (raw)
In-Reply-To: <aqBtFDnjT4HwM+12@gsse-cloud1.jf.intel.com>
On 9/9/2026 1:46 AM, Matthew Brost wrote:
> On Tue, Sep 08, 2026 at 08:58:39AM +0000, sashiko-bot@kernel.org wrote:
>
> All of this looks right. So I believe the solution is:
>
> - s/cancel_work_/disable_work_
> - In drm_work_fence_queue if queue_work returns false, call drm_work_fence_put()
>
> Matt
Agreed — the race is real. Will fix in Patch 1
as you suggested:
- In drm_work_fence_queue: drop ref if queue_work returns false
- In drm_work_fence_cancel_sync: switch to disable_work_sync()
Srini
next prev parent reply other threads:[~2026-09-09 3:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 8:46 [PATCH v8 0/3] drm: Extract dma-fence-to-workqueue pattern into common helpers Srinivasan Shanmugam
2026-09-08 8:46 ` [PATCH v8 1/3] drm: Add drm_work_fence helper Srinivasan Shanmugam
2026-09-08 8:58 ` sashiko-bot
2026-09-08 20:16 ` Matthew Brost
2026-09-09 3:00 ` SRINIVASAN SHANMUGAM [this message]
2026-09-09 5:20 ` SRINIVASAN SHANMUGAM
2026-09-08 8:46 ` [PATCH v8 2/3] drm: Add drm_user_fence helper Srinivasan Shanmugam
2026-09-08 8:58 ` sashiko-bot
2026-09-08 8:46 ` [PATCH v8 3/3] drm/xe: Convert xe_user_fence to drm_user_fence Srinivasan Shanmugam
2026-09-08 9:00 ` sashiko-bot
2026-09-08 20:22 ` Matthew Brost
2026-09-09 3:04 ` SRINIVASAN SHANMUGAM
2026-09-08 9:48 ` ✗ CI.checkpatch: warning for drm: Extract dma-fence-to-workqueue pattern into common helpers Patchwork
2026-09-08 9:50 ` ✓ CI.KUnit: success " Patchwork
2026-09-08 10:27 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-08 13:25 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ad31f9-262a-4d85-b4d0-051b722147a8@amd.com \
--to=srinivasan.shanmugam@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).