Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: [PATCH] drm/xe/uc: Apply RCS/CCS yield policy to SR-IOV VFs
Date: Wed, 8 Jul 2026 09:38:35 -0700	[thread overview]
Message-ID: <a88becd4-6f15-4ccb-b73c-5b9ee330b890@intel.com> (raw)
In-Reply-To: <20260708100616.1050537-1-marcin.bernatowicz@linux.intel.com>



On 7/8/2026 3:06 AM, Marcin Bernatowicz wrote:
> VFs were missing the call to apply the global scheduling policy.
> Call xe_guc_submit_enable() during vf_uc_load_hw() to ensure VFs
> get the same policy enforcement as PF.
>
> Fixes: 26caeae9fb48 ("drm/xe/guc: Set RCS/CCS yield policy")
> Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_uc.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
> index 75091bde0d50..c6f5fd966afb 100644
> --- a/drivers/gpu/drm/xe/xe_uc.c
> +++ b/drivers/gpu/drm/xe/xe_uc.c
> @@ -15,6 +15,7 @@
>   #include "xe_guc_pc.h"
>   #include "xe_guc_rc.h"
>   #include "xe_guc_engine_activity.h"
> +#include "xe_guc_submit.h"
>   #include "xe_huc.h"
>   #include "xe_sriov.h"
>   #include "xe_wopcm.h"
> @@ -159,7 +160,9 @@ static int vf_uc_load_hw(struct xe_uc *uc)
>   	if (err)
>   		return err;
>   
> -	uc->guc.submission_state.enabled = true;
> +	err = xe_guc_submit_enable(&uc->guc);
> +	if (err)
> +		return err;

On PF we call xe_guc_submit_enable() after 
xe_guc_opt_in_features_enable(). It doesn't make any difference right 
now, but IMO we should still make the VF ordering match PF in case it 
matters in the future.
With that:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Thanks for the fix!
Daniele

>   
>   	err = xe_guc_opt_in_features_enable(&uc->guc);
>   	if (err)


      parent reply	other threads:[~2026-07-08 16:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 10:06 [PATCH] drm/xe/uc: Apply RCS/CCS yield policy to SR-IOV VFs Marcin Bernatowicz
2026-07-08 10:13 ` ✓ CI.KUnit: success for " Patchwork
2026-07-08 11:00 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-08 13:06 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-07-08 15:34   ` Bernatowicz, Marcin
2026-07-08 16:38 ` Daniele Ceraolo Spurio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a88becd4-6f15-4ccb-b73c-5b9ee330b890@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=marcin.bernatowicz@linux.intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox