Re: [PATCH] drm/xe/pf: Show VFs LMEM provisioning summary over debugfs

["Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>]

On 10/21/2024 10:15 PM, Michal Wajdeczko wrote:
> While we can already view individual VF LMEM provisioning using
> lmem_quota debugfs attribute, we want to have unified way to show
> summary across all VFs, like we do for GGTT or GuC doorbells/IDs.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c  | 35 +++++++++++++++++++++
>   drivers/gpu/drm/xe/xe_gt_sriov_pf_config.h  |  1 +
>   drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c |  5 +++
>   3 files changed, 41 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> index a863e50b756e..062a0c2fd2cd 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> @@ -2376,6 +2376,41 @@ int xe_gt_sriov_pf_config_print_dbs(struct xe_gt *gt, struct drm_printer *p)
>   	return 0;
>   }
>   
> +/**
> + * xe_gt_sriov_pf_config_print_lmem - Print LMEM configurations.
> + * @gt: the &xe_gt
> + * @p: the &drm_printer
> + *
> + * Print LMEM allocations across all VFs.
> + * VFs without LMEM allocation are skipped.
> + *
> + * This function can only be called on PF.
> + * Return: 0 on success or a negative error code on failure.
> + */
> +int xe_gt_sriov_pf_config_print_lmem(struct xe_gt *gt, struct drm_printer *p)
> +{
> +	unsigned int n, total_vfs = xe_sriov_pf_get_totalvfs(gt_to_xe(gt));
> +	const struct xe_gt_sriov_config *config;
> +	char buf[10];
> +
> +	xe_gt_assert(gt, IS_SRIOV_PF(gt_to_xe(gt)));
> +	mutex_lock(xe_gt_sriov_pf_master_mutex(gt));
> +
> +	for (n = 1; n <= total_vfs; n++) {
> +		config = &gt->sriov.pf.vfs[n].config;
> +		if (!config->lmem_obj)
> +			continue;
> +
> +		string_get_size(config->lmem_obj->size, 1, STRING_UNITS_2,
> +				buf, sizeof(buf));
> +		drm_printf(p, "VF%u:\t%zu\t(%s)\n",
> +			   n, config->lmem_obj->size, buf);
> +	}
> +
> +	mutex_unlock(xe_gt_sriov_pf_master_mutex(gt));
> +	return 0;
> +}
> +
>   /**
>    * xe_gt_sriov_pf_config_print_available_ggtt - Print available GGTT ranges.
>    * @gt: the &xe_gt
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.h b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.h
> index b74ec38baa18..0c55aa40a1a7 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.h
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.h
> @@ -65,6 +65,7 @@ void xe_gt_sriov_pf_config_restart(struct xe_gt *gt);
>   int xe_gt_sriov_pf_config_print_ggtt(struct xe_gt *gt, struct drm_printer *p);
>   int xe_gt_sriov_pf_config_print_ctxs(struct xe_gt *gt, struct drm_printer *p);
>   int xe_gt_sriov_pf_config_print_dbs(struct xe_gt *gt, struct drm_printer *p);
> +int xe_gt_sriov_pf_config_print_lmem(struct xe_gt *gt, struct drm_printer *p);
>   
>   int xe_gt_sriov_pf_config_print_available_ggtt(struct xe_gt *gt, struct drm_printer *p);
>   
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c
> index 91fc42e386d8..05df4ab3514b 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c
> @@ -81,6 +81,11 @@ static const struct drm_info_list pf_info[] = {
>   		.show = xe_gt_debugfs_simple_show,
>   		.data = xe_gt_sriov_pf_config_print_dbs,
>   	},
> +	{
> +		"lmem_provisioned",
> +		.show = xe_gt_debugfs_simple_show,
> +		.data = xe_gt_sriov_pf_config_print_lmem,
> +	},

LGTM,
Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
>   	{
>   		"runtime_registers",
>   		.show = xe_gt_debugfs_simple_show,