Re: [PATCH v5 1/8] drm/xe/guc: Remove spurious line feed in debug print

[John Harrison <john.c.harrison@intel.com>]

On 7/30/2024 02:14, Michal Wajdeczko wrote:
>
> On 30.07.2024 01:17, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> Including line feeds at the start of a debug print messes up the
>> output when sent to dmesg. The break actually appears between all the
>> usefu
> typo
>
>> prefix information and the actual string being printed. In this
>> case, each block of data has a very clear start line and an extra
>> delimeter is really not necessary. So don't do it.
>>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> there was some discussion about merging this one without a conclusion
>
> [1] https://patchwork.freedesktop.org/patch/601018/?series=135447&rev=1
The last comment was for Mesa people to shout if it would be a problem 
and no-one shouted, so...

However, I would strongly argue that devcoredump exact layout and 
content cannot be considered UABI because it is going to change as the 
driver changes. Some of the information being printed is internal driver 
state. Driver internals can never be UABI. If there are userland tools 
parsing the dump then those tools have to be able to adapt to changing 
core dump formats. There is also the argument that we are still in 
force-probe so there is no fixed UABI yet anyway. So now is the time to 
get the formatting as good as possible before officially going live.

John.


>
>> ---
>>   drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
>> index beeeb120d1fc..422c3f5c87d8 100644
>> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
>> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
>> @@ -1515,7 +1515,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
>>   		drm_puts(p, "H2G CTB (all sizes in DW):\n");
>>   		guc_ctb_snapshot_print(&snapshot->h2g, p);
>>   
>> -		drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
>> +		drm_puts(p, "G2H CTB (all sizes in DW):\n");
>>   		guc_ctb_snapshot_print(&snapshot->g2h, p);
>>   
>>   		drm_printf(p, "\tg2h outstanding: %d\n",