From: Raag Jadav <raag.jadav@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org,
Matthew Brost <matthew.brost@intel.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH] drm/xe/guc_submit: Simplify and fix diff calculation
Date: Tue, 13 May 2025 17:59:54 +0300 [thread overview]
Message-ID: <aCNeatXnJUUgJYle@black.fi.intel.com> (raw)
In-Reply-To: <20250513-time-wrap-v1-1-fba9a69a65c8@intel.com>
On Tue, May 13, 2025 at 07:25:49AM -0700, Lucas De Marchi wrote:
> With a u32 type, there's no need to check which one is greater: the
> current is always the latest and if it's less than the previous, it's
> because it wrapped: just do the unsigned calculation that will lead to
> the same result, or better the correct one. It fixes an off-by-one in
> the wrapped calculation, however that doesn't really matter for the
> timeout calculation.
I remember coming across something similar in hwmon as well.
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
next prev parent reply other threads:[~2025-05-13 15:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 14:25 [PATCH] drm/xe/guc_submit: Simplify and fix diff calculation Lucas De Marchi
2025-05-13 14:59 ` Raag Jadav [this message]
2025-05-14 14:32 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-14 14:32 ` ✓ CI.checkpatch: " Patchwork
2025-05-14 14:33 ` ✓ CI.KUnit: " Patchwork
2025-05-14 14:52 ` ✓ CI.Hooks: " Patchwork
2025-05-14 14:55 ` ✓ CI.Build: " Patchwork
2025-05-14 14:56 ` ✓ CI.checksparse: " Patchwork
2025-05-14 15:26 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-14 20:35 ` ✓ Xe.CI.Full: " Patchwork
2025-05-14 22:29 ` [PATCH] " Umesh Nerlige Ramappa
2025-05-14 23:54 ` Matthew Brost
2025-05-27 0:29 ` ✗ CI.Patch_applied: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCNeatXnJUUgJYle@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox