From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33C00C5AD49 for ; Mon, 2 Jun 2025 14:43:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E12B010E2E1; Mon, 2 Jun 2025 14:43:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; secure) header.d=ffwll.ch header.i=@ffwll.ch header.b="Kp/JOzXc"; dkim-atps=neutral Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6FDF10E2E1 for ; Mon, 2 Jun 2025 14:43:40 +0000 (UTC) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-442fda876a6so39231955e9.0 for ; Mon, 02 Jun 2025 07:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1748875419; x=1749480219; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BmRnOjxFQaT42NxVRt03FTSH3KzxlAbjYGkqubhhB6U=; b=Kp/JOzXcjUujEKt6YVl/hqlF+O8YMLFLNmtNh70tBHfZsUXpCWZsKUC23+Nopfh30t 8rxud6d1of92/kWd8iS/xn+Y2JAE4dbY3Q77YQUVGjkjVMgdJ0VGrunV1IrDuqJjxl3Q BscXo01RGAUhkmg0dDNzKhLdnFp/ycsnPtQdw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748875419; x=1749480219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BmRnOjxFQaT42NxVRt03FTSH3KzxlAbjYGkqubhhB6U=; b=DPH0VEFXvNsVTacFA/0t4qXj2ce3GRTAkj9UAKJDS8HJRB8wwselABUu0Bg6dyb9Ce ZbPYnTCqaldnOlsWO/95AI7EJNyrN4/k0FQ0ITklJ4JBT+PY/SfOP87H/E/v7DYAJJJt c5uopGBHUDQvN2HiYjuENRomd7yZxhYdAJsA7vM2CGdgJmIhbqptIpE6Dk3hDc/QVPij HPBDBqA933cZc8OHewH20J5EreDyHGcGX7Os66lAZ0/Uk5QiYzDp0yBujAQnVg8iqd0D lyT7FRzTD9gX3rLzGS4m5QeHqo45IeEGbUPZLydF+rcAavaS0qtzLXpubnO25k6FWsd9 BiUw== X-Forwarded-Encrypted: i=1; AJvYcCWyzBSgFzcjBxOGMl3Wb6empbFWEfnK17Wz0rLDW9jf58zPjv0ogbhPfkgloafhbNBFT+EKtldXGg==@lists.freedesktop.org X-Gm-Message-State: AOJu0YyjCpdIcmm2JgZR+Mu85TOSmm23PUxxYVkpmY6gktoo1IAUY3x9 Lo2ItYDfJFvkkNQPbunu16Y4n+RU8EcAkSihreJwpTUM5EcYpXkvwBMHARtuRl/aUM8= X-Gm-Gg: ASbGnctlqUkn0emG6TiGykxUf0QYJ643wswRqOSer2KCDI2ugSfMQcMW8uUuXudh9gD qdZlxVCXCRsmmodLE73pmPG3v0pYqQcYYfFNzuDy/z6sBDQygieEhxU3soG0Fqwac/EIlmDOHK9 zYQ5loVNt2Uz/3lP3EoM5gX+9UNIVOOm6OZwnBCHC7YhrDrrPJnJl7P+h63DHiRJJo2HImrXQ7u s7hcSimvAAjNZGWoIJcvDCaEK3DV94xS7R9t4OzvBaYZPPJN8eBeZm80ARXWQ6A15K60qasLEO8 1+cV5YUSndradwLlrliPpoXSlf4y5yh+hAY0F6QodRYuodxduslKTK6EdJ4nIho= X-Google-Smtp-Source: AGHT+IFo+Z0NR0XEqF7bGgCU/zFo04aIkuwKr4I5i9fvBh1/D97TYslci1leA382fPNo1VYX/jntFg== X-Received: by 2002:a05:600c:8b34:b0:442:ccfa:1461 with SMTP id 5b1f17b1804b1-4511ecc2a30mr78544895e9.13.1748875418792; Mon, 02 Jun 2025 07:43:38 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f00971e4sm15380816f8f.65.2025.06.02.07.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 07:43:38 -0700 (PDT) Date: Mon, 2 Jun 2025 16:43:35 +0200 From: Simona Vetter To: Jeff Hugo Cc: Simona Vetter , DRI Development , intel-xe@lists.freedesktop.org, Carl Vanderlip , linux-arm-msm@vger.kernel.org, Simona Vetter Subject: Re: [PATCH 4/8] accel/qaic: delete qaic_bo.handle Message-ID: References: <20250528091307.1894940-1-simona.vetter@ffwll.ch> <20250528091307.1894940-5-simona.vetter@ffwll.ch> <70ad82b5-19f3-4e05-bc7a-858dafc563ef@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70ad82b5-19f3-4e05-bc7a-858dafc563ef@oss.qualcomm.com> X-Operating-System: Linux phenom 6.12.25-amd64 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, May 28, 2025 at 09:15:22AM -0600, Jeff Hugo wrote: > On 5/28/2025 3:13 AM, Simona Vetter wrote: > > Handles are per-file, not global, so this makes no sense. Plus it's > > set only after calling drm_gem_handle_create(), and drivers are not > > allowed to further intialize a bo after that function has published it > > already. > > intialize -> initialize > > > It is also entirely unused, which helps enormously with removing it > > :-) > > There is a downstream reference to it which hasn't quite made it upstream > yet, but tweaking that should be fine. This is clearly a problem anyways, so > we'll need to find a solution regardless. Thank you very much for the audit. > > > Since we're still holding a reference to the bo nothing bad can > > happen, hence not cc: stable material. > > > > Cc: Jeff Hugo > > Cc: Carl Vanderlip > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Simona Vetter > > Signed-off-by: Simona Vetter > > SOB chain seems weird to me. I got this email from @ffwll.ch, which would be > the author. Where is @intel.com contributing to the handoff of the patch? I work for intel, so I just whack both of my emails on there for sob purposes. The intel email tends to be a blackhole for public mail, which is why I don't use it as From: for anything public. > Overall, looks good to me. Seems like either I can ack this, and you can > merge, or I can just take it forward. I have no preference. Do you? Whatever you like most, I'll resend the series with the wrong patches dropped soon anyway. -Sima -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch