From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3204C5B543 for ; Tue, 27 May 2025 18:35:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE18F10E1E1; Tue, 27 May 2025 18:35:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XEDJ1Atv"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E56610E0E0; Tue, 27 May 2025 18:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748370915; x=1779906915; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+8+iElqWcT0dDbkP3pmK2f9v7upnAUnEd8g7APK4p64=; b=XEDJ1AtvdkBXNgApt4XRWBE2KN66UTlbAJzFYKpVp4ukZTJcYnQKQ3kY yNYlshN0vm/R6MF7unWb9mhE916X8w7qs5XwFitwTmwzXLSl0Fd6LIDfK 7gsW993NhG3UqVHV9VH5vDcuoyslp4I/REEm5b5/U0lA1LrVe/4Y5HLNI GIiHFJnV9yQw/csQHip6doPkPUU4TxhO7icfdi11xuKyxDyu3JbIGlAL3 CWNZlfCSRM/LJ5A5GBnOshIzjDPqW2+ZmRnvEXt5JsRVZQ4eCHBnLRbPs sUSMML13r6lxlfBlFyLxW5UdXzU1bAymAJn8WOYo6XOmcEkkMYkSkzfdY A==; X-CSE-ConnectionGUID: f0aSGIYTTyKlp14jrOnqWg== X-CSE-MsgGUID: 3AIE+kIvTL6ORiSZSbDecg== X-IronPort-AV: E=McAfee;i="6700,10204,11446"; a="61038205" X-IronPort-AV: E=Sophos;i="6.15,319,1739865600"; d="scan'208";a="61038205" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2025 11:35:14 -0700 X-CSE-ConnectionGUID: 0Wi5oRxtSpqfrK8DIV1HeA== X-CSE-MsgGUID: scnxzUhMSNq2G1HdZlyC5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,319,1739865600"; d="scan'208";a="147688246" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2025 11:35:09 -0700 Date: Tue, 27 May 2025 21:35:05 +0300 From: Raag Jadav To: "Usyskin, Alexander" Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , "De Marchi, Lucas" , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , "Vivi, Rodrigo" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , "Poosa, Karthik" , "Abliyev, Reuven" , "Weil, Oren jer" , "linux-mtd@lists.infradead.org" , "intel-xe@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Tomas Winkler Subject: Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete graphics Message-ID: References: <20250515133345.2805031-1-alexander.usyskin@intel.com> <20250515133345.2805031-7-alexander.usyskin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, May 27, 2025 at 11:30:20AM +0530, Usyskin, Alexander wrote: > > Subject: Re: [PATCH v10 06/10] drm/i915/nvm: add nvm device for discrete > > graphics > > > > On Thu, May 15, 2025 at 04:33:41PM +0300, Alexander Usyskin wrote: > > > Enable access to internal non-volatile memory on > > > DGFX devices via a child device. > > > The nvm child device is exposed via auxiliary bus. > > > > ... > > > > > +void intel_nvm_init(struct drm_i915_private *i915) > > > +{ > > > > Lucas recently revamped xe driver to address this, so let's not hide bugs > > and return an error where possible. > > > I can return error from this call, but the SPI failure is non-fatal for Xe. > Caller should ignore error from this init. Fair. Let's atleast return error and leave the handling to the caller, so we don't have to come back revamping it in the future. Raag