Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
	<thomas.hellstrom@linux.intel.com>,
	<himal.prasad.ghimiray@intel.com>
Subject: Re: [PATCH] drm/xe: Do not warn on SVM migration failing because of 64k requirements
Date: Thu, 29 May 2025 13:26:28 -0400	[thread overview]
Message-ID: <aDiYxAzsVd_IeOEb@intel.com> (raw)
In-Reply-To: <20250529164338.1745515-1-matthew.brost@intel.com>

On Thu, May 29, 2025 at 09:43:38AM -0700, Matthew Brost wrote:
> On platforms which only support 64k VRAM pages, it is expected that 4k
> faults will not migrate. Do not warn on this, rather print a debug
> message.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
> index 871ac81bb04a..f27fb9b588de 100644
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c
> @@ -821,7 +821,7 @@ bool xe_svm_range_needs_migrate_to_vram(struct xe_svm_range *range, struct xe_vm
>  	}
>  
>  	if (preferred_region_is_vram && range_size <= SZ_64K && !supports_4K_migration(vm->xe)) {
> -		drm_warn(&vm->xe->drm, "Platform doesn't support SZ_4K range migration\n");
> +		drm_dbg(&vm->xe->drm, "Platform doesn't support SZ_4K range migration\n");
>  		return false;
>  	}
>  
> -- 
> 2.34.1
> 

  reply	other threads:[~2025-05-29 17:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 16:43 [PATCH] drm/xe: Do not warn on SVM migration failing because of 64k requirements Matthew Brost
2025-05-29 17:26 ` Rodrigo Vivi [this message]
2025-05-29 17:41 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-29 17:41 ` ✓ CI.checkpatch: " Patchwork
2025-05-29 17:42 ` ✓ CI.KUnit: " Patchwork
2025-05-29 17:53 ` ✓ CI.Build: " Patchwork
2025-05-29 17:55 ` ✓ CI.Hooks: " Patchwork
2025-05-29 17:57 ` ✓ CI.checksparse: " Patchwork
2025-05-29 18:17 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-30  7:22 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDiYxAzsVd_IeOEb@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox