From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1BDFC7EE31 for ; Thu, 26 Jun 2025 14:24:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA6F710E2C3; Thu, 26 Jun 2025 14:24:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WFnHTUUm"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE83D10E2C3 for ; Thu, 26 Jun 2025 14:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750947875; x=1782483875; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AWURGxNzG6EnaOcS8fijAmqGcl2i0t+H3UsBIkyG1sQ=; b=WFnHTUUmge5mpbvLmsreJJF0DIhWOLkr6HtvYboOT3/7xdao8KtBNw9R ZI1Bd+j/BAlFnSz1Q+Rw7DLLLuFaecE7T8xJKTC75SHD4kyyIQQHEFD7J BVWhisTMIZGvAr+dgD8NRBcfL2fBx07Ra3pjDmLjheCyams+ag2/t7HvX Ole+h8QhT8VZhuq6/ieZKWr4NanQjwlfy2LmhyLW3QxQ9KZb3YEEL2MmN j7WsvKgnAxB0EedVWWwW2GfVNCIg/z9qwRP3qLvEVZrHN+2EMBg3HVSo0 b208GtSVvo9RCazI2VFJ9stYQgZoYLVWu3OQ+zg4YUnN8S2Osayyh+x0Q w==; X-CSE-ConnectionGUID: iK4JMo6sSQuMqvMARO/mhw== X-CSE-MsgGUID: Bi7DrTsZQ0GJ7bTnrsDbew== X-IronPort-AV: E=McAfee;i="6800,10657,11475"; a="63503642" X-IronPort-AV: E=Sophos;i="6.16,267,1744095600"; d="scan'208";a="63503642" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2025 07:24:34 -0700 X-CSE-ConnectionGUID: cXkDad8pRjymYE54LcwmpA== X-CSE-MsgGUID: hYCNCOR5S92ymj0rRHPIpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,267,1744095600"; d="scan'208";a="158280207" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2025 07:24:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uUnWc-0000000ACOy-43Ez; Thu, 26 Jun 2025 17:24:26 +0300 Date: Thu, 26 Jun 2025 17:24:26 +0300 From: Andy Shevchenko To: Heikki Krogerus Cc: Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Jarkko Nikula , David Airlie , Simona Vetter , Mika Westerberg , Jan Dabros , Andi Shyti , Raag Jadav , "Tauro, Riana" , "Adatrao, Srinivasa" , "Michael J. Ruhl" , intel-xe@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/4] drm/xe/xe_i2c: Add support for i2c in survivability mode Message-ID: References: <20250626135610.299943-1-heikki.krogerus@linux.intel.com> <20250626135610.299943-5-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250626135610.299943-5-heikki.krogerus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Jun 26, 2025 at 04:56:09PM +0300, Heikki Krogerus wrote: > > Initialize i2c in survivability mode to allow firmware > update of Add-In Management Controller (AMC) in survivability mode ... > +err: > + /* > + * But if it fails, device can't enter survivability > + * so move it back for correct error handling While at it, add a period at the end. > + */ > + survivability->mode = false; > + return ret; -- With Best Regards, Andy Shevchenko