Re: [PATCH 2/6] drm/xe: stop asserting on the TTM refcount

[Matthew Brost <matthew.brost@intel.com>]

On Mon, Jun 16, 2025 at 03:07:22PM +0200, Christian König wrote:
> The TTM refcount is about to be removed.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>  drivers/gpu/drm/xe/xe_bo.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index 7aa2c17825da..2a8e7cb8c982 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -1417,8 +1417,6 @@ static bool xe_ttm_bo_lock_in_destructor(struct ttm_buffer_object *ttm_bo)
>  	struct xe_device *xe = ttm_to_xe_device(ttm_bo->bdev);
>  	bool locked;
>  
> -	xe_assert(xe, !kref_read(&ttm_bo->kref));
> -

Maybe drop this patch and the last one in the series and replace them
with an assert(!gem.refcount). I think that would be okay and wouldn’t
break anything while retaining the spirit of this assert.

Matt

>  	/*
>  	 * We can typically only race with TTM trylocking under the
>  	 * lru_lock, which will immediately be unlocked again since
> -- 
> 2.34.1
>