[PATCH v5 00/10] Introducing firmware late binding

[PATCH v5 00/10] Introducing firmware late binding

[Badal Nilawar]

Introducing firmware late binding feature to enable firmware loading
for the devices, such as the fan controller and voltage regulator,
during the driver probe.
Typically, firmware for these devices are part of IFWI flash image but
can be replaced at probe after OEM tuning.

v2:
 - Dropped voltage regulator specific code as binaries for it will not
   be available for upstreaming as of now.
 - Address review comments
v3:
 - Dropped fwctl patch for now
 - Added new patch to extract binary version
 - Address v2 review comments
v4:
 - Address v3 review comments
v5:
 xe_kmd:
 - Dropped mutex is worker flush in unbind blocking component
   removal while fw download is in progress
 - Handled the fw load in all 3 scenarios (probe, system resume, rpm resume)
   by holding rpm wake ref in outer bounds of worker.
 mei:
 - Most of the review comments

Alexander Usyskin (2):
  mei: bus: add mei_cldev_mtu interface
  mei: late_bind: add late binding component driver

Badal Nilawar (8):
  drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw
  drm/xe/xe_late_bind_fw: Initialize late binding firmware
  drm/xe/xe_late_bind_fw: Load late binding firmware
  drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume
  drm/xe/xe_late_bind_fw: Reload late binding fw during system resume
  drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late
    binding
  drm/xe/xe_late_bind_fw: Extract and print version info
  drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

 drivers/gpu/drm/xe/Kconfig                  |   1 +
 drivers/gpu/drm/xe/Makefile                 |   1 +
 drivers/gpu/drm/xe/xe_debugfs.c             |  41 ++
 drivers/gpu/drm/xe/xe_device.c              |   5 +
 drivers/gpu/drm/xe/xe_device_types.h        |   6 +
 drivers/gpu/drm/xe/xe_late_bind_fw.c        | 454 ++++++++++++++++++++
 drivers/gpu/drm/xe/xe_late_bind_fw.h        |  17 +
 drivers/gpu/drm/xe/xe_late_bind_fw_types.h  |  77 ++++
 drivers/gpu/drm/xe/xe_pci.c                 |   3 +
 drivers/gpu/drm/xe/xe_pm.c                  |   8 +
 drivers/gpu/drm/xe/xe_uc_fw_abi.h           |  66 +++
 drivers/misc/mei/Kconfig                    |   1 +
 drivers/misc/mei/Makefile                   |   1 +
 drivers/misc/mei/bus.c                      |  13 +
 drivers/misc/mei/late_bind/Kconfig          |  13 +
 drivers/misc/mei/late_bind/Makefile         |   9 +
 drivers/misc/mei/late_bind/mei_late_bind.c  | 272 ++++++++++++
 include/drm/intel/i915_component.h          |   1 +
 include/drm/intel/late_bind_mei_interface.h |  64 +++
 include/linux/mei_cl_bus.h                  |   1 +
 20 files changed, 1054 insertions(+)
 create mode 100644 drivers/gpu/drm/xe/xe_late_bind_fw.c
 create mode 100644 drivers/gpu/drm/xe/xe_late_bind_fw.h
 create mode 100644 drivers/gpu/drm/xe/xe_late_bind_fw_types.h
 create mode 100644 drivers/misc/mei/late_bind/Kconfig
 create mode 100644 drivers/misc/mei/late_bind/Makefile
 create mode 100644 drivers/misc/mei/late_bind/mei_late_bind.c
 create mode 100644 include/drm/intel/late_bind_mei_interface.h

-- 
2.34.1

[PATCH v5 01/10] mei: bus: add mei_cldev_mtu interface

[Badal Nilawar]

From: Alexander Usyskin <alexander.usyskin@intel.com>

Allow to bus client to obtain client mtu.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
 drivers/misc/mei/bus.c     | 13 +++++++++++++
 include/linux/mei_cl_bus.h |  1 +
 2 files changed, 14 insertions(+)

diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index 67176caf5416..f860b1b6eda0 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -614,6 +614,19 @@ u8 mei_cldev_ver(const struct mei_cl_device *cldev)
 }
 EXPORT_SYMBOL_GPL(mei_cldev_ver);
 
+/**
+ * mei_cldev_mtu - max message that client can send and receive
+ *
+ * @cldev: mei client device
+ *
+ * Return: mtu or 0 if client is not connected
+ */
+size_t mei_cldev_mtu(const struct mei_cl_device *cldev)
+{
+	return mei_cl_mtu(cldev->cl);
+}
+EXPORT_SYMBOL_GPL(mei_cldev_mtu);
+
 /**
  * mei_cldev_enabled - check whether the device is enabled
  *
diff --git a/include/linux/mei_cl_bus.h b/include/linux/mei_cl_bus.h
index 725fd7727422..a82755e1fc40 100644
--- a/include/linux/mei_cl_bus.h
+++ b/include/linux/mei_cl_bus.h
@@ -113,6 +113,7 @@ int mei_cldev_register_notif_cb(struct mei_cl_device *cldev,
 				mei_cldev_cb_t notif_cb);
 
 u8 mei_cldev_ver(const struct mei_cl_device *cldev);
+size_t mei_cldev_mtu(const struct mei_cl_device *cldev);
 
 void *mei_cldev_get_drvdata(const struct mei_cl_device *cldev);
 void mei_cldev_set_drvdata(struct mei_cl_device *cldev, void *data);
-- 
2.34.1

[PATCH v5 02/10] mei: late_bind: add late binding component driver

[Badal Nilawar]

From: Alexander Usyskin <alexander.usyskin@intel.com>

Add late binding component driver.
It allows pushing the late binding configuration from, for example,
the Xe graphics driver to the Intel discrete graphics card's CSE device.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
v2:
 - Use generic naming (Jani)
 - Drop xe_late_bind_component struct to move to xe code (Daniele/Sasha)
v3:
 - Updated kconfig description
 - Move CSC late binding specific flags/defines to late_bind_mei_interface.h (Daniele)
 - Add match for PCI_CLASS_DISPLAY_OTHER to support headless cards (Anshuman)
v4:
 - Add fixes in push_config (Sasha)
 - Use INTEL_ prefix for component, refine doc,
   add status enum to headerlate_bind_mei_interface.h (Anshuman)
v5:
 - Addressed review comments
---
 drivers/misc/mei/Kconfig                    |   1 +
 drivers/misc/mei/Makefile                   |   1 +
 drivers/misc/mei/late_bind/Kconfig          |  13 +
 drivers/misc/mei/late_bind/Makefile         |   9 +
 drivers/misc/mei/late_bind/mei_late_bind.c  | 272 ++++++++++++++++++++
 include/drm/intel/i915_component.h          |   1 +
 include/drm/intel/late_bind_mei_interface.h |  64 +++++
 7 files changed, 361 insertions(+)
 create mode 100644 drivers/misc/mei/late_bind/Kconfig
 create mode 100644 drivers/misc/mei/late_bind/Makefile
 create mode 100644 drivers/misc/mei/late_bind/mei_late_bind.c
 create mode 100644 include/drm/intel/late_bind_mei_interface.h

diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
index 7575fee96cc6..771becc68095 100644
--- a/drivers/misc/mei/Kconfig
+++ b/drivers/misc/mei/Kconfig
@@ -84,5 +84,6 @@ config INTEL_MEI_VSC
 source "drivers/misc/mei/hdcp/Kconfig"
 source "drivers/misc/mei/pxp/Kconfig"
 source "drivers/misc/mei/gsc_proxy/Kconfig"
+source "drivers/misc/mei/late_bind/Kconfig"
 
 endif
diff --git a/drivers/misc/mei/Makefile b/drivers/misc/mei/Makefile
index 6f9fdbf1a495..84bfde888d81 100644
--- a/drivers/misc/mei/Makefile
+++ b/drivers/misc/mei/Makefile
@@ -31,6 +31,7 @@ CFLAGS_mei-trace.o = -I$(src)
 obj-$(CONFIG_INTEL_MEI_HDCP) += hdcp/
 obj-$(CONFIG_INTEL_MEI_PXP) += pxp/
 obj-$(CONFIG_INTEL_MEI_GSC_PROXY) += gsc_proxy/
+obj-$(CONFIG_INTEL_MEI_LATE_BIND) += late_bind/
 
 obj-$(CONFIG_INTEL_MEI_VSC_HW) += mei-vsc-hw.o
 mei-vsc-hw-y := vsc-tp.o
diff --git a/drivers/misc/mei/late_bind/Kconfig b/drivers/misc/mei/late_bind/Kconfig
new file mode 100644
index 000000000000..65c7180c5678
--- /dev/null
+++ b/drivers/misc/mei/late_bind/Kconfig
@@ -0,0 +1,13 @@
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025, Intel Corporation. All rights reserved.
+#
+config INTEL_MEI_LATE_BIND
+	tristate "Intel late binding support on ME Interface"
+	select INTEL_MEI_ME
+	depends on DRM_XE
+	help
+	  MEI Support for Late Binding for Intel graphics card.
+
+	  Enables the ME FW interfaces for Late Binding feature,
+	  allowing loading of firmware for the devices like Fan
+	  Controller during by Intel Xe driver.
diff --git a/drivers/misc/mei/late_bind/Makefile b/drivers/misc/mei/late_bind/Makefile
new file mode 100644
index 000000000000..a0aeda5853f0
--- /dev/null
+++ b/drivers/misc/mei/late_bind/Makefile
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Copyright (c) 2025, Intel Corporation. All rights reserved.
+#
+# Makefile - Late Binding client driver for Intel MEI Bus Driver.
+
+subdir-ccflags-y += -I$(srctree)/drivers/misc/mei/
+
+obj-$(CONFIG_INTEL_MEI_LATE_BIND) += mei_late_bind.o
diff --git a/drivers/misc/mei/late_bind/mei_late_bind.c b/drivers/misc/mei/late_bind/mei_late_bind.c
new file mode 100644
index 000000000000..0a8d6b2e0666
--- /dev/null
+++ b/drivers/misc/mei/late_bind/mei_late_bind.c
@@ -0,0 +1,272 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2025 Intel Corporation
+ */
+#include <drm/intel/i915_component.h>
+#include <drm/intel/late_bind_mei_interface.h>
+#include <linux/component.h>
+#include <linux/pci.h>
+#include <linux/mei_cl_bus.h>
+#include <linux/module.h>
+#include <linux/overflow.h>
+#include <linux/slab.h>
+#include <linux/uuid.h>
+
+#include "mkhi.h"
+
+#define GFX_SRV_MKHI_LATE_BINDING_CMD 0x12
+#define GFX_SRV_MKHI_LATE_BINDING_RSP (GFX_SRV_MKHI_LATE_BINDING_CMD | 0x80)
+
+#define LATE_BIND_SEND_TIMEOUT_MSEC 3000
+#define LATE_BIND_RECV_TIMEOUT_MSEC 3000
+
+/**
+ * struct csc_heci_late_bind_req - late binding request
+ * @header: @ref mkhi_msg_hdr
+ * @type: type of the late binding payload
+ * @flags: flags to be passed to the firmware
+ * @reserved: reserved field
+ * @payload_size: size of the payload data in bytes
+ * @payload: data to be sent to the firmware
+ */
+struct csc_heci_late_bind_req {
+	struct mkhi_msg_hdr header;
+	u32 type;
+	u32 flags;
+	u32 reserved[2];
+	u32 payload_size;
+	u8  payload[] __counted_by(payload_size);
+} __packed;
+
+/**
+ * struct csc_heci_late_bind_rsp - late binding response
+ * @header: @ref mkhi_msg_hdr
+ * @type: type of the late binding payload
+ * @reserved: reserved field
+ * @status: status of the late binding command execution by firmware
+ */
+struct csc_heci_late_bind_rsp {
+	struct mkhi_msg_hdr header;
+	u32 type;
+	u32 reserved[2];
+	u32 status;
+} __packed;
+
+static int mei_late_bind_check_response(const struct device *dev, const struct mkhi_msg_hdr *hdr)
+{
+	if (hdr->group_id != MKHI_GROUP_ID_GFX) {
+		dev_err(dev, "Mismatch group id: 0x%x instead of 0x%x\n",
+			hdr->group_id, MKHI_GROUP_ID_GFX);
+		return -EINVAL;
+	}
+
+	if (hdr->command != GFX_SRV_MKHI_LATE_BINDING_RSP) {
+		dev_err(dev, "Mismatch command: 0x%x instead of 0x%x\n",
+			hdr->command, GFX_SRV_MKHI_LATE_BINDING_RSP);
+		return -EINVAL;
+	}
+
+	if (hdr->result) {
+		dev_err(dev, "Error in result: 0x%x\n", hdr->result);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int mei_late_bind_push_config(struct device *dev, enum late_bind_type type, u32 flags,
+				     const void *payload, size_t payload_size)
+{
+	struct mei_cl_device *cldev;
+	struct csc_heci_late_bind_req *req = NULL;
+	struct csc_heci_late_bind_rsp rsp;
+	size_t req_size;
+	ssize_t bytes;
+	int ret;
+
+	cldev = to_mei_cl_device(dev);
+
+	ret = mei_cldev_enable(cldev);
+	if (ret) {
+		dev_dbg(dev, "mei_cldev_enable failed. %d\n", ret);
+		return ret;
+	}
+
+	req_size = struct_size(req, payload, payload_size);
+	if (req_size > mei_cldev_mtu(cldev)) {
+		dev_err(dev, "Payload is too big %zu\n", payload_size);
+		ret = -EMSGSIZE;
+		goto end;
+	}
+
+	req = kmalloc(req_size, GFP_KERNEL);
+	if (!req) {
+		ret = -ENOMEM;
+		goto end;
+	}
+
+	req->header.group_id = MKHI_GROUP_ID_GFX;
+	req->header.command = GFX_SRV_MKHI_LATE_BINDING_CMD;
+	req->type = type;
+	req->flags = flags;
+	req->reserved[0] = 0;
+	req->reserved[1] = 0;
+	req->payload_size = payload_size;
+	memcpy(req->payload, payload, payload_size);
+
+	bytes = mei_cldev_send_timeout(cldev,
+				       (void *)req, req_size, LATE_BIND_SEND_TIMEOUT_MSEC);
+	if (bytes < 0) {
+		dev_err(dev, "mei_cldev_send failed. %zd\n", bytes);
+		ret = bytes;
+		goto end;
+	}
+
+	bytes = mei_cldev_recv_timeout(cldev,
+				       (void *)&rsp, sizeof(rsp), LATE_BIND_RECV_TIMEOUT_MSEC);
+	if (bytes < 0) {
+		dev_err(dev, "mei_cldev_recv failed. %zd\n", bytes);
+		ret = bytes;
+		goto end;
+	}
+	if (bytes < sizeof(rsp.header)) {
+		dev_err(dev, "bad response header from the firmware: size %zd < %zu\n",
+			bytes, sizeof(rsp.header));
+		ret = -EPROTO;
+		goto end;
+	}
+	if (mei_late_bind_check_response(dev, &rsp.header)) {
+		dev_err(dev, "bad result response from the firmware: 0x%x\n",
+			*(uint32_t *)&rsp.header);
+		ret = -EPROTO;
+		goto end;
+	}
+	if (bytes < sizeof(rsp)) {
+		dev_err(dev, "bad response from the firmware: size %zd < %zu\n",
+			bytes, sizeof(rsp));
+		ret = -EPROTO;
+		goto end;
+	}
+
+	dev_dbg(dev, "%s status = %u\n", __func__, rsp.status);
+	ret = (int)rsp.status;
+end:
+	mei_cldev_disable(cldev);
+	kfree(req);
+	return ret;
+}
+
+static const struct late_bind_component_ops mei_late_bind_ops = {
+	.owner = THIS_MODULE,
+	.push_config = mei_late_bind_push_config,
+};
+
+static int mei_component_master_bind(struct device *dev)
+{
+	return component_bind_all(dev, (void *)&mei_late_bind_ops);
+}
+
+static void mei_component_master_unbind(struct device *dev)
+{
+	component_unbind_all(dev, (void *)&mei_late_bind_ops);
+}
+
+static const struct component_master_ops mei_component_master_ops = {
+	.bind = mei_component_master_bind,
+	.unbind = mei_component_master_unbind,
+};
+
+/**
+ * mei_late_bind_component_match - compare function for matching mei late bind.
+ *
+ *    This function checks if requester is Intel PCI_CLASS_DISPLAY_VGA or
+ *    PCI_CLASS_DISPLAY_OTHER device, and checks if the requester is the
+ *    grand parent of mei_if i.e. late_bind mei device
+ *
+ * @dev: master device
+ * @subcomponent: subcomponent to match (INTEL_COMPONENT_LATE_BIND)
+ * @data: compare data (late_bind mei device on mei bus)
+ *
+ * Return:
+ * * 1 - if components match
+ * * 0 - otherwise
+ */
+static int mei_late_bind_component_match(struct device *dev, int subcomponent,
+					 void *data)
+{
+	struct device *base = data;
+	struct pci_dev *pdev;
+
+	if (!dev)
+		return 0;
+
+	if (!dev_is_pci(dev))
+		return 0;
+
+	pdev = to_pci_dev(dev);
+
+	if (pdev->vendor != PCI_VENDOR_ID_INTEL)
+		return 0;
+
+	if (pdev->class != (PCI_CLASS_DISPLAY_VGA << 8) &&
+	    pdev->class != (PCI_CLASS_DISPLAY_OTHER << 8))
+		return 0;
+
+	if (subcomponent != INTEL_COMPONENT_LATE_BIND)
+		return 0;
+
+	base = base->parent;
+	if (!base) /* mei device */
+		return 0;
+
+	base = base->parent; /* pci device */
+
+	return !!base && dev == base;
+}
+
+static int mei_late_bind_probe(struct mei_cl_device *cldev,
+			       const struct mei_cl_device_id *id)
+{
+	struct component_match *master_match = NULL;
+	int ret;
+
+	component_match_add_typed(&cldev->dev, &master_match,
+				  mei_late_bind_component_match, &cldev->dev);
+	if (IS_ERR_OR_NULL(master_match))
+		return -ENOMEM;
+
+	ret = component_master_add_with_match(&cldev->dev,
+					      &mei_component_master_ops,
+					      master_match);
+	if (ret < 0)
+		dev_err(&cldev->dev, "Master comp add failed %d\n", ret);
+
+	return ret;
+}
+
+static void mei_late_bind_remove(struct mei_cl_device *cldev)
+{
+	component_master_del(&cldev->dev, &mei_component_master_ops);
+}
+
+#define MEI_GUID_MKHI UUID_LE(0xe2c2afa2, 0x3817, 0x4d19, \
+			      0x9d, 0x95, 0x6, 0xb1, 0x6b, 0x58, 0x8a, 0x5d)
+
+static struct mei_cl_device_id mei_late_bind_tbl[] = {
+	{ .uuid = MEI_GUID_MKHI, .version = MEI_CL_VERSION_ANY },
+	{ }
+};
+MODULE_DEVICE_TABLE(mei, mei_late_bind_tbl);
+
+static struct mei_cl_driver mei_late_bind_driver = {
+	.id_table = mei_late_bind_tbl,
+	.name = KBUILD_MODNAME,
+	.probe = mei_late_bind_probe,
+	.remove	= mei_late_bind_remove,
+};
+
+module_mei_cl_driver(mei_late_bind_driver);
+
+MODULE_AUTHOR("Intel Corporation");
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("MEI Late Binding");
diff --git a/include/drm/intel/i915_component.h b/include/drm/intel/i915_component.h
index 4ea3b17aa143..456849a97d75 100644
--- a/include/drm/intel/i915_component.h
+++ b/include/drm/intel/i915_component.h
@@ -31,6 +31,7 @@ enum i915_component_type {
 	I915_COMPONENT_HDCP,
 	I915_COMPONENT_PXP,
 	I915_COMPONENT_GSC_PROXY,
+	INTEL_COMPONENT_LATE_BIND,
 };
 
 /* MAX_PORT is the number of port
diff --git a/include/drm/intel/late_bind_mei_interface.h b/include/drm/intel/late_bind_mei_interface.h
new file mode 100644
index 000000000000..ec58ef1ab4e8
--- /dev/null
+++ b/include/drm/intel/late_bind_mei_interface.h
@@ -0,0 +1,64 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright (c) 2025 Intel Corporation
+ */
+
+#ifndef _LATE_BIND_MEI_INTERFACE_H_
+#define _LATE_BIND_MEI_INTERFACE_H_
+
+#include <linux/types.h>
+
+struct device;
+struct module;
+
+/**
+ * Late Binding flags
+ * Persistent across warm reset
+ */
+#define CSC_LATE_BINDING_FLAGS_IS_PERSISTENT	BIT(0)
+
+/**
+ * xe_late_bind_fw_type - enum to determine late binding fw type
+ */
+enum late_bind_type {
+	CSC_LATE_BINDING_TYPE_FAN_CONTROL = 1,
+};
+
+/**
+ * Late Binding payload status
+ */
+enum csc_late_binding_status {
+	CSC_LATE_BINDING_STATUS_SUCCESS           = 0,
+	CSC_LATE_BINDING_STATUS_4ID_MISMATCH      = 1,
+	CSC_LATE_BINDING_STATUS_ARB_FAILURE       = 2,
+	CSC_LATE_BINDING_STATUS_GENERAL_ERROR     = 3,
+	CSC_LATE_BINDING_STATUS_INVALID_PARAMS    = 4,
+	CSC_LATE_BINDING_STATUS_INVALID_SIGNATURE = 5,
+	CSC_LATE_BINDING_STATUS_INVALID_PAYLOAD   = 6,
+	CSC_LATE_BINDING_STATUS_TIMEOUT           = 7,
+};
+
+/**
+ * struct late_bind_component_ops - ops for Late Binding services.
+ * @owner: Module providing the ops
+ * @push_config: Sends a config to FW.
+ */
+struct late_bind_component_ops {
+	struct module *owner;
+
+	/**
+	 * @push_config: Sends a config to FW.
+	 * @dev: device struct corresponding to the mei device
+	 * @type: payload type
+	 * @flags: payload flags
+	 * @payload: payload buffer
+	 * @payload_size: payload buffer size
+	 *
+	 * Return: 0 success, negative errno value on transport failure,
+	 *         positive status returned by FW
+	 */
+	int (*push_config)(struct device *dev, u32 type, u32 flags,
+			   const void *payload, size_t payload_size);
+};
+
+#endif /* _LATE_BIND_MEI_INTERFACE_H_ */
-- 
2.34.1

[PATCH v5 03/10] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw

[Badal Nilawar]

Introducing xe_late_bind_fw to enable firmware loading for the devices,
such as the fan controller, during the driver probe. Typically,
firmware for such devices are part of IFWI flash image but can be
replaced at probe after OEM tuning.
This patch binds mei late binding component to enable firmware loading.

v2:
 - Add devm_add_action_or_reset to remove the component (Daniele)
 - Add INTEL_MEI_GSC check in xe_late_bind_init() (Daniele)
v3:
 - Fail driver probe if late bind initialization fails,
   add has_late_bind flag (Daniele)
v4:
 - %S/I915_COMPONENT_LATE_BIND/INTEL_COMPONENT_LATE_BIND/

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/Makefile                |  1 +
 drivers/gpu/drm/xe/xe_device.c             |  5 ++
 drivers/gpu/drm/xe/xe_device_types.h       |  6 ++
 drivers/gpu/drm/xe/xe_late_bind_fw.c       | 83 ++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_late_bind_fw.h       | 15 ++++
 drivers/gpu/drm/xe/xe_late_bind_fw_types.h | 35 +++++++++
 drivers/gpu/drm/xe/xe_pci.c                |  3 +
 7 files changed, 148 insertions(+)
 create mode 100644 drivers/gpu/drm/xe/xe_late_bind_fw.c
 create mode 100644 drivers/gpu/drm/xe/xe_late_bind_fw.h
 create mode 100644 drivers/gpu/drm/xe/xe_late_bind_fw_types.h

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 7c039caefd00..521547d78fd2 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -76,6 +76,7 @@ xe-y += xe_bb.o \
 	xe_hw_fence.o \
 	xe_irq.o \
 	xe_lrc.o \
+	xe_late_bind_fw.o \
 	xe_migrate.o \
 	xe_mmio.o \
 	xe_mocs.o \
diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 0b73cb72bad1..cb595bae5f55 100644
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -44,6 +44,7 @@
 #include "xe_hw_engine_group.h"
 #include "xe_hwmon.h"
 #include "xe_irq.h"
+#include "xe_late_bind_fw.h"
 #include "xe_mmio.h"
 #include "xe_module.h"
 #include "xe_nvm.h"
@@ -866,6 +867,10 @@ int xe_device_probe(struct xe_device *xe)
 	if (err)
 		return err;
 
+	err = xe_late_bind_init(&xe->late_bind);
+	if (err && err != -ENODEV)
+		return err;
+
 	err = xe_oa_init(xe);
 	if (err)
 		return err;
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 7e4f6d846af6..4e36dc37026f 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -16,6 +16,7 @@
 #include "xe_devcoredump_types.h"
 #include "xe_heci_gsc.h"
 #include "xe_lmtt_types.h"
+#include "xe_late_bind_fw_types.h"
 #include "xe_memirq_types.h"
 #include "xe_oa_types.h"
 #include "xe_platform_types.h"
@@ -323,6 +324,8 @@ struct xe_device {
 		u8 has_heci_cscfi:1;
 		/** @info.has_heci_gscfi: device has heci gscfi */
 		u8 has_heci_gscfi:1;
+		/** @info.has_late_bind: Device has firmware late binding support */
+		u8 has_late_bind:1;
 		/** @info.has_llc: Device has a shared CPU+GPU last level cache */
 		u8 has_llc:1;
 		/** @info.has_mbx_power_limits: Device has support to manage power limits using
@@ -555,6 +558,9 @@ struct xe_device {
 	/** @nvm: discrete graphics non-volatile memory */
 	struct intel_dg_nvm_dev *nvm;
 
+	/** @late_bind: xe mei late bind interface */
+	struct xe_late_bind late_bind;
+
 	/** @oa: oa observation subsystem */
 	struct xe_oa oa;
 
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
new file mode 100644
index 000000000000..22e79f0dbbdf
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
@@ -0,0 +1,83 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+#include <linux/component.h>
+#include <linux/delay.h>
+
+#include <drm/drm_managed.h>
+#include <drm/intel/i915_component.h>
+#include <drm/intel/late_bind_mei_interface.h>
+#include <drm/drm_print.h>
+
+#include "xe_device.h"
+#include "xe_late_bind_fw.h"
+
+static struct xe_device *
+late_bind_to_xe(struct xe_late_bind *late_bind)
+{
+	return container_of(late_bind, struct xe_device, late_bind);
+}
+
+static int xe_late_bind_component_bind(struct device *xe_kdev,
+				       struct device *mei_kdev, void *data)
+{
+	struct xe_device *xe = kdev_to_xe_device(xe_kdev);
+	struct xe_late_bind *late_bind = &xe->late_bind;
+
+	late_bind->component.ops = data;
+	late_bind->component.mei_dev = mei_kdev;
+
+	return 0;
+}
+
+static void xe_late_bind_component_unbind(struct device *xe_kdev,
+					  struct device *mei_kdev, void *data)
+{
+	struct xe_device *xe = kdev_to_xe_device(xe_kdev);
+	struct xe_late_bind *late_bind = &xe->late_bind;
+
+	late_bind->component.ops = NULL;
+}
+
+static const struct component_ops xe_late_bind_component_ops = {
+	.bind   = xe_late_bind_component_bind,
+	.unbind = xe_late_bind_component_unbind,
+};
+
+static void xe_late_bind_remove(void *arg)
+{
+	struct xe_late_bind *late_bind = arg;
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+
+	component_del(xe->drm.dev, &xe_late_bind_component_ops);
+}
+
+/**
+ * xe_late_bind_init() - add xe mei late binding component
+ *
+ * Return: 0 if the initialization was successful, a negative errno otherwise.
+ */
+int xe_late_bind_init(struct xe_late_bind *late_bind)
+{
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+	int err;
+
+	if (!xe->info.has_late_bind)
+		return 0;
+
+	if (!IS_ENABLED(CONFIG_INTEL_MEI_LATE_BIND) || !IS_ENABLED(CONFIG_INTEL_MEI_GSC)) {
+		drm_info(&xe->drm, "Can't init xe mei late bind missing mei component\n");
+		return -ENODEV;
+	}
+
+	err = component_add_typed(xe->drm.dev, &xe_late_bind_component_ops,
+				  INTEL_COMPONENT_LATE_BIND);
+	if (err < 0) {
+		drm_info(&xe->drm, "Failed to add mei late bind component (%pe)\n", ERR_PTR(err));
+		return err;
+	}
+
+	return devm_add_action_or_reset(xe->drm.dev, xe_late_bind_remove, late_bind);
+}
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.h b/drivers/gpu/drm/xe/xe_late_bind_fw.h
new file mode 100644
index 000000000000..4c73571c3e62
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+#ifndef _XE_LATE_BIND_FW_H_
+#define _XE_LATE_BIND_FW_H_
+
+#include <linux/types.h>
+
+struct xe_late_bind;
+
+int xe_late_bind_init(struct xe_late_bind *late_bind);
+
+#endif
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
new file mode 100644
index 000000000000..9806d17291ad
--- /dev/null
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+#ifndef _XE_LATE_BIND_TYPES_H_
+#define _XE_LATE_BIND_TYPES_H_
+
+#include <linux/iosys-map.h>
+#include <linux/mutex.h>
+#include <linux/types.h>
+
+/**
+ * struct xe_late_bind_component - Late Binding services component
+ * @mei_dev: device that provide Late Binding service.
+ * @ops: Ops implemented by Late Binding driver, used by Xe driver.
+ *
+ * Communication between Xe and MEI drivers for Late Binding services
+ */
+struct xe_late_bind_component {
+	/** @late_bind_component.mei_dev: mei device */
+	struct device *mei_dev;
+	/** @late_bind_component.ops: late binding ops */
+	const struct late_bind_component_ops *ops;
+};
+
+/**
+ * struct xe_late_bind
+ */
+struct xe_late_bind {
+	/** @late_bind.component: struct for communication with mei component */
+	struct xe_late_bind_component component;
+};
+
+#endif
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 08e21d4099e0..e5018d3ae74f 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -66,6 +66,7 @@ struct xe_device_desc {
 	u8 has_gsc_nvm:1;
 	u8 has_heci_gscfi:1;
 	u8 has_heci_cscfi:1;
+	u8 has_late_bind:1;
 	u8 has_llc:1;
 	u8 has_mbx_power_limits:1;
 	u8 has_pxp:1;
@@ -355,6 +356,7 @@ static const struct xe_device_desc bmg_desc = {
 	.has_mbx_power_limits = true,
 	.has_gsc_nvm = 1,
 	.has_heci_cscfi = 1,
+	.has_late_bind = true,
 	.needs_scratch = true,
 };
 
@@ -600,6 +602,7 @@ static int xe_info_init_early(struct xe_device *xe,
 	xe->info.has_gsc_nvm = desc->has_gsc_nvm;
 	xe->info.has_heci_gscfi = desc->has_heci_gscfi;
 	xe->info.has_heci_cscfi = desc->has_heci_cscfi;
+	xe->info.has_late_bind = desc->has_late_bind;
 	xe->info.has_llc = desc->has_llc;
 	xe->info.has_pxp = desc->has_pxp;
 	xe->info.has_sriov = desc->has_sriov;
-- 
2.34.1

[PATCH v5 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

[Badal Nilawar]

Search for late binding firmware binaries and populate the meta data of
firmware structures.

v2 (Daniele):
 - drm_err if firmware size is more than max pay load size
 - s/request_firmware/firmware_request_nowarn/ as firmware will
   not be available for all possible cards
v3 (Daniele):
 - init firmware from within xe_late_bind_init, propagate error
 - switch late_bind_fw to array to handle multiple firmware types
v4 (Daniele):
 - Alloc payload dynamically, fix nits

Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/xe_late_bind_fw.c       | 100 ++++++++++++++++++++-
 drivers/gpu/drm/xe/xe_late_bind_fw_types.h |  30 +++++++
 2 files changed, 129 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
index 22e79f0dbbdf..ca2370af3c27 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
@@ -5,6 +5,7 @@
 
 #include <linux/component.h>
 #include <linux/delay.h>
+#include <linux/firmware.h>
 
 #include <drm/drm_managed.h>
 #include <drm/intel/i915_component.h>
@@ -13,6 +14,16 @@
 
 #include "xe_device.h"
 #include "xe_late_bind_fw.h"
+#include "xe_pcode.h"
+#include "xe_pcode_api.h"
+
+static const u32 fw_id_to_type[] = {
+		[XE_LB_FW_FAN_CONTROL] = CSC_LATE_BINDING_TYPE_FAN_CONTROL,
+	};
+
+static const char * const fw_id_to_name[] = {
+		[XE_LB_FW_FAN_CONTROL] = "fan_control",
+	};
 
 static struct xe_device *
 late_bind_to_xe(struct xe_late_bind *late_bind)
@@ -20,6 +31,89 @@ late_bind_to_xe(struct xe_late_bind *late_bind)
 	return container_of(late_bind, struct xe_device, late_bind);
 }
 
+static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
+{
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+	struct xe_tile *root_tile = xe_device_get_root_tile(xe);
+	u32 uval;
+
+	if (!xe_pcode_read(root_tile,
+			   PCODE_MBOX(FAN_SPEED_CONTROL, FSC_READ_NUM_FANS, 0), &uval, NULL))
+		return uval;
+	else
+		return 0;
+}
+
+static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id)
+{
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
+	struct xe_late_bind_fw *lb_fw;
+	const struct firmware *fw;
+	u32 num_fans;
+	int ret;
+
+	if (fw_id >= XE_LB_FW_MAX_ID)
+		return -EINVAL;
+
+	lb_fw = &late_bind->late_bind_fw[fw_id];
+
+	lb_fw->id = fw_id;
+	lb_fw->type = fw_id_to_type[lb_fw->id];
+	lb_fw->flags &= ~CSC_LATE_BINDING_FLAGS_IS_PERSISTENT;
+
+	if (lb_fw->type == CSC_LATE_BINDING_TYPE_FAN_CONTROL) {
+		num_fans = xe_late_bind_fw_num_fans(late_bind);
+		drm_dbg(&xe->drm, "Number of Fans: %d\n", num_fans);
+		if (!num_fans)
+			return 0;
+	}
+
+	snprintf(lb_fw->blob_path, sizeof(lb_fw->blob_path), "xe/%s_8086_%04x_%04x_%04x.bin",
+		 fw_id_to_name[lb_fw->id], pdev->device,
+		 pdev->subsystem_vendor, pdev->subsystem_device);
+
+	drm_dbg(&xe->drm, "Request late binding firmware %s\n", lb_fw->blob_path);
+	ret = firmware_request_nowarn(&fw, lb_fw->blob_path, xe->drm.dev);
+	if (ret) {
+		drm_dbg(&xe->drm, "%s late binding fw not available for current device",
+			fw_id_to_name[lb_fw->id]);
+		return 0;
+	}
+
+	if (fw->size > MAX_PAYLOAD_SIZE) {
+		drm_err(&xe->drm, "Firmware %s size %zu is larger than max pay load size %u\n",
+			lb_fw->blob_path, fw->size, MAX_PAYLOAD_SIZE);
+		release_firmware(fw);
+		return -ENODATA;
+	}
+
+	lb_fw->payload_size = fw->size;
+	lb_fw->payload = drmm_kzalloc(&xe->drm, lb_fw->payload_size, GFP_KERNEL);
+	if (!lb_fw->payload) {
+		release_firmware(fw);
+		return -ENOMEM;
+	}
+
+	memcpy((void *)lb_fw->payload, fw->data, lb_fw->payload_size);
+	release_firmware(fw);
+
+	return 0;
+}
+
+static int xe_late_bind_fw_init(struct xe_late_bind *late_bind)
+{
+	int ret;
+	int fw_id;
+
+	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
+		ret = __xe_late_bind_fw_init(late_bind, fw_id);
+		if (ret)
+			return ret;
+	}
+	return 0;
+}
+
 static int xe_late_bind_component_bind(struct device *xe_kdev,
 				       struct device *mei_kdev, void *data)
 {
@@ -79,5 +173,9 @@ int xe_late_bind_init(struct xe_late_bind *late_bind)
 		return err;
 	}
 
-	return devm_add_action_or_reset(xe->drm.dev, xe_late_bind_remove, late_bind);
+	err = devm_add_action_or_reset(xe->drm.dev, xe_late_bind_remove, late_bind);
+	if (err)
+		return err;
+
+	return xe_late_bind_fw_init(late_bind);
 }
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
index 9806d17291ad..7d5dcb28b784 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
@@ -10,6 +10,34 @@
 #include <linux/mutex.h>
 #include <linux/types.h>
 
+#define MAX_PAYLOAD_SIZE SZ_4K
+
+/**
+ * xe_late_bind_fw_id - enum to determine late binding fw index
+ */
+enum xe_late_bind_fw_id {
+	XE_LB_FW_FAN_CONTROL = 0,
+	XE_LB_FW_MAX_ID
+};
+
+/**
+ * struct xe_late_bind_fw
+ */
+struct xe_late_bind_fw {
+	/** @late_bind_fw.id: firmware index */
+	u32 id;
+	/** @late_bind_fw.blob_path: firmware binary path */
+	char blob_path[PATH_MAX];
+	/** @late_bind_fw.type: firmware type */
+	u32  type;
+	/** @late_bind_fw.flags: firmware flags */
+	u32  flags;
+	/** @late_bind_fw.payload: to store the late binding blob */
+	const u8  *payload;
+	/** @late_bind_fw.payload_size: late binding blob payload_size */
+	size_t payload_size;
+};
+
 /**
  * struct xe_late_bind_component - Late Binding services component
  * @mei_dev: device that provide Late Binding service.
@@ -30,6 +58,8 @@ struct xe_late_bind_component {
 struct xe_late_bind {
 	/** @late_bind.component: struct for communication with mei component */
 	struct xe_late_bind_component component;
+	/** @late_bind.late_bind_fw: late binding firmware array */
+	struct xe_late_bind_fw late_bind_fw[XE_LB_FW_MAX_ID];
 };
 
 #endif
-- 
2.34.1

[PATCH v5 05/10] drm/xe/xe_late_bind_fw: Load late binding firmware

[Badal Nilawar]

Load late binding firmware

v2:
 - s/EAGAIN/EBUSY/
 - Flush worker in suspend and driver unload (Daniele)
v3:
 - Use retry interval of 6s, in steps of 200ms, to allow
   other OS components release MEI CL handle (Sasha)
v4:
 - return -ENODEV if component not added (Daniele)
 - parse and print status returned by csc
v5:
 - Use payload to check firmware valid (Daniele)
 - Obtain the RPM reference before scheduling the worker to
   ensure the device remains awake until the worker completes
   firmware loading (Rodrigo)

Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/xe_late_bind_fw.c       | 148 ++++++++++++++++++++-
 drivers/gpu/drm/xe/xe_late_bind_fw.h       |   1 +
 drivers/gpu/drm/xe/xe_late_bind_fw_types.h |   7 +
 3 files changed, 155 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
index ca2370af3c27..56166816a535 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
@@ -16,6 +16,20 @@
 #include "xe_late_bind_fw.h"
 #include "xe_pcode.h"
 #include "xe_pcode_api.h"
+#include "xe_pm.h"
+
+/*
+ * The component should load quite quickly in most cases, but it could take
+ * a bit. Using a very big timeout just to cover the worst case scenario
+ */
+#define LB_INIT_TIMEOUT_MS 20000
+
+/*
+ * Retry interval set to 6 seconds, in steps of 200 ms, to allow time for
+ * other OS components to release the MEI CL handle
+ */
+#define LB_FW_LOAD_RETRY_MAXCOUNT 30
+#define LB_FW_LOAD_RETRY_PAUSE_MS 200
 
 static const u32 fw_id_to_type[] = {
 		[XE_LB_FW_FAN_CONTROL] = CSC_LATE_BINDING_TYPE_FAN_CONTROL,
@@ -31,6 +45,30 @@ late_bind_to_xe(struct xe_late_bind *late_bind)
 	return container_of(late_bind, struct xe_device, late_bind);
 }
 
+static const char *xe_late_bind_parse_status(uint32_t status)
+{
+	switch (status) {
+	case CSC_LATE_BINDING_STATUS_SUCCESS:
+		return "success";
+	case CSC_LATE_BINDING_STATUS_4ID_MISMATCH:
+		return "4Id Mismatch";
+	case CSC_LATE_BINDING_STATUS_ARB_FAILURE:
+		return "ARB Failure";
+	case CSC_LATE_BINDING_STATUS_GENERAL_ERROR:
+		return "General Error";
+	case CSC_LATE_BINDING_STATUS_INVALID_PARAMS:
+		return "Invalid Params";
+	case CSC_LATE_BINDING_STATUS_INVALID_SIGNATURE:
+		return "Invalid Signature";
+	case CSC_LATE_BINDING_STATUS_INVALID_PAYLOAD:
+		return "Invalid Payload";
+	case CSC_LATE_BINDING_STATUS_TIMEOUT:
+		return "Timeout";
+	default:
+		return "Unknown error";
+	}
+}
+
 static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
 {
 	struct xe_device *xe = late_bind_to_xe(late_bind);
@@ -44,6 +82,92 @@ static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
 		return 0;
 }
 
+static void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
+{
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+	struct xe_late_bind_fw *lbfw;
+	int fw_id;
+
+	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
+		lbfw = &late_bind->late_bind_fw[fw_id];
+		if (lbfw->payload && late_bind->wq) {
+			drm_dbg(&xe->drm, "Flush work: load %s firmware\n",
+				fw_id_to_name[lbfw->id]);
+			flush_work(&lbfw->work);
+		}
+	}
+}
+
+static void xe_late_bind_work(struct work_struct *work)
+{
+	struct xe_late_bind_fw *lbfw = container_of(work, struct xe_late_bind_fw, work);
+	struct xe_late_bind *late_bind = container_of(lbfw, struct xe_late_bind,
+						      late_bind_fw[lbfw->id]);
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+	int retry = LB_FW_LOAD_RETRY_MAXCOUNT;
+	int ret;
+	int slept;
+
+	xe_device_assert_mem_access(xe);
+
+	/* we can queue this before the component is bound */
+	for (slept = 0; slept < LB_INIT_TIMEOUT_MS; slept += 100) {
+		if (late_bind->component.ops)
+			break;
+		msleep(100);
+	}
+
+	if (!late_bind->component.ops) {
+		drm_err(&xe->drm, "Late bind component not bound\n");
+		goto out;
+	}
+
+	drm_dbg(&xe->drm, "Load %s firmware\n", fw_id_to_name[lbfw->id]);
+
+	do {
+		ret = late_bind->component.ops->push_config(late_bind->component.mei_dev,
+							    lbfw->type, lbfw->flags,
+							    lbfw->payload, lbfw->payload_size);
+		if (!ret)
+			break;
+		msleep(LB_FW_LOAD_RETRY_PAUSE_MS);
+	} while (--retry && ret == -EBUSY);
+
+	if (!ret) {
+		drm_dbg(&xe->drm, "Load %s firmware successful\n",
+			fw_id_to_name[lbfw->id]);
+		goto out;
+	}
+
+	if (ret > 0)
+		drm_err(&xe->drm, "Load %s firmware failed with err %d, %s\n",
+			fw_id_to_name[lbfw->id], ret, xe_late_bind_parse_status(ret));
+	else
+		drm_err(&xe->drm, "Load %s firmware failed with err %d",
+			fw_id_to_name[lbfw->id], ret);
+out:
+	xe_pm_runtime_put(xe);
+}
+
+int xe_late_bind_fw_load(struct xe_late_bind *late_bind)
+{
+	struct xe_device *xe = late_bind_to_xe(late_bind);
+	struct xe_late_bind_fw *lbfw;
+	int fw_id;
+
+	if (!late_bind->component_added)
+		return -ENODEV;
+
+	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
+		lbfw = &late_bind->late_bind_fw[fw_id];
+		if (lbfw->payload) {
+			xe_pm_runtime_get_noresume(xe);
+			queue_work(late_bind->wq, &lbfw->work);
+		}
+	}
+	return 0;
+}
+
 static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id)
 {
 	struct xe_device *xe = late_bind_to_xe(late_bind);
@@ -97,6 +221,7 @@ static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id)
 
 	memcpy((void *)lb_fw->payload, fw->data, lb_fw->payload_size);
 	release_firmware(fw);
+	INIT_WORK(&lb_fw->work, xe_late_bind_work);
 
 	return 0;
 }
@@ -106,11 +231,16 @@ static int xe_late_bind_fw_init(struct xe_late_bind *late_bind)
 	int ret;
 	int fw_id;
 
+	late_bind->wq = alloc_ordered_workqueue("late-bind-ordered-wq", 0);
+	if (!late_bind->wq)
+		return -ENOMEM;
+
 	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
 		ret = __xe_late_bind_fw_init(late_bind, fw_id);
 		if (ret)
 			return ret;
 	}
+
 	return 0;
 }
 
@@ -132,6 +262,8 @@ static void xe_late_bind_component_unbind(struct device *xe_kdev,
 	struct xe_device *xe = kdev_to_xe_device(xe_kdev);
 	struct xe_late_bind *late_bind = &xe->late_bind;
 
+	xe_late_bind_wait_for_worker_completion(late_bind);
+
 	late_bind->component.ops = NULL;
 }
 
@@ -145,7 +277,15 @@ static void xe_late_bind_remove(void *arg)
 	struct xe_late_bind *late_bind = arg;
 	struct xe_device *xe = late_bind_to_xe(late_bind);
 
+	xe_late_bind_wait_for_worker_completion(late_bind);
+
+	late_bind->component_added = false;
+
 	component_del(xe->drm.dev, &xe_late_bind_component_ops);
+	if (late_bind->wq) {
+		destroy_workqueue(late_bind->wq);
+		late_bind->wq = NULL;
+	}
 }
 
 /**
@@ -173,9 +313,15 @@ int xe_late_bind_init(struct xe_late_bind *late_bind)
 		return err;
 	}
 
+	late_bind->component_added = true;
+
 	err = devm_add_action_or_reset(xe->drm.dev, xe_late_bind_remove, late_bind);
 	if (err)
 		return err;
 
-	return xe_late_bind_fw_init(late_bind);
+	err = xe_late_bind_fw_init(late_bind);
+	if (err)
+		return err;
+
+	return xe_late_bind_fw_load(late_bind);
 }
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.h b/drivers/gpu/drm/xe/xe_late_bind_fw.h
index 4c73571c3e62..28d56ed2bfdc 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.h
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.h
@@ -11,5 +11,6 @@
 struct xe_late_bind;
 
 int xe_late_bind_init(struct xe_late_bind *late_bind);
+int xe_late_bind_fw_load(struct xe_late_bind *late_bind);
 
 #endif
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
index 7d5dcb28b784..0ed98f236f2a 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
@@ -9,6 +9,7 @@
 #include <linux/iosys-map.h>
 #include <linux/mutex.h>
 #include <linux/types.h>
+#include <linux/workqueue.h>
 
 #define MAX_PAYLOAD_SIZE SZ_4K
 
@@ -36,6 +37,8 @@ struct xe_late_bind_fw {
 	const u8  *payload;
 	/** @late_bind_fw.payload_size: late binding blob payload_size */
 	size_t payload_size;
+	/** @late_bind_fw.work: worker to upload latebind blob */
+	struct work_struct work;
 };
 
 /**
@@ -60,6 +63,10 @@ struct xe_late_bind {
 	struct xe_late_bind_component component;
 	/** @late_bind.late_bind_fw: late binding firmware array */
 	struct xe_late_bind_fw late_bind_fw[XE_LB_FW_MAX_ID];
+	/** @late_bind.wq: workqueue to submit request to download late bind blob */
+	struct workqueue_struct *wq;
+	/** @late_bind.component_added: whether the component has been added */
+	bool component_added;
 };
 
 #endif
-- 
2.34.1

[PATCH v5 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

[Badal Nilawar]

Reload late binding fw during runtime resume.

Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
v5: Flush worker in rpm suspend is not needed any more as
    xe_late_bind_fw_load gets the rpm ref before queuing worker
    to ensure worker completes lb fw loading.
---
 drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +-
 drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 +
 drivers/gpu/drm/xe/xe_pm.c           | 4 ++++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
index 56166816a535..3fb84d2f0a76 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
@@ -82,7 +82,7 @@ static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
 		return 0;
 }
 
-static void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
+void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
 {
 	struct xe_device *xe = late_bind_to_xe(late_bind);
 	struct xe_late_bind_fw *lbfw;
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.h b/drivers/gpu/drm/xe/xe_late_bind_fw.h
index 28d56ed2bfdc..07e437390539 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.h
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.h
@@ -12,5 +12,6 @@ struct xe_late_bind;
 
 int xe_late_bind_init(struct xe_late_bind *late_bind);
 int xe_late_bind_fw_load(struct xe_late_bind *late_bind);
+void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind);
 
 #endif
diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index ff749edc005b..734fe259600e 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -20,6 +20,7 @@
 #include "xe_gt.h"
 #include "xe_guc.h"
 #include "xe_irq.h"
+#include "xe_late_bind_fw.h"
 #include "xe_pcode.h"
 #include "xe_pxp.h"
 #include "xe_trace.h"
@@ -550,6 +551,9 @@ int xe_pm_runtime_resume(struct xe_device *xe)
 
 	xe_pxp_pm_resume(xe->pxp);
 
+	if (xe->d3cold.allowed)
+		xe_late_bind_fw_load(&xe->late_bind);
+
 out:
 	xe_rpm_lockmap_release(xe);
 	xe_pm_write_callback_task(xe, NULL);
-- 
2.34.1

[PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

[Badal Nilawar]

Reload late binding fw during resume from system suspend

v2:
  - Unconditionally reload late binding fw (Rodrigo)
  - Flush worker during system suspend

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/xe_pm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index 734fe259600e..13afaf97d831 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -127,6 +127,8 @@ int xe_pm_suspend(struct xe_device *xe)
 	if (err)
 		goto err;
 
+	xe_late_bind_wait_for_worker_completion(&xe->late_bind);
+
 	for_each_gt(gt, xe, id)
 		xe_gt_suspend_prepare(gt);
 
@@ -205,6 +207,8 @@ int xe_pm_resume(struct xe_device *xe)
 
 	xe_pxp_pm_resume(xe->pxp);
 
+	xe_late_bind_fw_load(&xe->late_bind);
+
 	drm_dbg(&xe->drm, "Device resumed\n");
 	return 0;
 err:
-- 
2.34.1

[PATCH v5 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

[Badal Nilawar]

Introduce a debug filesystem node to disable late binding fw reload
during the system or runtime resume. This is intended for situations
where the late binding fw needs to be loaded from user mode,
perticularly for validation purpose.
Note that xe kmd doesn't participate in late binding flow from user
space. Binary loaded from the userspace will be lost upon entering to
D3 cold hence user space app need to handle this situation.

v2:
  - s/(uval == 1) ? true : false/!!uval/ (Daniele)
v3:
  - Refine the commit message (Daniele)

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c            | 41 ++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_late_bind_fw.c       |  3 ++
 drivers/gpu/drm/xe/xe_late_bind_fw_types.h |  2 ++
 3 files changed, 46 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index d83cd6ed3fa8..d1f6f556efa2 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -226,6 +226,44 @@ static const struct file_operations atomic_svm_timeslice_ms_fops = {
 	.write = atomic_svm_timeslice_ms_set,
 };
 
+static ssize_t disable_late_binding_show(struct file *f, char __user *ubuf,
+					 size_t size, loff_t *pos)
+{
+	struct xe_device *xe = file_inode(f)->i_private;
+	struct xe_late_bind *late_bind = &xe->late_bind;
+	char buf[32];
+	int len;
+
+	len = scnprintf(buf, sizeof(buf), "%d\n", late_bind->disable);
+
+	return simple_read_from_buffer(ubuf, size, pos, buf, len);
+}
+
+static ssize_t disable_late_binding_set(struct file *f, const char __user *ubuf,
+					size_t size, loff_t *pos)
+{
+	struct xe_device *xe = file_inode(f)->i_private;
+	struct xe_late_bind *late_bind = &xe->late_bind;
+	u32 uval;
+	ssize_t ret;
+
+	ret = kstrtouint_from_user(ubuf, size, sizeof(uval), &uval);
+	if (ret)
+		return ret;
+
+	if (uval > 1)
+		return -EINVAL;
+
+	late_bind->disable = !!uval;
+	return size;
+}
+
+static const struct file_operations disable_late_binding_fops = {
+	.owner = THIS_MODULE,
+	.read = disable_late_binding_show,
+	.write = disable_late_binding_set,
+};
+
 void xe_debugfs_register(struct xe_device *xe)
 {
 	struct ttm_device *bdev = &xe->ttm;
@@ -249,6 +287,9 @@ void xe_debugfs_register(struct xe_device *xe)
 	debugfs_create_file("atomic_svm_timeslice_ms", 0600, root, xe,
 			    &atomic_svm_timeslice_ms_fops);
 
+	debugfs_create_file("disable_late_binding", 0600, root, xe,
+			    &disable_late_binding_fops);
+
 	for (mem_type = XE_PL_VRAM0; mem_type <= XE_PL_VRAM1; ++mem_type) {
 		man = ttm_manager_type(bdev, mem_type);
 
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
index 3fb84d2f0a76..f6acf535bebc 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
@@ -158,6 +158,9 @@ int xe_late_bind_fw_load(struct xe_late_bind *late_bind)
 	if (!late_bind->component_added)
 		return -ENODEV;
 
+	if (late_bind->disable)
+		return 0;
+
 	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
 		lbfw = &late_bind->late_bind_fw[fw_id];
 		if (lbfw->payload) {
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
index 0ed98f236f2a..9a7fd07bf122 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
@@ -67,6 +67,8 @@ struct xe_late_bind {
 	struct workqueue_struct *wq;
 	/** @late_bind.component_added: whether the component has been added */
 	bool component_added;
+	/** @late_bind.disable to block late binding reload during pm resume flow*/
+	bool disable;
 };
 
 #endif
-- 
2.34.1

[PATCH v5 09/10] drm/xe/xe_late_bind_fw: Extract and print version info

[Badal Nilawar]

Extract and print version info of the late binding binary.

v2: Some refinements (Daniele)

Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
---
 drivers/gpu/drm/xe/xe_late_bind_fw.c       | 124 +++++++++++++++++++++
 drivers/gpu/drm/xe/xe_late_bind_fw_types.h |   3 +
 drivers/gpu/drm/xe/xe_uc_fw_abi.h          |  66 +++++++++++
 3 files changed, 193 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
index f6acf535bebc..9a2141cf7ecf 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
@@ -45,6 +45,121 @@ late_bind_to_xe(struct xe_late_bind *late_bind)
 	return container_of(late_bind, struct xe_device, late_bind);
 }
 
+static struct xe_device *
+late_bind_fw_to_xe(struct xe_late_bind_fw *lb_fw)
+{
+	return container_of(lb_fw, struct xe_device, late_bind.late_bind_fw[lb_fw->id]);
+}
+
+/* Refer to the "Late Bind based Firmware Layout" documentation entry for details */
+static int parse_cpd_header(struct xe_late_bind_fw *lb_fw,
+			    const void *data, size_t size, const char *manifest_entry)
+{
+	struct xe_device *xe = late_bind_fw_to_xe(lb_fw);
+	const struct gsc_cpd_header_v2 *header = data;
+	const struct gsc_manifest_header *manifest;
+	const struct gsc_cpd_entry *entry;
+	size_t min_size = sizeof(*header);
+	u32 offset;
+	int i;
+
+	/* manifest_entry is mandatory */
+	xe_assert(xe, manifest_entry);
+
+	if (size < min_size || header->header_marker != GSC_CPD_HEADER_MARKER)
+		return -ENOENT;
+
+	if (header->header_length < sizeof(struct gsc_cpd_header_v2)) {
+		drm_err(&xe->drm, "%s late binding fw: Invalid CPD header length %u!\n",
+			fw_id_to_name[lb_fw->id], header->header_length);
+		return -EINVAL;
+	}
+
+	min_size = header->header_length + sizeof(struct gsc_cpd_entry) * header->num_of_entries;
+	if (size < min_size) {
+		drm_err(&xe->drm, "%s late binding fw: too small! %zu < %zu\n",
+			fw_id_to_name[lb_fw->id], size, min_size);
+		return -ENODATA;
+	}
+
+	/* Look for the manifest first */
+	entry = (void *)header + header->header_length;
+	for (i = 0; i < header->num_of_entries; i++, entry++)
+		if (strcmp(entry->name, manifest_entry) == 0)
+			offset = entry->offset & GSC_CPD_ENTRY_OFFSET_MASK;
+
+	if (!offset) {
+		drm_err(&xe->drm, "%s late binding fw: Failed to find manifest_entry\n",
+			fw_id_to_name[lb_fw->id]);
+		return -ENODATA;
+	}
+
+	min_size = offset + sizeof(struct gsc_manifest_header);
+	if (size < min_size) {
+		drm_err(&xe->drm, "%s late binding fw: too small! %zu < %zu\n",
+			fw_id_to_name[lb_fw->id], size, min_size);
+		return -ENODATA;
+	}
+
+	manifest = data + offset;
+
+	lb_fw->version = manifest->fw_version;
+
+	return 0;
+}
+
+/* Refer to the "Late Bind based Firmware Layout" documentation entry for details */
+static int parse_lb_layout(struct xe_late_bind_fw *lb_fw,
+			   const void *data, size_t size, const char *fpt_entry)
+{
+	struct xe_device *xe = late_bind_fw_to_xe(lb_fw);
+	const struct csc_fpt_header *header = data;
+	const struct csc_fpt_entry *entry;
+	size_t min_size = sizeof(*header);
+	u32 offset;
+	int i;
+
+	/* fpt_entry is mandatory */
+	xe_assert(xe, fpt_entry);
+
+	if (size < min_size || header->header_marker != CSC_FPT_HEADER_MARKER)
+		return -ENOENT;
+
+	if (header->header_length < sizeof(struct csc_fpt_header)) {
+		drm_err(&xe->drm, "%s late binding fw: Invalid FPT header length %u!\n",
+			fw_id_to_name[lb_fw->id], header->header_length);
+		return -EINVAL;
+	}
+
+	min_size = header->header_length + sizeof(struct csc_fpt_entry) * header->num_of_entries;
+	if (size < min_size) {
+		drm_err(&xe->drm, "%s late binding fw: too small! %zu < %zu\n",
+			fw_id_to_name[lb_fw->id], size, min_size);
+		return -ENODATA;
+	}
+
+	/* Look for the cpd header first */
+	entry = (void *)header + header->header_length;
+	for (i = 0; i < header->num_of_entries; i++, entry++)
+		if (strcmp(entry->name, fpt_entry) == 0)
+			offset = entry->offset;
+
+	if (!offset) {
+		drm_err(&xe->drm, "%s late binding fw: Failed to find fpt_entry\n",
+			fw_id_to_name[lb_fw->id]);
+		return -ENODATA;
+	}
+
+	min_size = offset + sizeof(struct gsc_cpd_header_v2);
+	if (size < min_size) {
+		drm_err(&xe->drm, "%s late binding fw: too small! %zu < %zu\n",
+			fw_id_to_name[lb_fw->id], size, min_size);
+		return -ENODATA;
+	}
+
+	return parse_cpd_header(lb_fw, data + offset, size - offset, "LTES.man");
+}
+
 static const char *xe_late_bind_parse_status(uint32_t status)
 {
 	switch (status) {
@@ -215,6 +330,10 @@ static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id)
 		return -ENODATA;
 	}
 
+	ret = parse_lb_layout(lb_fw, fw->data, fw->size, "LTES");
+	if (ret)
+		return ret;
+
 	lb_fw->payload_size = fw->size;
 	lb_fw->payload = drmm_kzalloc(&xe->drm, lb_fw->payload_size, GFP_KERNEL);
 	if (!lb_fw->payload) {
@@ -222,6 +341,11 @@ static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id)
 		return -ENOMEM;
 	}
 
+	drm_info(&xe->drm, "Using %s firmware from %s version %u.%u.%u.%u\n",
+		 fw_id_to_name[lb_fw->id], lb_fw->blob_path,
+		 lb_fw->version.major, lb_fw->version.minor,
+		 lb_fw->version.hotfix, lb_fw->version.build);
+
 	memcpy((void *)lb_fw->payload, fw->data, lb_fw->payload_size);
 	release_firmware(fw);
 	INIT_WORK(&lb_fw->work, xe_late_bind_work);
diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
index 9a7fd07bf122..5cbaa1722d3f 100644
--- a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
+++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
@@ -10,6 +10,7 @@
 #include <linux/mutex.h>
 #include <linux/types.h>
 #include <linux/workqueue.h>
+#include "xe_uc_fw_abi.h"
 
 #define MAX_PAYLOAD_SIZE SZ_4K
 
@@ -39,6 +40,8 @@ struct xe_late_bind_fw {
 	size_t payload_size;
 	/** @late_bind_fw.work: worker to upload latebind blob */
 	struct work_struct work;
+	/** @late_bind_fw.version: late binding blob manifest version */
+	struct gsc_version version;
 };
 
 /**
diff --git a/drivers/gpu/drm/xe/xe_uc_fw_abi.h b/drivers/gpu/drm/xe/xe_uc_fw_abi.h
index 87ade41209d0..78782d105fa9 100644
--- a/drivers/gpu/drm/xe/xe_uc_fw_abi.h
+++ b/drivers/gpu/drm/xe/xe_uc_fw_abi.h
@@ -318,4 +318,70 @@ struct gsc_manifest_header {
 	u32 exponent_size; /* in dwords */
 } __packed;
 
+/**
+ * DOC: Late binding Firmware Layout
+ *
+ * The Late binding binary starts with FPT header, which contains locations
+ * of various partitions of the binary. Here we're interested in finding out
+ * manifest version. To the manifest version, we need to locate CPD header
+ * one of the entry in CPD header points to manifest header. Manifest header
+ * contains the version.
+ *
+ *      +================================================+
+ *      |  FPT Header                                    |
+ *      +================================================+
+ *      |  FPT entries[]                                 |
+ *      |      entry1                                    |
+ *      |      ...                                       |
+ *      |      entryX                                    |
+ *      |          "LTES"                                |
+ *      |          ...                                   |
+ *      |          offset  >-----------------------------|------o
+ *      +================================================+      |
+ *                                                              |
+ *      +================================================+      |
+ *      |  CPD Header                                    |<-----o
+ *      +================================================+
+ *      |  CPD entries[]                                 |
+ *      |      entry1                                    |
+ *      |      ...                                       |
+ *      |      entryX                                    |
+ *      |          "LTES.man"                            |
+ *      |           ...                                  |
+ *      |           offset  >----------------------------|------o
+ *      +================================================+      |
+ *                                                              |
+ *      +================================================+      |
+ *      |  Manifest Header                               |<-----o
+ *      |      ...                                       |
+ *      |      FW version                                |
+ *      |      ...                                       |
+ *      +================================================+
+ */
+
+/* FPT Headers */
+struct csc_fpt_header {
+	u32 header_marker;
+#define CSC_FPT_HEADER_MARKER 0x54504624
+	u32 num_of_entries;
+	u8 header_version;
+	u8 entry_version;
+	u8 header_length; /* in bytes */
+	u8 flags;
+	u16 ticks_to_add;
+	u16 tokens_to_add;
+	u32 uma_size;
+	u32 crc32;
+	struct gsc_version fitc_version;
+} __packed;
+
+struct csc_fpt_entry {
+	u8 name[4]; /* partition name */
+	u32 reserved1;
+	u32 offset; /* offset from beginning of CSE region */
+	u32 length; /* partition length in bytes */
+	u32 reserved2[3];
+	u32 partition_flags;
+} __packed;
+
 #endif
-- 
2.34.1

[PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

[Badal Nilawar]

Do not review

Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
---
 drivers/gpu/drm/xe/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index f66e6d39e319..ef3f4807b0b3 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -45,6 +45,7 @@ config DRM_XE
 	select WANT_DEV_COREDUMP
 	select AUXILIARY_BUS
 	select HMM_MIRROR
+	select INTEL_MEI_LATE_BIND
 	help
 	  Driver for Intel Xe2 series GPUs and later. Experimental support
 	  for Xe series is also available.
-- 
2.34.1

✗ CI.checkpatch: warning for Introducing firmware late binding

[Patchwork]

== Series Details ==

Series: Introducing firmware late binding
URL   : https://patchwork.freedesktop.org/series/151082/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
f8ff75ae1d2127635239b134695774ed4045d05b
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 4bb2cd773bfacbf5154f819b768c22790edc83f4
Author: Badal Nilawar <badal.nilawar@intel.com>
Date:   Wed Jul 2 22:22:16 2025 +0530

    drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI
    
    Do not review
    
    Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
+ /mt/dim checkpatch 94631e6b7f655b1922e3227970cd6180200694af drm-intel
57f3d238ff30 mei: bus: add mei_cldev_mtu interface
1dcf70da762a mei: late_bind: add late binding component driver
-:38: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 378 lines checked
5e1ef7275b36 drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw
-:91: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#91: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 202 lines checked
e22f9dfd345b drm/xe/xe_late_bind_fw: Initialize late binding firmware
48fcc1b142e8 drm/xe/xe_late_bind_fw: Load late binding firmware
61c0c7f13d9b drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume
14d2ffa762c4 drm/xe/xe_late_bind_fw: Reload late binding fw during system resume
4d5c84dc4322 drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding
75638e1ad31c drm/xe/xe_late_bind_fw: Extract and print version info
4bb2cd773bfa drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

✓ CI.KUnit: success for Introducing firmware late binding

[Patchwork]

== Series Details ==

Series: Introducing firmware late binding
URL   : https://patchwork.freedesktop.org/series/151082/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[18:39:12] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[18:39:17] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[18:39:51] Starting KUnit Kernel (1/1)...
[18:39:51] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[18:39:51] ================== guc_buf (11 subtests) ===================
[18:39:51] [PASSED] test_smallest
[18:39:51] [PASSED] test_largest
[18:39:51] [PASSED] test_granular
[18:39:51] [PASSED] test_unique
[18:39:51] [PASSED] test_overlap
[18:39:51] [PASSED] test_reusable
[18:39:51] [PASSED] test_too_big
[18:39:51] [PASSED] test_flush
[18:39:51] [PASSED] test_lookup
[18:39:51] [PASSED] test_data
[18:39:51] [PASSED] test_class
[18:39:51] ===================== [PASSED] guc_buf =====================
[18:39:51] =================== guc_dbm (7 subtests) ===================
[18:39:51] [PASSED] test_empty
[18:39:51] [PASSED] test_default
[18:39:51] ======================== test_size  ========================
[18:39:51] [PASSED] 4
[18:39:51] [PASSED] 8
[18:39:51] [PASSED] 32
[18:39:51] [PASSED] 256
[18:39:51] ==================== [PASSED] test_size ====================
[18:39:51] ======================= test_reuse  ========================
[18:39:51] [PASSED] 4
[18:39:51] [PASSED] 8
[18:39:51] [PASSED] 32
[18:39:51] [PASSED] 256
[18:39:51] =================== [PASSED] test_reuse ====================
[18:39:51] =================== test_range_overlap  ====================
[18:39:51] [PASSED] 4
[18:39:51] [PASSED] 8
[18:39:51] [PASSED] 32
[18:39:51] [PASSED] 256
[18:39:51] =============== [PASSED] test_range_overlap ================
[18:39:51] =================== test_range_compact  ====================
[18:39:51] [PASSED] 4
[18:39:51] [PASSED] 8
[18:39:51] [PASSED] 32
[18:39:51] [PASSED] 256
[18:39:51] =============== [PASSED] test_range_compact ================
[18:39:51] ==================== test_range_spare  =====================
[18:39:51] [PASSED] 4
[18:39:51] [PASSED] 8
[18:39:51] [PASSED] 32
[18:39:51] [PASSED] 256
[18:39:51] ================ [PASSED] test_range_spare =================
[18:39:51] ===================== [PASSED] guc_dbm =====================
[18:39:51] =================== guc_idm (6 subtests) ===================
[18:39:51] [PASSED] bad_init
[18:39:51] [PASSED] no_init
[18:39:51] [PASSED] init_fini
[18:39:51] [PASSED] check_used
[18:39:51] [PASSED] check_quota
[18:39:51] [PASSED] check_all
[18:39:51] ===================== [PASSED] guc_idm =====================
[18:39:51] ================== no_relay (3 subtests) ===================
[18:39:51] [PASSED] xe_drops_guc2pf_if_not_ready
[18:39:51] [PASSED] xe_drops_guc2vf_if_not_ready
[18:39:51] [PASSED] xe_rejects_send_if_not_ready
[18:39:51] ==================== [PASSED] no_relay =====================
[18:39:51] ================== pf_relay (14 subtests) ==================
[18:39:51] [PASSED] pf_rejects_guc2pf_too_short
[18:39:51] [PASSED] pf_rejects_guc2pf_too_long
[18:39:51] [PASSED] pf_rejects_guc2pf_no_payload
[18:39:51] [PASSED] pf_fails_no_payload
[18:39:51] [PASSED] pf_fails_bad_origin
[18:39:51] [PASSED] pf_fails_bad_type
[18:39:51] [PASSED] pf_txn_reports_error
[18:39:51] [PASSED] pf_txn_sends_pf2guc
[18:39:51] [PASSED] pf_sends_pf2guc
[18:39:51] [SKIPPED] pf_loopback_nop
[18:39:51] [SKIPPED] pf_loopback_echo
[18:39:51] [SKIPPED] pf_loopback_fail
[18:39:51] [SKIPPED] pf_loopback_busy
[18:39:51] [SKIPPED] pf_loopback_retry
[18:39:51] ==================== [PASSED] pf_relay =====================
[18:39:51] ================== vf_relay (3 subtests) ===================
[18:39:51] [PASSED] vf_rejects_guc2vf_too_short
[18:39:51] [PASSED] vf_rejects_guc2vf_too_long
[18:39:51] [PASSED] vf_rejects_guc2vf_no_payload
[18:39:51] ==================== [PASSED] vf_relay =====================
[18:39:51] ================= pf_service (11 subtests) =================
[18:39:51] [PASSED] pf_negotiate_any
[18:39:51] [PASSED] pf_negotiate_base_match
[18:39:51] [PASSED] pf_negotiate_base_newer
[18:39:51] [PASSED] pf_negotiate_base_next
[18:39:51] [SKIPPED] pf_negotiate_base_older
[18:39:51] [PASSED] pf_negotiate_base_prev
[18:39:51] [PASSED] pf_negotiate_latest_match
[18:39:51] [PASSED] pf_negotiate_latest_newer
[18:39:51] [PASSED] pf_negotiate_latest_next
[18:39:51] [SKIPPED] pf_negotiate_latest_older
[18:39:51] [SKIPPED] pf_negotiate_latest_prev
[18:39:51] =================== [PASSED] pf_service ====================
[18:39:51] ===================== lmtt (1 subtest) =====================
[18:39:51] ======================== test_ops  =========================
[18:39:51] [PASSED] 2-level
[18:39:51] [PASSED] multi-level
[18:39:51] ==================== [PASSED] test_ops =====================
[18:39:51] ====================== [PASSED] lmtt =======================
[18:39:51] =================== xe_mocs (2 subtests) ===================
[18:39:51] ================ xe_live_mocs_kernel_kunit  ================
[18:39:51] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[18:39:51] ================ xe_live_mocs_reset_kunit  =================
[18:39:51] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[18:39:51] ==================== [SKIPPED] xe_mocs =====================
[18:39:51] ================= xe_migrate (2 subtests) ==================
[18:39:51] ================= xe_migrate_sanity_kunit  =================
[18:39:51] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[18:39:51] ================== xe_validate_ccs_kunit  ==================
[18:39:51] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[18:39:51] =================== [SKIPPED] xe_migrate ===================
[18:39:51] ================== xe_dma_buf (1 subtest) ==================
[18:39:51] ==================== xe_dma_buf_kunit  =====================
[18:39:51] ================ [SKIPPED] xe_dma_buf_kunit ================
[18:39:51] =================== [SKIPPED] xe_dma_buf ===================
[18:39:51] ================= xe_bo_shrink (1 subtest) =================
[18:39:51] =================== xe_bo_shrink_kunit  ====================
[18:39:51] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[18:39:51] ================== [SKIPPED] xe_bo_shrink ==================
[18:39:51] ==================== xe_bo (2 subtests) ====================
[18:39:51] ================== xe_ccs_migrate_kunit  ===================
[18:39:51] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[18:39:51] ==================== xe_bo_evict_kunit  ====================
[18:39:51] =============== [SKIPPED] xe_bo_evict_kunit ================
[18:39:51] ===================== [SKIPPED] xe_bo ======================
[18:39:51] ==================== args (11 subtests) ====================
[18:39:51] [PASSED] count_args_test
[18:39:51] [PASSED] call_args_example
[18:39:51] [PASSED] call_args_test
[18:39:51] [PASSED] drop_first_arg_example
[18:39:51] [PASSED] drop_first_arg_test
[18:39:51] [PASSED] first_arg_example
[18:39:51] [PASSED] first_arg_test
[18:39:51] [PASSED] last_arg_example
[18:39:51] [PASSED] last_arg_test
[18:39:51] [PASSED] pick_arg_example
[18:39:51] [PASSED] sep_comma_example
[18:39:51] ====================== [PASSED] args =======================
[18:39:51] =================== xe_pci (2 subtests) ====================
[18:39:51] ==================== check_graphics_ip  ====================
[18:39:51] [PASSED] 12.70 Xe_LPG
[18:39:51] [PASSED] 12.71 Xe_LPG
[18:39:51] [PASSED] 12.74 Xe_LPG+
[18:39:51] [PASSED] 20.01 Xe2_HPG
[18:39:51] [PASSED] 20.02 Xe2_HPG
[18:39:51] [PASSED] 20.04 Xe2_LPG
[18:39:51] [PASSED] 30.00 Xe3_LPG
[18:39:51] [PASSED] 30.01 Xe3_LPG
[18:39:51] [PASSED] 30.03 Xe3_LPG
[18:39:51] ================ [PASSED] check_graphics_ip ================
[18:39:51] ===================== check_media_ip  ======================
[18:39:51] [PASSED] 13.00 Xe_LPM+
[18:39:51] [PASSED] 13.01 Xe2_HPM
[18:39:51] [PASSED] 20.00 Xe2_LPM
[18:39:51] [PASSED] 30.00 Xe3_LPM
[18:39:51] [PASSED] 30.02 Xe3_LPM
stty: 'standard input': Inappropriate ioctl for device
[18:39:51] ================= [PASSED] check_media_ip ==================
[18:39:51] ===================== [PASSED] xe_pci ======================
[18:39:51] =================== xe_rtp (2 subtests) ====================
[18:39:51] =============== xe_rtp_process_to_sr_tests  ================
[18:39:51] [PASSED] coalesce-same-reg
[18:39:51] [PASSED] no-match-no-add
[18:39:51] [PASSED] match-or
[18:39:51] [PASSED] match-or-xfail
[18:39:51] [PASSED] no-match-no-add-multiple-rules
[18:39:51] [PASSED] two-regs-two-entries
[18:39:51] [PASSED] clr-one-set-other
[18:39:51] [PASSED] set-field
[18:39:51] [PASSED] conflict-duplicate
[18:39:51] [PASSED] conflict-not-disjoint
[18:39:51] [PASSED] conflict-reg-type
[18:39:51] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[18:39:51] ================== xe_rtp_process_tests  ===================
[18:39:51] [PASSED] active1
[18:39:51] [PASSED] active2
[18:39:51] [PASSED] active-inactive
[18:39:51] [PASSED] inactive-active
[18:39:51] [PASSED] inactive-1st_or_active-inactive
[18:39:51] [PASSED] inactive-2nd_or_active-inactive
[18:39:51] [PASSED] inactive-last_or_active-inactive
[18:39:51] [PASSED] inactive-no_or_active-inactive
[18:39:51] ============== [PASSED] xe_rtp_process_tests ===============
[18:39:51] ===================== [PASSED] xe_rtp ======================
[18:39:51] ==================== xe_wa (1 subtest) =====================
[18:39:51] ======================== xe_wa_gt  =========================
[18:39:51] [PASSED] TIGERLAKE (B0)
[18:39:51] [PASSED] DG1 (A0)
[18:39:51] [PASSED] DG1 (B0)
[18:39:51] [PASSED] ALDERLAKE_S (A0)
[18:39:51] [PASSED] ALDERLAKE_S (B0)
[18:39:51] [PASSED] ALDERLAKE_S (C0)
[18:39:51] [PASSED] ALDERLAKE_S (D0)
[18:39:51] [PASSED] ALDERLAKE_P (A0)
[18:39:51] [PASSED] ALDERLAKE_P (B0)
[18:39:51] [PASSED] ALDERLAKE_P (C0)
[18:39:51] [PASSED] ALDERLAKE_S_RPLS (D0)
[18:39:51] [PASSED] ALDERLAKE_P_RPLU (E0)
[18:39:51] [PASSED] DG2_G10 (C0)
[18:39:51] [PASSED] DG2_G11 (B1)
[18:39:51] [PASSED] DG2_G12 (A1)
[18:39:51] [PASSED] METEORLAKE (g:A0, m:A0)
[18:39:51] [PASSED] METEORLAKE (g:A0, m:A0)
[18:39:51] [PASSED] METEORLAKE (g:A0, m:A0)
[18:39:51] [PASSED] LUNARLAKE (g:A0, m:A0)
[18:39:51] [PASSED] LUNARLAKE (g:B0, m:A0)
[18:39:51] [PASSED] BATTLEMAGE (g:A0, m:A1)
[18:39:51] ==================== [PASSED] xe_wa_gt =====================
[18:39:51] ====================== [PASSED] xe_wa ======================
[18:39:51] ============================================================
[18:39:51] Testing complete. Ran 145 tests: passed: 129, skipped: 16
[18:39:51] Elapsed time: 38.698s total, 4.974s configuring, 33.458s building, 0.259s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[18:39:51] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[18:39:53] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[18:40:19] Starting KUnit Kernel (1/1)...
[18:40:19] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[18:40:19] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[18:40:19] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[18:40:19] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[18:40:19] =========== drm_validate_clone_mode (2 subtests) ===========
[18:40:19] ============== drm_test_check_in_clone_mode  ===============
[18:40:19] [PASSED] in_clone_mode
[18:40:19] [PASSED] not_in_clone_mode
[18:40:19] ========== [PASSED] drm_test_check_in_clone_mode ===========
[18:40:19] =============== drm_test_check_valid_clones  ===============
[18:40:19] [PASSED] not_in_clone_mode
[18:40:19] [PASSED] valid_clone
[18:40:19] [PASSED] invalid_clone
[18:40:19] =========== [PASSED] drm_test_check_valid_clones ===========
[18:40:19] ============= [PASSED] drm_validate_clone_mode =============
[18:40:19] ============= drm_validate_modeset (1 subtest) =============
[18:40:19] [PASSED] drm_test_check_connector_changed_modeset
[18:40:19] ============== [PASSED] drm_validate_modeset ===============
[18:40:19] ====== drm_test_bridge_get_current_state (2 subtests) ======
[18:40:19] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[18:40:19] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[18:40:19] ======== [PASSED] drm_test_bridge_get_current_state ========
[18:40:19] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[18:40:19] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[18:40:19] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[18:40:19] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[18:40:19] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[18:40:19] ============== drm_bridge_alloc (2 subtests) ===============
[18:40:19] [PASSED] drm_test_drm_bridge_alloc_basic
[18:40:19] [PASSED] drm_test_drm_bridge_alloc_get_put
[18:40:19] ================ [PASSED] drm_bridge_alloc =================
[18:40:19] ================== drm_buddy (7 subtests) ==================
[18:40:19] [PASSED] drm_test_buddy_alloc_limit
[18:40:19] [PASSED] drm_test_buddy_alloc_optimistic
[18:40:19] [PASSED] drm_test_buddy_alloc_pessimistic
[18:40:19] [PASSED] drm_test_buddy_alloc_pathological
[18:40:19] [PASSED] drm_test_buddy_alloc_contiguous
[18:40:19] [PASSED] drm_test_buddy_alloc_clear
[18:40:19] [PASSED] drm_test_buddy_alloc_range_bias
[18:40:19] ==================== [PASSED] drm_buddy ====================
[18:40:19] ============= drm_cmdline_parser (40 subtests) =============
[18:40:19] [PASSED] drm_test_cmdline_force_d_only
[18:40:19] [PASSED] drm_test_cmdline_force_D_only_dvi
[18:40:19] [PASSED] drm_test_cmdline_force_D_only_hdmi
[18:40:19] [PASSED] drm_test_cmdline_force_D_only_not_digital
[18:40:19] [PASSED] drm_test_cmdline_force_e_only
[18:40:19] [PASSED] drm_test_cmdline_res
[18:40:19] [PASSED] drm_test_cmdline_res_vesa
[18:40:19] [PASSED] drm_test_cmdline_res_vesa_rblank
[18:40:19] [PASSED] drm_test_cmdline_res_rblank
[18:40:19] [PASSED] drm_test_cmdline_res_bpp
[18:40:19] [PASSED] drm_test_cmdline_res_refresh
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[18:40:19] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[18:40:19] [PASSED] drm_test_cmdline_res_margins_force_on
[18:40:19] [PASSED] drm_test_cmdline_res_vesa_margins
[18:40:19] [PASSED] drm_test_cmdline_name
[18:40:19] [PASSED] drm_test_cmdline_name_bpp
[18:40:19] [PASSED] drm_test_cmdline_name_option
[18:40:19] [PASSED] drm_test_cmdline_name_bpp_option
[18:40:19] [PASSED] drm_test_cmdline_rotate_0
[18:40:19] [PASSED] drm_test_cmdline_rotate_90
[18:40:19] [PASSED] drm_test_cmdline_rotate_180
[18:40:19] [PASSED] drm_test_cmdline_rotate_270
[18:40:19] [PASSED] drm_test_cmdline_hmirror
[18:40:19] [PASSED] drm_test_cmdline_vmirror
[18:40:19] [PASSED] drm_test_cmdline_margin_options
[18:40:19] [PASSED] drm_test_cmdline_multiple_options
[18:40:19] [PASSED] drm_test_cmdline_bpp_extra_and_option
[18:40:19] [PASSED] drm_test_cmdline_extra_and_option
[18:40:19] [PASSED] drm_test_cmdline_freestanding_options
[18:40:19] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[18:40:19] [PASSED] drm_test_cmdline_panel_orientation
[18:40:19] ================ drm_test_cmdline_invalid  =================
[18:40:19] [PASSED] margin_only
[18:40:19] [PASSED] interlace_only
[18:40:19] [PASSED] res_missing_x
[18:40:19] [PASSED] res_missing_y
[18:40:19] [PASSED] res_bad_y
[18:40:19] [PASSED] res_missing_y_bpp
[18:40:19] [PASSED] res_bad_bpp
[18:40:19] [PASSED] res_bad_refresh
[18:40:19] [PASSED] res_bpp_refresh_force_on_off
[18:40:19] [PASSED] res_invalid_mode
[18:40:19] [PASSED] res_bpp_wrong_place_mode
[18:40:19] [PASSED] name_bpp_refresh
[18:40:19] [PASSED] name_refresh
[18:40:19] [PASSED] name_refresh_wrong_mode
[18:40:19] [PASSED] name_refresh_invalid_mode
[18:40:19] [PASSED] rotate_multiple
[18:40:19] [PASSED] rotate_invalid_val
[18:40:19] [PASSED] rotate_truncated
[18:40:19] [PASSED] invalid_option
[18:40:19] [PASSED] invalid_tv_option
[18:40:19] [PASSED] truncated_tv_option
[18:40:19] ============ [PASSED] drm_test_cmdline_invalid =============
[18:40:19] =============== drm_test_cmdline_tv_options  ===============
[18:40:19] [PASSED] NTSC
[18:40:19] [PASSED] NTSC_443
[18:40:19] [PASSED] NTSC_J
[18:40:19] [PASSED] PAL
[18:40:19] [PASSED] PAL_M
[18:40:19] [PASSED] PAL_N
[18:40:19] [PASSED] SECAM
[18:40:19] [PASSED] MONO_525
[18:40:19] [PASSED] MONO_625
[18:40:19] =========== [PASSED] drm_test_cmdline_tv_options ===========
[18:40:19] =============== [PASSED] drm_cmdline_parser ================
[18:40:19] ========== drmm_connector_hdmi_init (20 subtests) ==========
[18:40:19] [PASSED] drm_test_connector_hdmi_init_valid
[18:40:19] [PASSED] drm_test_connector_hdmi_init_bpc_8
[18:40:19] [PASSED] drm_test_connector_hdmi_init_bpc_10
[18:40:19] [PASSED] drm_test_connector_hdmi_init_bpc_12
[18:40:19] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[18:40:19] [PASSED] drm_test_connector_hdmi_init_bpc_null
[18:40:19] [PASSED] drm_test_connector_hdmi_init_formats_empty
[18:40:19] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[18:40:19] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[18:40:19] [PASSED] supported_formats=0x9 yuv420_allowed=1
[18:40:19] [PASSED] supported_formats=0x9 yuv420_allowed=0
[18:40:19] [PASSED] supported_formats=0x3 yuv420_allowed=1
[18:40:19] [PASSED] supported_formats=0x3 yuv420_allowed=0
[18:40:19] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[18:40:19] [PASSED] drm_test_connector_hdmi_init_null_ddc
[18:40:19] [PASSED] drm_test_connector_hdmi_init_null_product
[18:40:19] [PASSED] drm_test_connector_hdmi_init_null_vendor
[18:40:19] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[18:40:19] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[18:40:19] [PASSED] drm_test_connector_hdmi_init_product_valid
[18:40:19] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[18:40:19] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[18:40:19] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[18:40:19] ========= drm_test_connector_hdmi_init_type_valid  =========
[18:40:19] [PASSED] HDMI-A
[18:40:19] [PASSED] HDMI-B
[18:40:19] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[18:40:19] ======== drm_test_connector_hdmi_init_type_invalid  ========
[18:40:19] [PASSED] Unknown
[18:40:19] [PASSED] VGA
[18:40:19] [PASSED] DVI-I
[18:40:19] [PASSED] DVI-D
[18:40:19] [PASSED] DVI-A
[18:40:19] [PASSED] Composite
[18:40:19] [PASSED] SVIDEO
[18:40:19] [PASSED] LVDS
[18:40:19] [PASSED] Component
[18:40:19] [PASSED] DIN
[18:40:19] [PASSED] DP
[18:40:19] [PASSED] TV
[18:40:19] [PASSED] eDP
[18:40:19] [PASSED] Virtual
[18:40:19] [PASSED] DSI
[18:40:19] [PASSED] DPI
[18:40:19] [PASSED] Writeback
[18:40:19] [PASSED] SPI
[18:40:19] [PASSED] USB
[18:40:19] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[18:40:19] ============ [PASSED] drmm_connector_hdmi_init =============
[18:40:19] ============= drmm_connector_init (3 subtests) =============
[18:40:19] [PASSED] drm_test_drmm_connector_init
[18:40:19] [PASSED] drm_test_drmm_connector_init_null_ddc
[18:40:19] ========= drm_test_drmm_connector_init_type_valid  =========
[18:40:19] [PASSED] Unknown
[18:40:19] [PASSED] VGA
[18:40:19] [PASSED] DVI-I
[18:40:19] [PASSED] DVI-D
[18:40:19] [PASSED] DVI-A
[18:40:19] [PASSED] Composite
[18:40:19] [PASSED] SVIDEO
[18:40:19] [PASSED] LVDS
[18:40:19] [PASSED] Component
[18:40:19] [PASSED] DIN
[18:40:19] [PASSED] DP
[18:40:19] [PASSED] HDMI-A
[18:40:19] [PASSED] HDMI-B
[18:40:19] [PASSED] TV
[18:40:19] [PASSED] eDP
[18:40:19] [PASSED] Virtual
[18:40:19] [PASSED] DSI
[18:40:19] [PASSED] DPI
[18:40:19] [PASSED] Writeback
[18:40:19] [PASSED] SPI
[18:40:19] [PASSED] USB
[18:40:19] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[18:40:19] =============== [PASSED] drmm_connector_init ===============
[18:40:19] ========= drm_connector_dynamic_init (6 subtests) ==========
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_init
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_init_properties
[18:40:19] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[18:40:19] [PASSED] Unknown
[18:40:19] [PASSED] VGA
[18:40:19] [PASSED] DVI-I
[18:40:19] [PASSED] DVI-D
[18:40:19] [PASSED] DVI-A
[18:40:19] [PASSED] Composite
[18:40:19] [PASSED] SVIDEO
[18:40:19] [PASSED] LVDS
[18:40:19] [PASSED] Component
[18:40:19] [PASSED] DIN
[18:40:19] [PASSED] DP
[18:40:19] [PASSED] HDMI-A
[18:40:19] [PASSED] HDMI-B
[18:40:19] [PASSED] TV
[18:40:19] [PASSED] eDP
[18:40:19] [PASSED] Virtual
[18:40:19] [PASSED] DSI
[18:40:19] [PASSED] DPI
[18:40:19] [PASSED] Writeback
[18:40:19] [PASSED] SPI
[18:40:19] [PASSED] USB
[18:40:19] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[18:40:19] ======== drm_test_drm_connector_dynamic_init_name  =========
[18:40:19] [PASSED] Unknown
[18:40:19] [PASSED] VGA
[18:40:19] [PASSED] DVI-I
[18:40:19] [PASSED] DVI-D
[18:40:19] [PASSED] DVI-A
[18:40:19] [PASSED] Composite
[18:40:19] [PASSED] SVIDEO
[18:40:19] [PASSED] LVDS
[18:40:19] [PASSED] Component
[18:40:19] [PASSED] DIN
[18:40:19] [PASSED] DP
[18:40:19] [PASSED] HDMI-A
[18:40:19] [PASSED] HDMI-B
[18:40:19] [PASSED] TV
[18:40:19] [PASSED] eDP
[18:40:19] [PASSED] Virtual
[18:40:19] [PASSED] DSI
[18:40:19] [PASSED] DPI
[18:40:19] [PASSED] Writeback
[18:40:19] [PASSED] SPI
[18:40:19] [PASSED] USB
[18:40:19] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[18:40:19] =========== [PASSED] drm_connector_dynamic_init ============
[18:40:19] ==== drm_connector_dynamic_register_early (4 subtests) =====
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[18:40:19] ====== [PASSED] drm_connector_dynamic_register_early =======
[18:40:19] ======= drm_connector_dynamic_register (7 subtests) ========
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[18:40:19] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[18:40:19] ========= [PASSED] drm_connector_dynamic_register ==========
[18:40:19] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[18:40:19] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[18:40:19] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[18:40:19] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[18:40:19] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[18:40:19] ========== drm_test_get_tv_mode_from_name_valid  ===========
[18:40:19] [PASSED] NTSC
[18:40:19] [PASSED] NTSC-443
[18:40:19] [PASSED] NTSC-J
[18:40:19] [PASSED] PAL
[18:40:19] [PASSED] PAL-M
[18:40:19] [PASSED] PAL-N
[18:40:19] [PASSED] SECAM
[18:40:19] [PASSED] Mono
[18:40:19] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[18:40:19] [PASSED] drm_test_get_tv_mode_from_name_truncated
[18:40:19] ============ [PASSED] drm_get_tv_mode_from_name ============
[18:40:19] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[18:40:19] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[18:40:19] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[18:40:19] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[18:40:19] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[18:40:19] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[18:40:19] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[18:40:19] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[18:40:19] [PASSED] VIC 96
[18:40:19] [PASSED] VIC 97
[18:40:19] [PASSED] VIC 101
[18:40:19] [PASSED] VIC 102
[18:40:19] [PASSED] VIC 106
[18:40:19] [PASSED] VIC 107
[18:40:19] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[18:40:19] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[18:40:19] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[18:40:19] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[18:40:19] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[18:40:19] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[18:40:19] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[18:40:19] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[18:40:19] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[18:40:19] [PASSED] Automatic
[18:40:19] [PASSED] Full
[18:40:19] [PASSED] Limited 16:235
[18:40:19] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[18:40:19] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[18:40:19] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[18:40:19] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[18:40:19] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[18:40:19] [PASSED] RGB
[18:40:19] [PASSED] YUV 4:2:0
[18:40:19] [PASSED] YUV 4:2:2
[18:40:19] [PASSED] YUV 4:4:4
[18:40:19] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[18:40:19] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[18:40:19] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[18:40:19] ============= drm_damage_helper (21 subtests) ==============
[18:40:19] [PASSED] drm_test_damage_iter_no_damage
[18:40:19] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[18:40:19] [PASSED] drm_test_damage_iter_no_damage_src_moved
[18:40:19] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[18:40:19] [PASSED] drm_test_damage_iter_no_damage_not_visible
[18:40:19] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[18:40:19] [PASSED] drm_test_damage_iter_no_damage_no_fb
[18:40:19] [PASSED] drm_test_damage_iter_simple_damage
[18:40:19] [PASSED] drm_test_damage_iter_single_damage
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_outside_src
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_src_moved
[18:40:19] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[18:40:19] [PASSED] drm_test_damage_iter_damage
[18:40:19] [PASSED] drm_test_damage_iter_damage_one_intersect
[18:40:19] [PASSED] drm_test_damage_iter_damage_one_outside
[18:40:19] [PASSED] drm_test_damage_iter_damage_src_moved
[18:40:19] [PASSED] drm_test_damage_iter_damage_not_visible
[18:40:19] ================ [PASSED] drm_damage_helper ================
[18:40:19] ============== drm_dp_mst_helper (3 subtests) ==============
[18:40:19] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[18:40:19] [PASSED] Clock 154000 BPP 30 DSC disabled
[18:40:19] [PASSED] Clock 234000 BPP 30 DSC disabled
[18:40:19] [PASSED] Clock 297000 BPP 24 DSC disabled
[18:40:19] [PASSED] Clock 332880 BPP 24 DSC enabled
[18:40:19] [PASSED] Clock 324540 BPP 24 DSC enabled
[18:40:19] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[18:40:19] ============== drm_test_dp_mst_calc_pbn_div  ===============
[18:40:19] [PASSED] Link rate 2000000 lane count 4
[18:40:19] [PASSED] Link rate 2000000 lane count 2
[18:40:19] [PASSED] Link rate 2000000 lane count 1
[18:40:19] [PASSED] Link rate 1350000 lane count 4
[18:40:19] [PASSED] Link rate 1350000 lane count 2
[18:40:19] [PASSED] Link rate 1350000 lane count 1
[18:40:19] [PASSED] Link rate 1000000 lane count 4
[18:40:19] [PASSED] Link rate 1000000 lane count 2
[18:40:19] [PASSED] Link rate 1000000 lane count 1
[18:40:19] [PASSED] Link rate 810000 lane count 4
[18:40:19] [PASSED] Link rate 810000 lane count 2
[18:40:19] [PASSED] Link rate 810000 lane count 1
[18:40:19] [PASSED] Link rate 540000 lane count 4
[18:40:19] [PASSED] Link rate 540000 lane count 2
[18:40:19] [PASSED] Link rate 540000 lane count 1
[18:40:19] [PASSED] Link rate 270000 lane count 4
[18:40:19] [PASSED] Link rate 270000 lane count 2
[18:40:19] [PASSED] Link rate 270000 lane count 1
[18:40:19] [PASSED] Link rate 162000 lane count 4
[18:40:19] [PASSED] Link rate 162000 lane count 2
[18:40:19] [PASSED] Link rate 162000 lane count 1
[18:40:19] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[18:40:19] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[18:40:19] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[18:40:19] [PASSED] DP_POWER_UP_PHY with port number
[18:40:19] [PASSED] DP_POWER_DOWN_PHY with port number
[18:40:19] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[18:40:19] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[18:40:19] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[18:40:19] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[18:40:19] [PASSED] DP_QUERY_PAYLOAD with port number
[18:40:19] [PASSED] DP_QUERY_PAYLOAD with VCPI
[18:40:19] [PASSED] DP_REMOTE_DPCD_READ with port number
[18:40:19] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[18:40:19] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[18:40:19] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[18:40:19] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[18:40:19] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[18:40:19] [PASSED] DP_REMOTE_I2C_READ with port number
[18:40:19] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[18:40:19] [PASSED] DP_REMOTE_I2C_READ with transactions array
[18:40:19] [PASSED] DP_REMOTE_I2C_WRITE with port number
[18:40:19] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[18:40:19] [PASSED] DP_REMOTE_I2C_WRITE with data array
[18:40:19] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[18:40:19] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[18:40:19] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[18:40:19] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[18:40:19] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[18:40:19] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[18:40:19] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[18:40:19] ================ [PASSED] drm_dp_mst_helper ================
[18:40:19] ================== drm_exec (7 subtests) ===================
[18:40:19] [PASSED] sanitycheck
[18:40:19] [PASSED] test_lock
[18:40:19] [PASSED] test_lock_unlock
[18:40:19] [PASSED] test_duplicates
[18:40:19] [PASSED] test_prepare
[18:40:19] [PASSED] test_prepare_array
[18:40:19] [PASSED] test_multiple_loops
[18:40:19] ==================== [PASSED] drm_exec =====================
[18:40:19] =========== drm_format_helper_test (17 subtests) ===========
[18:40:19] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[18:40:19] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[18:40:19] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[18:40:19] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[18:40:19] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[18:40:19] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[18:40:19] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[18:40:19] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[18:40:19] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[18:40:19] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[18:40:19] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[18:40:19] ============== drm_test_fb_xrgb8888_to_mono  ===============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[18:40:19] ==================== drm_test_fb_swab  =====================
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ================ [PASSED] drm_test_fb_swab =================
[18:40:19] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[18:40:19] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[18:40:19] [PASSED] single_pixel_source_buffer
[18:40:19] [PASSED] single_pixel_clip_rectangle
[18:40:19] [PASSED] well_known_colors
[18:40:19] [PASSED] destination_pitch
[18:40:19] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[18:40:19] ================= drm_test_fb_clip_offset  =================
[18:40:19] [PASSED] pass through
[18:40:19] [PASSED] horizontal offset
[18:40:19] [PASSED] vertical offset
[18:40:19] [PASSED] horizontal and vertical offset
[18:40:19] [PASSED] horizontal offset (custom pitch)
[18:40:19] [PASSED] vertical offset (custom pitch)
[18:40:19] [PASSED] horizontal and vertical offset (custom pitch)
[18:40:19] ============= [PASSED] drm_test_fb_clip_offset =============
[18:40:19] =================== drm_test_fb_memcpy  ====================
[18:40:19] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[18:40:19] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[18:40:19] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[18:40:19] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[18:40:19] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[18:40:19] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[18:40:19] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[18:40:19] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[18:40:19] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[18:40:19] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[18:40:19] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[18:40:19] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[18:40:19] =============== [PASSED] drm_test_fb_memcpy ================
[18:40:19] ============= [PASSED] drm_format_helper_test ==============
[18:40:19] ================= drm_format (18 subtests) =================
[18:40:19] [PASSED] drm_test_format_block_width_invalid
[18:40:19] [PASSED] drm_test_format_block_width_one_plane
[18:40:19] [PASSED] drm_test_format_block_width_two_plane
[18:40:19] [PASSED] drm_test_format_block_width_three_plane
[18:40:19] [PASSED] drm_test_format_block_width_tiled
[18:40:19] [PASSED] drm_test_format_block_height_invalid
[18:40:19] [PASSED] drm_test_format_block_height_one_plane
[18:40:19] [PASSED] drm_test_format_block_height_two_plane
[18:40:19] [PASSED] drm_test_format_block_height_three_plane
[18:40:19] [PASSED] drm_test_format_block_height_tiled
[18:40:19] [PASSED] drm_test_format_min_pitch_invalid
[18:40:19] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[18:40:19] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[18:40:19] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[18:40:19] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[18:40:19] [PASSED] drm_test_format_min_pitch_two_plane
[18:40:19] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[18:40:19] [PASSED] drm_test_format_min_pitch_tiled
[18:40:19] =================== [PASSED] drm_format ====================
[18:40:19] ============== drm_framebuffer (10 subtests) ===============
[18:40:19] ========== drm_test_framebuffer_check_src_coords  ==========
[18:40:19] [PASSED] Success: source fits into fb
[18:40:19] [PASSED] Fail: overflowing fb with x-axis coordinate
[18:40:19] [PASSED] Fail: overflowing fb with y-axis coordinate
[18:40:19] [PASSED] Fail: overflowing fb with source width
[18:40:19] [PASSED] Fail: overflowing fb with source height
[18:40:19] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[18:40:19] [PASSED] drm_test_framebuffer_cleanup
[18:40:19] =============== drm_test_framebuffer_create  ===============
[18:40:19] [PASSED] ABGR8888 normal sizes
[18:40:19] [PASSED] ABGR8888 max sizes
[18:40:19] [PASSED] ABGR8888 pitch greater than min required
[18:40:19] [PASSED] ABGR8888 pitch less than min required
[18:40:19] [PASSED] ABGR8888 Invalid width
[18:40:19] [PASSED] ABGR8888 Invalid buffer handle
[18:40:19] [PASSED] No pixel format
[18:40:19] [PASSED] ABGR8888 Width 0
[18:40:19] [PASSED] ABGR8888 Height 0
[18:40:19] [PASSED] ABGR8888 Out of bound height * pitch combination
[18:40:19] [PASSED] ABGR8888 Large buffer offset
[18:40:19] [PASSED] ABGR8888 Buffer offset for inexistent plane
[18:40:19] [PASSED] ABGR8888 Invalid flag
[18:40:19] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[18:40:19] [PASSED] ABGR8888 Valid buffer modifier
[18:40:19] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[18:40:19] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] NV12 Normal sizes
[18:40:19] [PASSED] NV12 Max sizes
[18:40:19] [PASSED] NV12 Invalid pitch
[18:40:19] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[18:40:19] [PASSED] NV12 different  modifier per-plane
[18:40:19] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[18:40:19] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] NV12 Modifier for inexistent plane
[18:40:19] [PASSED] NV12 Handle for inexistent plane
[18:40:19] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[18:40:19] [PASSED] YVU420 Normal sizes
[18:40:19] [PASSED] YVU420 Max sizes
[18:40:19] [PASSED] YVU420 Invalid pitch
[18:40:19] [PASSED] YVU420 Different pitches
[18:40:19] [PASSED] YVU420 Different buffer offsets/pitches
[18:40:19] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[18:40:19] [PASSED] YVU420 Valid modifier
[18:40:19] [PASSED] YVU420 Different modifiers per plane
[18:40:19] [PASSED] YVU420 Modifier for inexistent plane
[18:40:19] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[18:40:19] [PASSED] X0L2 Normal sizes
[18:40:19] [PASSED] X0L2 Max sizes
[18:40:19] [PASSED] X0L2 Invalid pitch
[18:40:19] [PASSED] X0L2 Pitch greater than minimum required
[18:40:19] [PASSED] X0L2 Handle for inexistent plane
[18:40:19] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[18:40:19] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[18:40:19] [PASSED] X0L2 Valid modifier
[18:40:19] [PASSED] X0L2 Modifier for inexistent plane
[18:40:19] =========== [PASSED] drm_test_framebuffer_create ===========
[18:40:19] [PASSED] drm_test_framebuffer_free
[18:40:19] [PASSED] drm_test_framebuffer_init
[18:40:19] [PASSED] drm_test_framebuffer_init_bad_format
[18:40:19] [PASSED] drm_test_framebuffer_init_dev_mismatch
[18:40:19] [PASSED] drm_test_framebuffer_lookup
[18:40:19] [PASSED] drm_test_framebuffer_lookup_inexistent
[18:40:19] [PASSED] drm_test_framebuffer_modifiers_not_supported
[18:40:19] ================= [PASSED] drm_framebuffer =================
[18:40:19] ================ drm_gem_shmem (8 subtests) ================
[18:40:19] [PASSED] drm_gem_shmem_test_obj_create
[18:40:19] [PASSED] drm_gem_shmem_test_obj_create_private
[18:40:19] [PASSED] drm_gem_shmem_test_pin_pages
[18:40:19] [PASSED] drm_gem_shmem_test_vmap
[18:40:19] [PASSED] drm_gem_shmem_test_get_pages_sgt
[18:40:19] [PASSED] drm_gem_shmem_test_get_sg_table
[18:40:19] [PASSED] drm_gem_shmem_test_madvise
[18:40:19] [PASSED] drm_gem_shmem_test_purge
[18:40:19] ================== [PASSED] drm_gem_shmem ==================
[18:40:19] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[18:40:19] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[18:40:19] [PASSED] Automatic
[18:40:19] [PASSED] Full
[18:40:19] [PASSED] Limited 16:235
[18:40:19] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[18:40:19] [PASSED] drm_test_check_disable_connector
[18:40:19] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[18:40:19] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[18:40:19] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[18:40:19] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[18:40:19] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[18:40:19] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[18:40:19] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[18:40:19] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[18:40:19] [PASSED] drm_test_check_output_bpc_dvi
[18:40:19] [PASSED] drm_test_check_output_bpc_format_vic_1
[18:40:19] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[18:40:19] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[18:40:19] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[18:40:19] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[18:40:19] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[18:40:19] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[18:40:19] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[18:40:19] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[18:40:19] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[18:40:19] [PASSED] drm_test_check_broadcast_rgb_value
[18:40:19] [PASSED] drm_test_check_bpc_8_value
[18:40:19] [PASSED] drm_test_check_bpc_10_value
[18:40:19] [PASSED] drm_test_check_bpc_12_value
[18:40:19] [PASSED] drm_test_check_format_value
[18:40:19] [PASSED] drm_test_check_tmds_char_value
[18:40:19] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[18:40:19] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[18:40:19] [PASSED] drm_test_check_mode_valid
[18:40:19] [PASSED] drm_test_check_mode_valid_reject
[18:40:19] [PASSED] drm_test_check_mode_valid_reject_rate
[18:40:19] [PASSED] drm_test_check_mode_valid_reject_max_clock
[18:40:19] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[18:40:19] ================= drm_managed (2 subtests) =================
[18:40:19] [PASSED] drm_test_managed_release_action
[18:40:19] [PASSED] drm_test_managed_run_action
[18:40:19] =================== [PASSED] drm_managed ===================
[18:40:19] =================== drm_mm (6 subtests) ====================
[18:40:19] [PASSED] drm_test_mm_init
[18:40:19] [PASSED] drm_test_mm_debug
[18:40:19] [PASSED] drm_test_mm_align32
[18:40:19] [PASSED] drm_test_mm_align64
[18:40:19] [PASSED] drm_test_mm_lowest
[18:40:19] [PASSED] drm_test_mm_highest
[18:40:19] ===================== [PASSED] drm_mm ======================
[18:40:19] ============= drm_modes_analog_tv (5 subtests) =============
[18:40:19] [PASSED] drm_test_modes_analog_tv_mono_576i
[18:40:19] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[18:40:19] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[18:40:19] [PASSED] drm_test_modes_analog_tv_pal_576i
[18:40:19] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[18:40:19] =============== [PASSED] drm_modes_analog_tv ===============
[18:40:19] ============== drm_plane_helper (2 subtests) ===============
[18:40:19] =============== drm_test_check_plane_state  ================
[18:40:19] [PASSED] clipping_simple
[18:40:19] [PASSED] clipping_rotate_reflect
[18:40:19] [PASSED] positioning_simple
[18:40:19] [PASSED] upscaling
[18:40:19] [PASSED] downscaling
[18:40:19] [PASSED] rounding1
[18:40:19] [PASSED] rounding2
[18:40:19] [PASSED] rounding3
[18:40:19] [PASSED] rounding4
[18:40:19] =========== [PASSED] drm_test_check_plane_state ============
[18:40:19] =========== drm_test_check_invalid_plane_state  ============
[18:40:19] [PASSED] positioning_invalid
[18:40:19] [PASSED] upscaling_invalid
[18:40:19] [PASSED] downscaling_invalid
[18:40:19] ======= [PASSED] drm_test_check_invalid_plane_state ========
[18:40:19] ================ [PASSED] drm_plane_helper =================
[18:40:19] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[18:40:19] ====== drm_test_connector_helper_tv_get_modes_check  =======
[18:40:19] [PASSED] None
[18:40:19] [PASSED] PAL
[18:40:19] [PASSED] NTSC
[18:40:19] [PASSED] Both, NTSC Default
[18:40:19] [PASSED] Both, PAL Default
[18:40:19] [PASSED] Both, NTSC Default, with PAL on command-line
[18:40:19] [PASSED] Both, PAL Default, with NTSC on command-line
[18:40:19] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[18:40:19] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[18:40:19] ================== drm_rect (9 subtests) ===================
[18:40:19] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[18:40:19] [PASSED] drm_test_rect_clip_scaled_not_clipped
[18:40:19] [PASSED] drm_test_rect_clip_scaled_clipped
[18:40:19] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[18:40:19] ================= drm_test_rect_intersect  =================
[18:40:19] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[18:40:19] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[18:40:19] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[18:40:19] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[18:40:19] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[18:40:19] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[18:40:19] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[18:40:19] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[18:40:19] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[18:40:19] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[18:40:19] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[18:40:19] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[18:40:19] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[18:40:19] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[18:40:19] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[18:40:19] ============= [PASSED] drm_test_rect_intersect =============
[18:40:19] ================ drm_test_rect_calc_hscale  ================
[18:40:19] [PASSED] normal use
[18:40:19] [PASSED] out of max range
[18:40:19] [PASSED] out of min range
[18:40:19] [PASSED] zero dst
[18:40:19] [PASSED] negative src
[18:40:19] [PASSED] negative dst
[18:40:19] ============ [PASSED] drm_test_rect_calc_hscale ============
[18:40:19] ================ drm_test_rect_calc_vscale  ================
[18:40:19] [PASSED] normal use
[18:40:19] [PASSED] out of max range
[18:40:19] [PASSED] out of min range
[18:40:19] [PASSED] zero dst
[18:40:19] [PASSED] negative src
[18:40:19] [PASSED] negative dst
[18:40:19] ============ [PASSED] drm_test_rect_calc_vscale ============
[18:40:19] ================== drm_test_rect_rotate  ===================
[18:40:19] [PASSED] reflect-x
[18:40:19] [PASSED] reflect-y
[18:40:19] [PASSED] rotate-0
[18:40:19] [PASSED] rotate-90
[18:40:19] [PASSED] rotate-180
[18:40:19] [PASSED] rotate-270
stty: 'standard input': Inappropriate ioctl for device
[18:40:19] ============== [PASSED] drm_test_rect_rotate ===============
[18:40:19] ================ drm_test_rect_rotate_inv  =================
[18:40:19] [PASSED] reflect-x
[18:40:19] [PASSED] reflect-y
[18:40:19] [PASSED] rotate-0
[18:40:19] [PASSED] rotate-90
[18:40:19] [PASSED] rotate-180
[18:40:19] [PASSED] rotate-270
[18:40:19] ============ [PASSED] drm_test_rect_rotate_inv =============
[18:40:19] ==================== [PASSED] drm_rect =====================
[18:40:19] ============ drm_sysfb_modeset_test (1 subtest) ============
[18:40:19] ============ drm_test_sysfb_build_fourcc_list  =============
[18:40:19] [PASSED] no native formats
[18:40:19] [PASSED] XRGB8888 as native format
[18:40:19] [PASSED] remove duplicates
[18:40:19] [PASSED] convert alpha formats
[18:40:19] [PASSED] random formats
[18:40:19] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[18:40:19] ============= [PASSED] drm_sysfb_modeset_test ==============
[18:40:19] ============================================================
[18:40:19] Testing complete. Ran 616 tests: passed: 616
[18:40:19] Elapsed time: 27.933s total, 1.630s configuring, 26.136s building, 0.142s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[18:40:19] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[18:40:21] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=25
[18:40:28] Starting KUnit Kernel (1/1)...
[18:40:28] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[18:40:28] ================= ttm_device (5 subtests) ==================
[18:40:28] [PASSED] ttm_device_init_basic
[18:40:28] [PASSED] ttm_device_init_multiple
[18:40:28] [PASSED] ttm_device_fini_basic
[18:40:28] [PASSED] ttm_device_init_no_vma_man
[18:40:28] ================== ttm_device_init_pools  ==================
[18:40:28] [PASSED] No DMA allocations, no DMA32 required
[18:40:28] [PASSED] DMA allocations, DMA32 required
[18:40:28] [PASSED] No DMA allocations, DMA32 required
[18:40:28] [PASSED] DMA allocations, no DMA32 required
[18:40:28] ============== [PASSED] ttm_device_init_pools ==============
[18:40:28] =================== [PASSED] ttm_device ====================
[18:40:28] ================== ttm_pool (8 subtests) ===================
[18:40:28] ================== ttm_pool_alloc_basic  ===================
[18:40:28] [PASSED] One page
[18:40:28] [PASSED] More than one page
[18:40:28] [PASSED] Above the allocation limit
[18:40:28] [PASSED] One page, with coherent DMA mappings enabled
[18:40:28] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[18:40:28] ============== [PASSED] ttm_pool_alloc_basic ===============
[18:40:28] ============== ttm_pool_alloc_basic_dma_addr  ==============
[18:40:28] [PASSED] One page
[18:40:28] [PASSED] More than one page
[18:40:28] [PASSED] Above the allocation limit
[18:40:28] [PASSED] One page, with coherent DMA mappings enabled
[18:40:28] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[18:40:28] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[18:40:28] [PASSED] ttm_pool_alloc_order_caching_match
[18:40:28] [PASSED] ttm_pool_alloc_caching_mismatch
[18:40:28] [PASSED] ttm_pool_alloc_order_mismatch
[18:40:28] [PASSED] ttm_pool_free_dma_alloc
[18:40:28] [PASSED] ttm_pool_free_no_dma_alloc
[18:40:28] [PASSED] ttm_pool_fini_basic
[18:40:28] ==================== [PASSED] ttm_pool =====================
[18:40:28] ================ ttm_resource (8 subtests) =================
[18:40:28] ================= ttm_resource_init_basic  =================
[18:40:28] [PASSED] Init resource in TTM_PL_SYSTEM
[18:40:28] [PASSED] Init resource in TTM_PL_VRAM
[18:40:28] [PASSED] Init resource in a private placement
[18:40:28] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[18:40:28] ============= [PASSED] ttm_resource_init_basic =============
[18:40:28] [PASSED] ttm_resource_init_pinned
[18:40:28] [PASSED] ttm_resource_fini_basic
[18:40:28] [PASSED] ttm_resource_manager_init_basic
[18:40:28] [PASSED] ttm_resource_manager_usage_basic
[18:40:28] [PASSED] ttm_resource_manager_set_used_basic
[18:40:28] [PASSED] ttm_sys_man_alloc_basic
[18:40:28] [PASSED] ttm_sys_man_free_basic
[18:40:28] ================== [PASSED] ttm_resource ===================
[18:40:28] =================== ttm_tt (15 subtests) ===================
[18:40:28] ==================== ttm_tt_init_basic  ====================
[18:40:28] [PASSED] Page-aligned size
[18:40:28] [PASSED] Extra pages requested
[18:40:28] ================ [PASSED] ttm_tt_init_basic ================
[18:40:28] [PASSED] ttm_tt_init_misaligned
[18:40:28] [PASSED] ttm_tt_fini_basic
[18:40:28] [PASSED] ttm_tt_fini_sg
[18:40:28] [PASSED] ttm_tt_fini_shmem
[18:40:28] [PASSED] ttm_tt_create_basic
[18:40:28] [PASSED] ttm_tt_create_invalid_bo_type
[18:40:28] [PASSED] ttm_tt_create_ttm_exists
[18:40:28] [PASSED] ttm_tt_create_failed
[18:40:28] [PASSED] ttm_tt_destroy_basic
[18:40:28] [PASSED] ttm_tt_populate_null_ttm
[18:40:28] [PASSED] ttm_tt_populate_populated_ttm
[18:40:28] [PASSED] ttm_tt_unpopulate_basic
[18:40:28] [PASSED] ttm_tt_unpopulate_empty_ttm
[18:40:28] [PASSED] ttm_tt_swapin_basic
[18:40:28] ===================== [PASSED] ttm_tt ======================
[18:40:28] =================== ttm_bo (14 subtests) ===================
[18:40:28] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[18:40:28] [PASSED] Cannot be interrupted and sleeps
[18:40:28] [PASSED] Cannot be interrupted, locks straight away
[18:40:28] [PASSED] Can be interrupted, sleeps
[18:40:28] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[18:40:28] [PASSED] ttm_bo_reserve_locked_no_sleep
[18:40:28] [PASSED] ttm_bo_reserve_no_wait_ticket
[18:40:28] [PASSED] ttm_bo_reserve_double_resv
[18:40:28] [PASSED] ttm_bo_reserve_interrupted
[18:40:28] [PASSED] ttm_bo_reserve_deadlock
[18:40:28] [PASSED] ttm_bo_unreserve_basic
[18:40:28] [PASSED] ttm_bo_unreserve_pinned
[18:40:28] [PASSED] ttm_bo_unreserve_bulk
[18:40:28] [PASSED] ttm_bo_put_basic
[18:40:28] [PASSED] ttm_bo_put_shared_resv
[18:40:28] [PASSED] ttm_bo_pin_basic
[18:40:28] [PASSED] ttm_bo_pin_unpin_resource
[18:40:28] [PASSED] ttm_bo_multiple_pin_one_unpin
[18:40:28] ===================== [PASSED] ttm_bo ======================
[18:40:28] ============== ttm_bo_validate (22 subtests) ===============
[18:40:28] ============== ttm_bo_init_reserved_sys_man  ===============
[18:40:28] [PASSED] Buffer object for userspace
[18:40:28] [PASSED] Kernel buffer object
[18:40:28] [PASSED] Shared buffer object
[18:40:28] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[18:40:28] ============== ttm_bo_init_reserved_mock_man  ==============
[18:40:28] [PASSED] Buffer object for userspace
[18:40:28] [PASSED] Kernel buffer object
[18:40:28] [PASSED] Shared buffer object
[18:40:28] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[18:40:28] [PASSED] ttm_bo_init_reserved_resv
[18:40:28] ================== ttm_bo_validate_basic  ==================
[18:40:28] [PASSED] Buffer object for userspace
[18:40:28] [PASSED] Kernel buffer object
[18:40:28] [PASSED] Shared buffer object
[18:40:28] ============== [PASSED] ttm_bo_validate_basic ==============
[18:40:28] [PASSED] ttm_bo_validate_invalid_placement
[18:40:28] ============= ttm_bo_validate_same_placement  ==============
[18:40:28] [PASSED] System manager
[18:40:28] [PASSED] VRAM manager
[18:40:28] ========= [PASSED] ttm_bo_validate_same_placement ==========
[18:40:28] [PASSED] ttm_bo_validate_failed_alloc
[18:40:28] [PASSED] ttm_bo_validate_pinned
[18:40:28] [PASSED] ttm_bo_validate_busy_placement
[18:40:28] ================ ttm_bo_validate_multihop  =================
[18:40:28] [PASSED] Buffer object for userspace
[18:40:28] [PASSED] Kernel buffer object
[18:40:28] [PASSED] Shared buffer object
[18:40:28] ============ [PASSED] ttm_bo_validate_multihop =============
[18:40:28] ========== ttm_bo_validate_no_placement_signaled  ==========
[18:40:28] [PASSED] Buffer object in system domain, no page vector
[18:40:28] [PASSED] Buffer object in system domain with an existing page vector
[18:40:28] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[18:40:28] ======== ttm_bo_validate_no_placement_not_signaled  ========
[18:40:28] [PASSED] Buffer object for userspace
[18:40:28] [PASSED] Kernel buffer object
[18:40:28] [PASSED] Shared buffer object
[18:40:28] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[18:40:28] [PASSED] ttm_bo_validate_move_fence_signaled
[18:40:28] ========= ttm_bo_validate_move_fence_not_signaled  =========
[18:40:28] [PASSED] Waits for GPU
[18:40:28] [PASSED] Tries to lock straight away
[18:40:29] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[18:40:29] [PASSED] ttm_bo_validate_swapout
[18:40:29] [PASSED] ttm_bo_validate_happy_evict
[18:40:29] [PASSED] ttm_bo_validate_all_pinned_evict
[18:40:29] [PASSED] ttm_bo_validate_allowed_only_evict
[18:40:29] [PASSED] ttm_bo_validate_deleted_evict
[18:40:29] [PASSED] ttm_bo_validate_busy_domain_evict
[18:40:29] [PASSED] ttm_bo_validate_evict_gutting
[18:40:29] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[18:40:29] ================= [PASSED] ttm_bo_validate =================
[18:40:29] ============================================================
[18:40:29] Testing complete. Ran 102 tests: passed: 102
[18:40:29] Elapsed time: 10.073s total, 1.611s configuring, 7.793s building, 0.547s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

✗ CI.checksparse: warning for Introducing firmware late binding

[Patchwork]

== Series Details ==

Series: Introducing firmware late binding
URL   : https://patchwork.freedesktop.org/series/151082/
State : warning

== Summary ==

+ trap cleanup EXIT
+ KERNEL=/kernel
+ MT=/root/linux/maintainer-tools
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools
Cloning into '/root/linux/maintainer-tools'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ make -C /root/linux/maintainer-tools
make: Entering directory '/root/linux/maintainer-tools'
cc -O2 -g -Wextra -o remap-log remap-log.c
make: Leaving directory '/root/linux/maintainer-tools'
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ /root/linux/maintainer-tools/dim sparse --fast 94631e6b7f655b1922e3227970cd6180200694af
Sparse version: 0.6.4 (Ubuntu: 0.6.4-4ubuntu3)
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display_types.h:2019:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2032:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_hdcp.c: note: in included file:

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

✓ Xe.CI.BAT: success for Introducing firmware late binding

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

== Series Details ==

Series: Introducing firmware late binding
URL   : https://patchwork.freedesktop.org/series/151082/
State : success

== Summary ==

CI Bug Log - changes from xe-3336-94631e6b7f655b1922e3227970cd6180200694af_BAT -> xe-pw-151082v1_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (9 -> 8)
------------------------------

  Missing    (1): bat-adlp-vm 

Known issues
------------

  Here are the changes found in xe-pw-151082v1_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_flip@basic-plain-flip@b-edp1:
    - bat-adlp-7:         [PASS][1] -> [DMESG-WARN][2] ([Intel XE#4543]) +1 other test dmesg-warn
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3336-94631e6b7f655b1922e3227970cd6180200694af/bat-adlp-7/igt@kms_flip@basic-plain-flip@b-edp1.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151082v1/bat-adlp-7/igt@kms_flip@basic-plain-flip@b-edp1.html

  
#### Possible fixes ####

  * igt@kms_flip@basic-flip-vs-wf_vblank:
    - bat-adlp-7:         [DMESG-WARN][3] ([Intel XE#4543]) -> [PASS][4] +1 other test pass
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3336-94631e6b7f655b1922e3227970cd6180200694af/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151082v1/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank.html

  
  [Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543


Build changes
-------------

  * Linux: xe-3336-94631e6b7f655b1922e3227970cd6180200694af -> xe-pw-151082v1

  IGT_8434: 5185b9527673518a418d575c3f58b5554e27f111 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-3336-94631e6b7f655b1922e3227970cd6180200694af: 94631e6b7f655b1922e3227970cd6180200694af
  xe-pw-151082v1: 151082v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151082v1/index.html

[-- Attachment #2: Type: text/html, Size: 2641 bytes --]

Re: [PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume

[Rodrigo Vivi]

On Wed, Jul 02, 2025 at 10:22:13PM +0530, Badal Nilawar wrote:
> Reload late binding fw during resume from system suspend
> 
> v2:
>   - Unconditionally reload late binding fw (Rodrigo)
>   - Flush worker during system suspend
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_pm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 734fe259600e..13afaf97d831 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -127,6 +127,8 @@ int xe_pm_suspend(struct xe_device *xe)
>  	if (err)
>  		goto err;
>  
> +	xe_late_bind_wait_for_worker_completion(&xe->late_bind);
> +
>  	for_each_gt(gt, xe, id)
>  		xe_gt_suspend_prepare(gt);
>  
> @@ -205,6 +207,8 @@ int xe_pm_resume(struct xe_device *xe)
>  
>  	xe_pxp_pm_resume(xe->pxp);
>  
> +	xe_late_bind_fw_load(&xe->late_bind);
> +
>  	drm_dbg(&xe->drm, "Device resumed\n");
>  	return 0;
>  err:
> -- 
> 2.34.1
> 

Re: [PATCH v5 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume

[Rodrigo Vivi]

On Wed, Jul 02, 2025 at 10:22:12PM +0530, Badal Nilawar wrote:
> Reload late binding fw during runtime resume.
> 
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
> v5: Flush worker in rpm suspend is not needed any more as
>     xe_late_bind_fw_load gets the rpm ref before queuing worker
>     to ensure worker completes lb fw loading.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_late_bind_fw.c | 2 +-
>  drivers/gpu/drm/xe/xe_late_bind_fw.h | 1 +
>  drivers/gpu/drm/xe/xe_pm.c           | 4 ++++
>  3 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 56166816a535..3fb84d2f0a76 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -82,7 +82,7 @@ static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
>  		return 0;
>  }
>  
> -static void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
> +void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind)
>  {
>  	struct xe_device *xe = late_bind_to_xe(late_bind);
>  	struct xe_late_bind_fw *lbfw;
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.h b/drivers/gpu/drm/xe/xe_late_bind_fw.h
> index 28d56ed2bfdc..07e437390539 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.h
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.h
> @@ -12,5 +12,6 @@ struct xe_late_bind;
>  
>  int xe_late_bind_init(struct xe_late_bind *late_bind);
>  int xe_late_bind_fw_load(struct xe_late_bind *late_bind);
> +void xe_late_bind_wait_for_worker_completion(struct xe_late_bind *late_bind);
>  
>  #endif
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index ff749edc005b..734fe259600e 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -20,6 +20,7 @@
>  #include "xe_gt.h"
>  #include "xe_guc.h"
>  #include "xe_irq.h"
> +#include "xe_late_bind_fw.h"
>  #include "xe_pcode.h"
>  #include "xe_pxp.h"
>  #include "xe_trace.h"
> @@ -550,6 +551,9 @@ int xe_pm_runtime_resume(struct xe_device *xe)
>  
>  	xe_pxp_pm_resume(xe->pxp);
>  
> +	if (xe->d3cold.allowed)
> +		xe_late_bind_fw_load(&xe->late_bind);
> +
>  out:
>  	xe_rpm_lockmap_release(xe);
>  	xe_pm_write_callback_task(xe, NULL);
> -- 
> 2.34.1
> 

Re: [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

[Rodrigo Vivi]

On Wed, Jul 02, 2025 at 10:22:16PM +0530, Badal Nilawar wrote:
> Do not review

Why?

Why don't we add this dependency here?

> 
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>  drivers/gpu/drm/xe/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index f66e6d39e319..ef3f4807b0b3 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -45,6 +45,7 @@ config DRM_XE
>  	select WANT_DEV_COREDUMP
>  	select AUXILIARY_BUS
>  	select HMM_MIRROR
> +	select INTEL_MEI_LATE_BIND
>  	help
>  	  Driver for Intel Xe2 series GPUs and later. Experimental support
>  	  for Xe series is also available.
> -- 
> 2.34.1
> 

Re: [PATCH v5 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware

[Daniele Ceraolo Spurio]

On 7/2/2025 9:52 AM, Badal Nilawar wrote:
> Search for late binding firmware binaries and populate the meta data of
> firmware structures.
>
> v2 (Daniele):
>   - drm_err if firmware size is more than max pay load size
>   - s/request_firmware/firmware_request_nowarn/ as firmware will
>     not be available for all possible cards
> v3 (Daniele):
>   - init firmware from within xe_late_bind_init, propagate error
>   - switch late_bind_fw to array to handle multiple firmware types
> v4 (Daniele):
>   - Alloc payload dynamically, fix nits
>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_late_bind_fw.c       | 100 ++++++++++++++++++++-
>   drivers/gpu/drm/xe/xe_late_bind_fw_types.h |  30 +++++++
>   2 files changed, 129 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 22e79f0dbbdf..ca2370af3c27 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -5,6 +5,7 @@
>   
>   #include <linux/component.h>
>   #include <linux/delay.h>
> +#include <linux/firmware.h>
>   
>   #include <drm/drm_managed.h>
>   #include <drm/intel/i915_component.h>
> @@ -13,6 +14,16 @@
>   
>   #include "xe_device.h"
>   #include "xe_late_bind_fw.h"
> +#include "xe_pcode.h"
> +#include "xe_pcode_api.h"
> +
> +static const u32 fw_id_to_type[] = {
> +		[XE_LB_FW_FAN_CONTROL] = CSC_LATE_BINDING_TYPE_FAN_CONTROL,
> +	};
> +
> +static const char * const fw_id_to_name[] = {
> +		[XE_LB_FW_FAN_CONTROL] = "fan_control",
> +	};
>   
>   static struct xe_device *
>   late_bind_to_xe(struct xe_late_bind *late_bind)
> @@ -20,6 +31,89 @@ late_bind_to_xe(struct xe_late_bind *late_bind)
>   	return container_of(late_bind, struct xe_device, late_bind);
>   }
>   
> +static int xe_late_bind_fw_num_fans(struct xe_late_bind *late_bind)
> +{
> +	struct xe_device *xe = late_bind_to_xe(late_bind);
> +	struct xe_tile *root_tile = xe_device_get_root_tile(xe);
> +	u32 uval;
> +
> +	if (!xe_pcode_read(root_tile,
> +			   PCODE_MBOX(FAN_SPEED_CONTROL, FSC_READ_NUM_FANS, 0), &uval, NULL))
> +		return uval;
> +	else
> +		return 0;
> +}
> +
> +static int __xe_late_bind_fw_init(struct xe_late_bind *late_bind, u32 fw_id)
> +{
> +	struct xe_device *xe = late_bind_to_xe(late_bind);
> +	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
> +	struct xe_late_bind_fw *lb_fw;
> +	const struct firmware *fw;
> +	u32 num_fans;
> +	int ret;
> +
> +	if (fw_id >= XE_LB_FW_MAX_ID)
> +		return -EINVAL;
> +
> +	lb_fw = &late_bind->late_bind_fw[fw_id];
> +
> +	lb_fw->id = fw_id;
> +	lb_fw->type = fw_id_to_type[lb_fw->id];
> +	lb_fw->flags &= ~CSC_LATE_BINDING_FLAGS_IS_PERSISTENT;
> +
> +	if (lb_fw->type == CSC_LATE_BINDING_TYPE_FAN_CONTROL) {
> +		num_fans = xe_late_bind_fw_num_fans(late_bind);
> +		drm_dbg(&xe->drm, "Number of Fans: %d\n", num_fans);
> +		if (!num_fans)
> +			return 0;
> +	}
> +
> +	snprintf(lb_fw->blob_path, sizeof(lb_fw->blob_path), "xe/%s_8086_%04x_%04x_%04x.bin",
> +		 fw_id_to_name[lb_fw->id], pdev->device,
> +		 pdev->subsystem_vendor, pdev->subsystem_device);
> +
> +	drm_dbg(&xe->drm, "Request late binding firmware %s\n", lb_fw->blob_path);
> +	ret = firmware_request_nowarn(&fw, lb_fw->blob_path, xe->drm.dev);
> +	if (ret) {
> +		drm_dbg(&xe->drm, "%s late binding fw not available for current device",
> +			fw_id_to_name[lb_fw->id]);
> +		return 0;
> +	}
> +
> +	if (fw->size > MAX_PAYLOAD_SIZE) {
> +		drm_err(&xe->drm, "Firmware %s size %zu is larger than max pay load size %u\n",
> +			lb_fw->blob_path, fw->size, MAX_PAYLOAD_SIZE);
> +		release_firmware(fw);
> +		return -ENODATA;
> +	}
> +
> +	lb_fw->payload_size = fw->size;
> +	lb_fw->payload = drmm_kzalloc(&xe->drm, lb_fw->payload_size, GFP_KERNEL);
> +	if (!lb_fw->payload) {
> +		release_firmware(fw);
> +		return -ENOMEM;
> +	}
> +
> +	memcpy((void *)lb_fw->payload, fw->data, lb_fw->payload_size);
> +	release_firmware(fw);
> +
> +	return 0;
> +}
> +
> +static int xe_late_bind_fw_init(struct xe_late_bind *late_bind)
> +{
> +	int ret;
> +	int fw_id;
> +
> +	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
> +		ret = __xe_late_bind_fw_init(late_bind, fw_id);
> +		if (ret)
> +			return ret;
> +	}
> +	return 0;
> +}
> +
>   static int xe_late_bind_component_bind(struct device *xe_kdev,
>   				       struct device *mei_kdev, void *data)
>   {
> @@ -79,5 +173,9 @@ int xe_late_bind_init(struct xe_late_bind *late_bind)
>   		return err;
>   	}
>   
> -	return devm_add_action_or_reset(xe->drm.dev, xe_late_bind_remove, late_bind);
> +	err = devm_add_action_or_reset(xe->drm.dev, xe_late_bind_remove, late_bind);
> +	if (err)
> +		return err;
> +
> +	return xe_late_bind_fw_init(late_bind);
>   }
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
> index 9806d17291ad..7d5dcb28b784 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
> @@ -10,6 +10,34 @@
>   #include <linux/mutex.h>
>   #include <linux/types.h>
>   
> +#define MAX_PAYLOAD_SIZE SZ_4K

Sorry I didn't realize it earlier, but this is in a header so it needs a 
prefix to avoid clashes, something like XE_LB_MAX_PAYLOAD_SIZE. I'm ok 
if you fix that when merging. With that:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> +
> +/**
> + * xe_late_bind_fw_id - enum to determine late binding fw index
> + */
> +enum xe_late_bind_fw_id {
> +	XE_LB_FW_FAN_CONTROL = 0,
> +	XE_LB_FW_MAX_ID
> +};
> +
> +/**
> + * struct xe_late_bind_fw
> + */
> +struct xe_late_bind_fw {
> +	/** @late_bind_fw.id: firmware index */
> +	u32 id;
> +	/** @late_bind_fw.blob_path: firmware binary path */
> +	char blob_path[PATH_MAX];
> +	/** @late_bind_fw.type: firmware type */
> +	u32  type;
> +	/** @late_bind_fw.flags: firmware flags */
> +	u32  flags;
> +	/** @late_bind_fw.payload: to store the late binding blob */
> +	const u8  *payload;
> +	/** @late_bind_fw.payload_size: late binding blob payload_size */
> +	size_t payload_size;
> +};
> +
>   /**
>    * struct xe_late_bind_component - Late Binding services component
>    * @mei_dev: device that provide Late Binding service.
> @@ -30,6 +58,8 @@ struct xe_late_bind_component {
>   struct xe_late_bind {
>   	/** @late_bind.component: struct for communication with mei component */
>   	struct xe_late_bind_component component;
> +	/** @late_bind.late_bind_fw: late binding firmware array */
> +	struct xe_late_bind_fw late_bind_fw[XE_LB_FW_MAX_ID];
>   };
>   
>   #endif

Re: [PATCH v5 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding

[Daniele Ceraolo Spurio]

On 7/2/2025 9:52 AM, Badal Nilawar wrote:
> Introduce a debug filesystem node to disable late binding fw reload
> during the system or runtime resume. This is intended for situations
> where the late binding fw needs to be loaded from user mode,
> perticularly for validation purpose.
> Note that xe kmd doesn't participate in late binding flow from user
> space. Binary loaded from the userspace will be lost upon entering to
> D3 cold hence user space app need to handle this situation.
>
> v2:
>    - s/(uval == 1) ? true : false/!!uval/ (Daniele)
> v3:
>    - Refine the commit message (Daniele)
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/xe/xe_debugfs.c            | 41 ++++++++++++++++++++++
>   drivers/gpu/drm/xe/xe_late_bind_fw.c       |  3 ++
>   drivers/gpu/drm/xe/xe_late_bind_fw_types.h |  2 ++
>   3 files changed, 46 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
> index d83cd6ed3fa8..d1f6f556efa2 100644
> --- a/drivers/gpu/drm/xe/xe_debugfs.c
> +++ b/drivers/gpu/drm/xe/xe_debugfs.c
> @@ -226,6 +226,44 @@ static const struct file_operations atomic_svm_timeslice_ms_fops = {
>   	.write = atomic_svm_timeslice_ms_set,
>   };
>   
> +static ssize_t disable_late_binding_show(struct file *f, char __user *ubuf,
> +					 size_t size, loff_t *pos)
> +{
> +	struct xe_device *xe = file_inode(f)->i_private;
> +	struct xe_late_bind *late_bind = &xe->late_bind;
> +	char buf[32];
> +	int len;
> +
> +	len = scnprintf(buf, sizeof(buf), "%d\n", late_bind->disable);
> +
> +	return simple_read_from_buffer(ubuf, size, pos, buf, len);
> +}
> +
> +static ssize_t disable_late_binding_set(struct file *f, const char __user *ubuf,
> +					size_t size, loff_t *pos)
> +{
> +	struct xe_device *xe = file_inode(f)->i_private;
> +	struct xe_late_bind *late_bind = &xe->late_bind;
> +	u32 uval;
> +	ssize_t ret;
> +
> +	ret = kstrtouint_from_user(ubuf, size, sizeof(uval), &uval);
> +	if (ret)
> +		return ret;
> +
> +	if (uval > 1)
> +		return -EINVAL;
> +
> +	late_bind->disable = !!uval;
> +	return size;
> +}
> +
> +static const struct file_operations disable_late_binding_fops = {
> +	.owner = THIS_MODULE,
> +	.read = disable_late_binding_show,
> +	.write = disable_late_binding_set,
> +};
> +
>   void xe_debugfs_register(struct xe_device *xe)
>   {
>   	struct ttm_device *bdev = &xe->ttm;
> @@ -249,6 +287,9 @@ void xe_debugfs_register(struct xe_device *xe)
>   	debugfs_create_file("atomic_svm_timeslice_ms", 0600, root, xe,
>   			    &atomic_svm_timeslice_ms_fops);
>   
> +	debugfs_create_file("disable_late_binding", 0600, root, xe,
> +			    &disable_late_binding_fops);
> +
>   	for (mem_type = XE_PL_VRAM0; mem_type <= XE_PL_VRAM1; ++mem_type) {
>   		man = ttm_manager_type(bdev, mem_type);
>   
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 3fb84d2f0a76..f6acf535bebc 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -158,6 +158,9 @@ int xe_late_bind_fw_load(struct xe_late_bind *late_bind)
>   	if (!late_bind->component_added)
>   		return -ENODEV;
>   
> +	if (late_bind->disable)
> +		return 0;
> +
>   	for (fw_id = 0; fw_id < XE_LB_FW_MAX_ID; fw_id++) {
>   		lbfw = &late_bind->late_bind_fw[fw_id];
>   		if (lbfw->payload) {
> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
> index 0ed98f236f2a..9a7fd07bf122 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw_types.h
> @@ -67,6 +67,8 @@ struct xe_late_bind {
>   	struct workqueue_struct *wq;
>   	/** @late_bind.component_added: whether the component has been added */
>   	bool component_added;
> +	/** @late_bind.disable to block late binding reload during pm resume flow*/
> +	bool disable;
>   };
>   
>   #endif

Re: [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI

[Daniele Ceraolo Spurio]

On 7/2/2025 2:48 PM, Rodrigo Vivi wrote:
> On Wed, Jul 02, 2025 at 10:22:16PM +0530, Badal Nilawar wrote:
>> Do not review
> Why?
>
> Why don't we add this dependency here?

For INTEL_MEI_LATE_BIND to work we also need  INTEL_MEI_GSC, which is 
the config for the mei child device and depends on the config for our 
driver, so a "depends on" tag would go circular.
INTEL_MEI_GSC also has further dependencies, so if we wanted to "select" 
it (instead of marking it with a "depends on") we'd have to select those 
dependencies as well, which doesn't scale well.
This patch only works as-is because our CI config does enable 
INTEL_MEI_GSC with all its dependencies.

For other mei components (e.g. PXP, HDCP) what we did was notify the 
distros that they had to enable the option in their kernel builds if 
they wanted the feature to be enabled, so the idea was to do the same here.

Unless there is a kconfig trick we're missing that would make this work?

Daniele

>
>> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
>> ---
>>   drivers/gpu/drm/xe/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>> index f66e6d39e319..ef3f4807b0b3 100644
>> --- a/drivers/gpu/drm/xe/Kconfig
>> +++ b/drivers/gpu/drm/xe/Kconfig
>> @@ -45,6 +45,7 @@ config DRM_XE
>>   	select WANT_DEV_COREDUMP
>>   	select AUXILIARY_BUS
>>   	select HMM_MIRROR
>> +	select INTEL_MEI_LATE_BIND
>>   	help
>>   	  Driver for Intel Xe2 series GPUs and later. Experimental support
>>   	  for Xe series is also available.
>> -- 
>> 2.34.1
>>

✗ Xe.CI.Full: failure for Introducing firmware late binding

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

== Series Details ==

Series: Introducing firmware late binding
URL   : https://patchwork.freedesktop.org/series/151082/
State : failure

== Summary ==

ERROR: The runconfig 'xe-3336-94631e6b7f655b1922e3227970cd6180200694af_FULL' does not exist in the database

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-151082v1/index.html

[-- Attachment #2: Type: text/html, Size: 929 bytes --]