Re: ✗ CI.checkpatch: warning for drm/xe: i2c support (rev6)

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Jul 01, 2025 at 12:28:36PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/xe: i2c support (rev6)
> URL   : https://patchwork.freedesktop.org/series/149699/
> State : warning
> 
> == Summary ==
> 
> + KERNEL=/kernel
> + git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
> Cloning into 'mt'...
> warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
> + git -C mt rev-list -n1 origin/master
> f8ff75ae1d2127635239b134695774ed4045d05b
> + cd /kernel
> + git config --global --add safe.directory /kernel
> + git log -n1
> commit 1fc9fee6df0e31f875d061c04a10c6a9b0abfe0b
> Author: Riana Tauro <riana.tauro@intel.com>
> Date:   Tue Jul 1 15:22:52 2025 +0300
> 
>     drm/xe/xe_i2c: Add support for i2c in survivability mode
>     
>     Initialize i2c in survivability mode to allow firmware
>     update of Add-In Management Controller (AMC) in
>     survivability mode.
>     
>     Signed-off-by: Riana Tauro <riana.tauro@intel.com>
>     Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>     Reviewed-by: Raag Jadav <raag.jadav@intel.com>
>     Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> + /mt/dim checkpatch 9f3690735949ad5f24ece89cf2e91c2750ea580f drm-intel
> cf5044118b7c i2c: designware: Use polling by default when there is no irq resource
> ca9127e99159 i2c: designware: Add quirk for Intel Xe
> -:9: WARNING:BAD_SIGN_OFF: Non-standard signature: Originally-by:
> #9: 
> Originally-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> 
> total: 0 errors, 1 warnings, 0 checks, 24 lines checked
> acd550ef8110 drm/xe: Support for I2C attached MCUs
> -:14: WARNING:BAD_SIGN_OFF: Non-standard signature: Originally-by:
> #14: 
> Originally-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> 
> -:44: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
> #44: 
> new file mode 100644
> 
> -:153: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/xe/xe_i2c.c', please use '//' instead
> #153: FILE: drivers/gpu/drm/xe/xe_i2c.c:1:
> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */

Could you please fix this and resend?

It should be
// SPDX-License-Identifier: GPL-2.0 OR MIT

in .c

/**/ is correct in .h

> 
> -:153: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
> #153: FILE: drivers/gpu/drm/xe/xe_i2c.c:1:
> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */

Here as well...

> 
> total: 0 errors, 4 warnings, 0 checks, 457 lines checked
> d4c211f8d91b drm/xe/pm: Wire up suspend/resume for I2C controller
> 1fc9fee6df0e drm/xe/xe_i2c: Add support for i2c in survivability mode
> 
>