Re: [PATCH 1/2] drm/xe: Extract xe_bo_is_visible_vram

[Francois Dugast <francois.dugast@intel.com>]

On Fri, Jun 27, 2025 at 05:13:09PM +0200, Maarten Lankhorst wrote:
> This will make it possible to call from xe_display code.
> 
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_bo.c | 10 +++++++++-
>  drivers/gpu/drm/xe/xe_bo.h |  1 +
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index 4e39188a021ab..af312bc70d0fe 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -557,6 +557,14 @@ static bool xe_ttm_resource_visible(struct ttm_resource *mem)
>  	return vres->used_visible_size == mem->size;
>  }
>  
> +bool xe_bo_is_visible_vram(struct xe_bo *bo)
> +{
> +	if (drm_WARN_ON(bo->ttm.base.dev, !xe_bo_is_vram(bo)))
> +		return false;
> +
> +	return xe_ttm_resource_visible(bo->ttm.resource);
> +}
> +
>  static int xe_ttm_io_mem_reserve(struct ttm_device *bdev,
>  				 struct ttm_resource *mem)
>  {
> @@ -1547,7 +1555,7 @@ static int xe_ttm_access_memory(struct ttm_buffer_object *ttm_bo,
>  	if (!mem_type_is_vram(ttm_bo->resource->mem_type))
>  		return -EIO;
>  
> -	if (!xe_ttm_resource_visible(ttm_bo->resource) || len >= SZ_16K) {
> +	if (!xe_bo_is_visible_vram(bo) || len >= SZ_16K) {
>  		struct xe_migrate *migrate =
>  			mem_type_to_migrate(xe, ttm_bo->resource->mem_type);
>  
> diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
> index 02ada1fb8a235..460cfc309eec2 100644
> --- a/drivers/gpu/drm/xe/xe_bo.h
> +++ b/drivers/gpu/drm/xe/xe_bo.h
> @@ -265,6 +265,7 @@ int xe_bo_read(struct xe_bo *bo, u64 offset, void *dst, int size);
>  
>  bool mem_type_is_vram(u32 mem_type);
>  bool xe_bo_is_vram(struct xe_bo *bo);
> +bool xe_bo_is_visible_vram(struct xe_bo *bo);
>  bool xe_bo_is_stolen(struct xe_bo *bo);
>  bool xe_bo_is_stolen_devmem(struct xe_bo *bo);
>  bool xe_bo_is_vm_bound(struct xe_bo *bo);
> -- 
> 2.45.2
>