intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: Remove references to CONFIG_DRM_XE_DEVMEM_MIRROR
Date: Thu, 10 Jul 2025 17:29:27 -0400	[thread overview]
Message-ID: <aHAwt7pfSBG3Q7F0@intel.com> (raw)
In-Reply-To: <20250710205413.1105595-1-matthew.brost@intel.com>

On Thu, Jul 10, 2025 at 01:54:13PM -0700, Matthew Brost wrote:
> The prefetch code was referencing CONFIG_DRM_XE_DEVMEM_MIRROR, which has
> been replaced by CONFIG_DRM_XE_PAGEMAP. As a result, prefetches were
> limited to SRAM. Update the code to use CONFIG_DRM_XE_PAGEMAP instead of
> the deprecated option.
> 
> Fixes: f86ad0ed620c ("drm/gpusvm, drm/pagemap: Move migration functionality to drm_pagemap")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index e875ea4658a9..2035604121e6 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2380,7 +2380,7 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
>  
>  			ctx.read_only = xe_vma_read_only(vma);
>  			ctx.devmem_possible = IS_DGFX(vm->xe) &&
> -					      IS_ENABLED(CONFIG_DRM_XE_DEVMEM_MIRROR);
> +					      IS_ENABLED(CONFIG_DRM_XE_PAGEMAP);
>  
>  			for_each_tile(tile, vm->xe, id)
>  				tile_mask |= 0x1 << id;
> @@ -2887,7 +2887,7 @@ static int check_ufence(struct xe_vma *vma)
>  
>  static int prefetch_ranges(struct xe_vm *vm, struct xe_vma_op *op)
>  {
> -	bool devmem_possible = IS_DGFX(vm->xe) && IS_ENABLED(CONFIG_DRM_XE_DEVMEM_MIRROR);
> +	bool devmem_possible = IS_DGFX(vm->xe) && IS_ENABLED(CONFIG_DRM_XE_PAGEMAP);
>  	struct xe_vma *vma = gpuva_to_vma(op->base.prefetch.va);
>  	int err = 0;
>  
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2025-07-10 21:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 20:54 [PATCH] drm/xe: Remove references to CONFIG_DRM_XE_DEVMEM_MIRROR Matthew Brost
2025-07-10 21:19 ` Cavitt, Jonathan
2025-07-10 21:22   ` Matthew Brost
2025-07-14 15:52     ` Lucas De Marchi
2025-07-14 17:53       ` Michal Wajdeczko
2025-07-10 21:29 ` Rodrigo Vivi [this message]
2025-07-10 22:52 ` ✓ CI.KUnit: success for " Patchwork
2025-07-10 23:39 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-11  8:13 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHAwt7pfSBG3Q7F0@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).