From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lukasz Laguna <lukasz.laguna@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <michal.wajdeczko@intel.com>
Subject: Re: [PATCH] drm/xe/vf: Don't register I2C devices if VF
Date: Thu, 17 Jul 2025 15:49:32 -0400 [thread overview]
Message-ID: <aHlTzHHzxlW-YUU6@intel.com> (raw)
In-Reply-To: <20250717155420.25298-1-lukasz.laguna@intel.com>
On Thu, Jul 17, 2025 at 05:54:20PM +0200, Lukasz Laguna wrote:
> VF drivers can't access I2C devices, so skip their registration when
> running as VF.
>
Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
pushing soon, thanks for the patch.
> Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
> ---
> drivers/gpu/drm/xe/xe_i2c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> index 1f19718db559..bc7dc2099470 100644
> --- a/drivers/gpu/drm/xe/xe_i2c.c
> +++ b/drivers/gpu/drm/xe/xe_i2c.c
> @@ -283,6 +283,9 @@ int xe_i2c_probe(struct xe_device *xe)
> if (xe->info.platform != XE_BATTLEMAGE)
> return 0;
>
> + if (IS_SRIOV_VF(xe))
> + return 0;
> +
> xe_i2c_read_endpoint(xe_root_tile_mmio(xe), &ep);
> if (ep.cookie != XE_I2C_EP_COOKIE_DEVICE)
> return 0;
> --
> 2.40.0
>
next prev parent reply other threads:[~2025-07-17 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 15:54 [PATCH] drm/xe/vf: Don't register I2C devices if VF Lukasz Laguna
2025-07-17 16:53 ` ✓ CI.KUnit: success for " Patchwork
2025-07-17 18:12 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-17 19:49 ` Rodrigo Vivi [this message]
2025-07-19 3:30 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHlTzHHzxlW-YUU6@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lukasz.laguna@intel.com \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox