From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/xe: fix stale comment about unordered_wq usage
Date: Fri, 1 Aug 2025 17:08:49 -0400 [thread overview]
Message-ID: <aI0s4dq8rpw3hyZu@intel.com> (raw)
In-Reply-To: <133ec65ccd361b81193e7f5d8ef4d4854b0e89b1@intel.com>
On Fri, Aug 01, 2025 at 12:28:05PM +0300, Jani Nikula wrote:
> On Thu, 31 Jul 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> > Display has switched to its own workqueue, no longer using
> > xe->unordered_wq.
>
> Lucas, Rodrigo, the change was done in 7c377900772d ("drm/i915/display:
> move unordered works to new private workqueue"), which is in drm-next
> and Linus' upstream but not in drm-xe-next yet. It's a minor detail, but
> do you care if this patch gets merged to xe before the backmerge with
> that?
I don't have any issue myself with cherry-picking that to avoid us having to
wait couple weeks until we reconcile the branches, if that is needed to
unblock any of your display clean-ups.
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> BR,
> Jani.
>
>
> >
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/xe/xe_device_types.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> > index 38c8329b4d2c..01e8fa0d2f9f 100644
> > --- a/drivers/gpu/drm/xe/xe_device_types.h
> > +++ b/drivers/gpu/drm/xe/xe_device_types.h
> > @@ -427,7 +427,7 @@ struct xe_device {
> > /** @ordered_wq: used to serialize compute mode resume */
> > struct workqueue_struct *ordered_wq;
> >
> > - /** @unordered_wq: used to serialize unordered work, mostly display */
> > + /** @unordered_wq: used to serialize unordered work */
> > struct workqueue_struct *unordered_wq;
> >
> > /** @destroy_wq: used to serialize user destroy work, like queue */
>
> --
> Jani Nikula, Intel
prev parent reply other threads:[~2025-08-01 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 11:12 [PATCH] drm/xe: fix stale comment about unordered_wq usage Jani Nikula
2025-07-31 12:25 ` Gustavo Sousa
2025-07-31 14:00 ` ✓ CI.KUnit: success for " Patchwork
2025-07-31 15:30 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-31 17:26 ` ✓ Xe.CI.Full: " Patchwork
2025-08-01 9:28 ` [PATCH] " Jani Nikula
2025-08-01 21:08 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aI0s4dq8rpw3hyZu@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox