From: Imre Deak <imre.deak@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>,
<dri-devel@lists.freedesktop.org>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory
Date: Mon, 28 Jul 2025 13:22:19 +0300 [thread overview]
Message-ID: <aIdPW1a5OgTlHweN@ideak-desk> (raw)
In-Reply-To: <aIPES8pWAdCVB07L@finisterre.sirena.org.uk>
On Fri, Jul 25, 2025 at 06:52:11PM +0100, Mark Brown wrote:
> On Fri, Jul 25, 2025 at 05:23:36PM +0300, Imre Deak wrote:
> > On Fri, Jul 25, 2025 at 02:36:31PM +0100, Mark Brown wrote:
>
> > > This regression is still present in today's -next, I've not seen any
> > > response to my report?
>
> > Looks like the following would fix it, could you give it a go?:
>
> Yes, that seems to do the trick thanks!
>
> Tested-by: Mark Brown <broonie@kernel.org>
Ok, thanks for testing it. I realized that it's better to fix this
aligning with the conversion for the rest of the drivers in the original
[1] patchset, could you still give a try if the corresponding patch [2]
also fixes the issue for you?
Thanks,
Imre
[1] https://lore.kernel.org/all/20250701090722.13645-1-ville.syrjala@linux.intel.com
[2] https://lore.kernel.org/all/20250728101603.243788-2-imre.deak@intel.com
next prev parent reply other threads:[~2025-07-28 10:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:07 [PATCH v2 00/19] drm: Eliminate redundant drm_format_info lookups Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 01/19] drm: Pass pixel_format+modifier to .get_format_info() Ville Syrjala
2025-07-01 18:49 ` Laurent Pinchart
2025-07-01 9:07 ` [PATCH v2 02/19] drm: Pass pixel_format+modifier directly to drm_get_format_info() Ville Syrjala
2025-07-01 16:31 ` Liviu Dudau
2025-07-01 9:07 ` [PATCH v2 03/19] drm: Look up the format info earlier Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 04/19] drm: Pass the format info to .fb_create() Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 05/19] drm: Allow the caller to pass in the format info to drm_helper_mode_fill_fb_struct() Ville Syrjala
2025-07-01 11:05 ` Dmitry Baryshkov
2025-07-01 16:41 ` Liviu Dudau
2025-07-01 9:07 ` [PATCH v2 06/19] drm/malidp: Pass along the format info from .fb_create() malidp_verify_afbc_framebuffer_size() Ville Syrjala
2025-07-01 16:45 ` Liviu Dudau
2025-07-01 9:07 ` [PATCH v2 07/19] drm/gem: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct() Ville Syrjala
2025-07-01 19:20 ` Laurent Pinchart
2025-07-01 9:07 ` [PATCH v2 08/19] drm/gem/afbc: Eliminate redundant drm_get_format_info() Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 09/19] drm/amdgpu: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct() Ville Syrjala
2025-07-15 18:25 ` Deucher, Alexander
2025-07-01 9:07 ` [PATCH v2 10/19] drm/armada: " Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 11/19] drm/exynos: " Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 12/19] drm/gma500: " Ville Syrjala
2025-07-02 5:28 ` Patrik Jakobsson
2025-07-01 9:07 ` [PATCH v2 13/19] drm/i915: " Ville Syrjala
2025-07-15 19:32 ` Rodrigo Vivi
2025-07-01 9:07 ` [PATCH v2 14/19] drm/komeda: " Ville Syrjala
2025-07-01 16:46 ` Liviu Dudau
2025-07-01 9:07 ` [PATCH v2 15/19] drm/msm: " Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 16/19] drm/tegra: " Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 17/19] drm/virtio: " Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 18/19] drm/vmwgfx: " Ville Syrjala
2025-07-01 9:07 ` [PATCH v2 19/19] drm: Make passing of format info to drm_helper_mode_fill_fb_struct() mandatory Ville Syrjala
2025-07-22 13:41 ` Mark Brown
2025-07-25 13:36 ` Mark Brown
2025-07-25 14:23 ` Imre Deak
2025-07-25 17:52 ` Mark Brown
2025-07-28 10:22 ` Imre Deak [this message]
2025-08-12 21:33 ` Timur Tabi
2025-08-13 8:05 ` Imre Deak
2025-08-13 19:25 ` Timur Tabi
2025-07-01 10:29 ` ✗ CI.checkpatch: warning for drm: Eliminate redundant drm_format_info lookups (rev7) Patchwork
2025-07-01 10:30 ` ✓ CI.KUnit: success " Patchwork
2025-07-01 10:45 ` ✗ CI.checksparse: warning " Patchwork
2025-07-01 11:11 ` ✓ Xe.CI.BAT: success " Patchwork
2025-07-16 18:22 ` [PATCH v2 00/19] drm: Eliminate redundant drm_format_info lookups Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIdPW1a5OgTlHweN@ideak-desk \
--to=imre.deak@intel.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox