Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: [PATCH v2 2/2] drm/xe: Re-register CCS save/restore contexts post S3/S4 resume
Date: Mon, 4 Aug 2025 20:13:03 -0700	[thread overview]
Message-ID: <aJF2v4/m8yrKgiqf@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20250801132441.25463-3-satyanarayana.k.v.p@intel.com>

On Fri, Aug 01, 2025 at 06:54:41PM +0530, Satyanarayana K V P wrote:
> After resuming from S3/S4 states, QEMU issues a VF FLR which resets GuC
> communication, causing the loss of registered CCS save/restore contexts
> with GUC.
> 
> VM migration post-resume leads to data corruption since the GuC cannot
> save CCS metadata without these contexts.
> 
> Re-register the CCS save/restore contexts with the GuC after S3/S4 resume
> to resolve the issue.
> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> 

I'd just squash this one into the previous patch as functionality would
be broken without this patch.

Code changes lgtm though.

Matt 

> ---
> V1 -> V2:
> - Added commit in V2 version.
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 44aaf154ddf7..5e8126ca8e27 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -209,6 +209,9 @@ int xe_pm_resume(struct xe_device *xe)
>  
>  	xe_pxp_pm_resume(xe->pxp);
>  
> +	if (IS_SRIOV_VF(xe))
> +		xe_sriov_vf_ccs_register_context(xe);
> +
>  	drm_dbg(&xe->drm, "Device resumed\n");
>  	return 0;
>  err:
> -- 
> 2.43.0
> 

  reply	other threads:[~2025-08-05  3:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 13:24 [PATCH v2 0/2] Improve CCS save restore series Satyanarayana K V P
2025-08-01 13:14 ` ✓ CI.KUnit: success for Improve CCS save restore series (rev2) Patchwork
2025-08-01 13:24 ` [PATCH v2 1/2] drm/xe/vf: Refactor CCS save/restore to use default migration context Satyanarayana K V P
2025-08-05  3:11   ` Matthew Brost
2025-08-01 13:24 ` [PATCH v2 2/2] drm/xe: Re-register CCS save/restore contexts post S3/S4 resume Satyanarayana K V P
2025-08-05  3:13   ` Matthew Brost [this message]
2025-08-01 14:17 ` ✓ Xe.CI.BAT: success for Improve CCS save restore series (rev2) Patchwork
2025-08-01 15:21 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJF2v4/m8yrKgiqf@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=satyanarayana.k.v.p@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox