From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 503C7CA0FED for ; Wed, 27 Aug 2025 14:39:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1327A10E11C; Wed, 27 Aug 2025 14:39:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="X9fKmB5i"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03CD310E11C for ; Wed, 27 Aug 2025 14:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756305582; x=1787841582; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=d4I6fp+pzueZ2ImH7ZaE+YNnPFL9R02hZxjkjFKMXzs=; b=X9fKmB5iOLnPqCCn3+9eA3kkqcxKnHasZdfs8Yu6J8zhSFzlQ+8EroTg 3K1SiPX61+7aSeJihTJ2PtU/6c1in/mKj1Pw3g2UU5onQx5ec36aJ/RED DLuPbIAG/ISc1VOk4AbBH5YmuScG4DyRoQRd73fZVCfrY3J+b6hPzZOCk e6Z6PHLRoRIgZGEJ3j4/+p482DiClV8CaN8KHKnB5xucbv1BjOE9K4XaK ux8AlYeOPZk48BYBsGUM/pD9jzbTy888SCp1Ggm/tD67z1MofzjKGX+82 zAkgcBM8P3TzJ+SPVGPBgXgJwwFUX6bltH85WeHjYwYrfqEb+5Ul84VXN Q==; X-CSE-ConnectionGUID: hZnKcK6FTZO2yT6SNU0lwg== X-CSE-MsgGUID: QKR8rmf0TFSYdGnZVuFtOQ== X-IronPort-AV: E=McAfee;i="6800,10657,11535"; a="57577639" X-IronPort-AV: E=Sophos;i="6.18,214,1751266800"; d="scan'208";a="57577639" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2025 07:39:27 -0700 X-CSE-ConnectionGUID: WPq2elNBSIqJXLgtO+uDnA== X-CSE-MsgGUID: TzaP4oyRRXCX1Q6zHqsoxA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,214,1751266800"; d="scan'208";a="193510768" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Aug 2025 07:39:27 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 27 Aug 2025 07:39:26 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Wed, 27 Aug 2025 07:39:26 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (40.107.244.69) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 27 Aug 2025 07:39:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m4HO55yotn6GalreX9Ejmu+C3+73bw3fIycqXe/k84kOCeOhNvQr64k57HsGYBMbXUTzsodfNi65acNhreAR9lxfieuP/KAeAIq7nTRBljyAae86xL5qLHdfIPIW0ZSkMj0I46PIMvqxbdlgp4KUzYLyw0TU0x+NTGl4448AH1Yowg1cCwF7Kl1LgCVbgUIvLePLvrH5LSrYrJMhqLvL9JwstCNB2kcDdjJqU+xjY2K2mhRdg6VOGtGGoaAmAai5xBf+ZLcJCshUVAE6jLeXtRvt+LDA+yGfn0LsOmMlxDg25hU5hkAWAr/47ACmc5Ajk39vI3ViXZ73ZQCCcQbaag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KNNfqrtCaEiyz0orTd98f57r63U+SSGkiyJTieQ50vU=; b=YJT6bTaSjGJbNrJeosa/OIFCvT/kutO2BaaDm6cdK37qAn7GbDkD953w6cKhuqaRgib92nX6y9axCozfdHDYRoFFUQPKl+3vDo/WbdHiEJmd4DiKP268YASThioS5WtlBp/DqGX1EZ5FnZSLp6hABIC62YD6GUh1yxfZYJBDjB8KE6rUrrizb+qSiV/Im3PFKRjV9uzNXiElEJ1iDS4dPTbgGW+Rzy9GHsgN2UqJhmGrOnc2DmkozhsQGs7Ibyx3HpdnM/4LJli/8WQqhvBJhJOprktvp5809otlnA1m5RfA5UVXov3xwAJ4nbgv+VRfmVvN3nU5lBXuoMX5124HbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CYYPR11MB8430.namprd11.prod.outlook.com (2603:10b6:930:c6::19) by DM6PR11MB4548.namprd11.prod.outlook.com (2603:10b6:5:2ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9031.23; Wed, 27 Aug 2025 14:39:24 +0000 Received: from CYYPR11MB8430.namprd11.prod.outlook.com ([fe80::76d2:8036:2c6b:7563]) by CYYPR11MB8430.namprd11.prod.outlook.com ([fe80::76d2:8036:2c6b:7563%6]) with mapi id 15.20.9052.013; Wed, 27 Aug 2025 14:39:24 +0000 Date: Wed, 27 Aug 2025 10:39:20 -0400 From: Rodrigo Vivi To: Tvrtko Ursulin CC: , Subject: Re: [PATCH v11 02/13] drm/xe/xelp: Quiesce memory traffic before invalidating auxccs Message-ID: References: <20250821141458.72876-1-tvrtko.ursulin@igalia.com> <20250821141458.72876-3-tvrtko.ursulin@igalia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250821141458.72876-3-tvrtko.ursulin@igalia.com> X-ClientProxiedBy: SJ0PR03CA0116.namprd03.prod.outlook.com (2603:10b6:a03:333::31) To CYYPR11MB8430.namprd11.prod.outlook.com (2603:10b6:930:c6::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYYPR11MB8430:EE_|DM6PR11MB4548:EE_ X-MS-Office365-Filtering-Correlation-Id: 79b4adb5-c812-4053-a01b-08dde577842e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9ijO8LGheMmV4G+7cRzXjryMrEep5glGqwhUwdNsx3riPPg8iTjyTDcoGL6Z?= =?us-ascii?Q?mJg/rUjTnv22sXt57FSKz/01PHpOHIQmSVgiWdhtPatqkVaf4ejWFmjWsMOg?= =?us-ascii?Q?peo04ogX33rqdEdsaFNgKsF7/bfKjIhsowFV7FzVgglhg5EJgBycnwg2i8X1?= =?us-ascii?Q?vXozR5Xl0hStHXJZj5Q0mTokMljixr2gtYl6OnHowEkDxWLXnw0ca5xzBoVk?= =?us-ascii?Q?5HDXVQg1+WxCWs+IcDxTMlfXRlEU9Rs2AdJnq7MLrCYZq29E2aXXl4FXu6n5?= =?us-ascii?Q?LfQyYdhWwszoUmmig0VK+1JqIGCPf6OLpnqRh+mhan5pTNzEUt78c8Dngqty?= =?us-ascii?Q?MuCoYURHm9Y0fWxxus+kEwVenxDul6s8zZdyCj1zVWzKsz7duUXigujZHlHE?= =?us-ascii?Q?1g5VvAqqSFIL2i6U3382bJiT2f1ZhYEmyQo5xme9OOQmGKhxrHBjylIHzhtE?= =?us-ascii?Q?KuzEjZdxxbGr29k4VK/TKSrIJE3x/eI+6ObUe0kjb0aots9ODpqOTIU8caMC?= =?us-ascii?Q?uX2PnkxIGLE9TSP6SNP+OLabF8ObVRPhBn3WwjL3Jn+YTLBmBYPGzdN7yZWn?= =?us-ascii?Q?jVWPzZEzU+L/nfnpmikXjuPL7vnz9OUYX3TmQgC7804WmR1ohqN/euCGH2M1?= =?us-ascii?Q?a674YuVxwuxHRN04HqX+AvM3DiOp7wYbsL2v4QiIaOWfay/fVwYkPpBQU6IJ?= =?us-ascii?Q?asqRcsJkPJNEcdk8pUqXlUvb8suNlZifrnfIlxpyNgG1WAkXwC+ztAI1ctxR?= =?us-ascii?Q?56HFUwrwLBZY1tvZU0LhBUJA/x5/1JmjXPkrr8AgkPD6LPB8GIA0S3LbtFeF?= =?us-ascii?Q?ADT9+BqY+u3GgM9+zsOq3xU1nF9p4MTwcDheuD6mA6v82yjwT4ogHRS8jwRp?= =?us-ascii?Q?KtIa+7C77lExlIRNODqWWnUetrLDZ45CY/lbVU1Tp7kWtNhU+ZFJXFsTtMdK?= =?us-ascii?Q?Gozycu7diAcjqJcjhxBeZZvngaw2MiXVVWUum6fKWXI5oBmlYE6fkWapCihI?= =?us-ascii?Q?mKsvm31g3vieyWDaweZ0R0k/J+1A/mEWvoh3S07mA/u13JzVN0Pf+6TDQriV?= =?us-ascii?Q?KXWRr/B3ZdN2VsvxPN0KCkvAq41KvVwHOwMExUE2bobVVDHL2zb91Yd/GDWH?= =?us-ascii?Q?EQ4g+EK4UGzNPu9QkGOSJygzdhj7wxMLUh4ikCadVQ0Vn/iTZ+dEgo1wqA3x?= =?us-ascii?Q?oMLsIjYCq3Q5tcijeQqcilLG8d198ajQyOD0O4nkH7vzXJd43v/yr+VTKdLB?= =?us-ascii?Q?cKXbq3AqsFoOblcKqKqpn9COf9Op5wKcgjcJ5QRu4Z4nS2sSHP8ba28Tarnw?= =?us-ascii?Q?KuZ6isGIrLgV5NWU0HDw/SI0VRxQSbhEW/zsOv6oVN9ieDRUFQiTAMX2sqtQ?= =?us-ascii?Q?fUd5/ewAKonx3h+cl6VkjkCupUwMv/FQap6AjvV/+ZSAJ4hD4jJBslckmMEk?= =?us-ascii?Q?ju8L9TZ95A8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CYYPR11MB8430.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?p6R78tzuIgfGAIe98qRrfRa0DRynGBNdTqQeDoilL8Wf+VNPRre3/BvYskoW?= =?us-ascii?Q?Xk5Z1lfN/p+d1sKYuuB++Pvw4fiVoUSC7auwGLNP2DV1DDaTvsdIlDesr4Kv?= =?us-ascii?Q?6QF2C6KIy7Hp2YNsYMch6T7fmiGd8S4nHFstgqqp9/aqHaGRizWf827KuReY?= =?us-ascii?Q?J3n+BWy48mPSAkZAqN+AUt00wSvCXTeIOXsZn8coxUcZDmmjif4VdkKIVMYE?= =?us-ascii?Q?VIa0QWQRIAp5IJ3x9FLqIhddy0aI71bg5WHPKowGID5CFr+KO0kxsgl1WKZf?= =?us-ascii?Q?uNYVHxXvZz6G/u8d8SDSaeV0lZjs3ADyAZbEaWdL2SuHQpFV+BkwGx8E+NSj?= =?us-ascii?Q?KMeAWUCZiYDIkEZx0bNAuCJXmXRHbNG31sSgUPjwn79ZB113qMf7fSULMkyb?= =?us-ascii?Q?0gAB1lGtKg+OxoyGQUEVRCBp3mQ/xLM6xfxhdguD/p7cmpHSf7beSKzmdSlw?= =?us-ascii?Q?rcApZuk826yQ9EdVNVbpikGBXU5YihosCCRLlUI22tvl5iVO1A1AkW+2Jvp+?= =?us-ascii?Q?m21KvxHJQwpS0Va3llIm3W60vc0fbmnr9ZAJu3BcyCIiS6ljtLdpF1NgsIM7?= =?us-ascii?Q?wZnaHziPH4skI/rWU6JNz0Ns/DmTsqTyQkHn6t6uk2BFAjBwp1iGm4eXC/xO?= =?us-ascii?Q?6cHy/OdapxAwb4fW2CVFs1Vx+oHD13Xha5gEDpOZHRKIT9SKx59+odsh7WqL?= =?us-ascii?Q?/avggfOUZNkWZduEyHc4KDC1NZ9cS7r2n8Hf4Z4ZNT2oqfJe7eISGeRTzKjm?= =?us-ascii?Q?Iue7trjn8AaZc6rYr/r3uOnTJ5+CXgLHiK0dOkfU12uUrIFZnuQ+pyVK8FJi?= =?us-ascii?Q?Jr4QgvLfgn9JZZ0svoQAsSpXuhfpjJvG7EOvyg6E9mYDXqPNbF/qY7bjRBQG?= =?us-ascii?Q?hvQeiMnmCR7gi2YlHnJAROG+MzWjmDPVi4BIENk9dkcr7QdcM0RQs0+e0lYR?= =?us-ascii?Q?mg8U6L739MSsOfgmfoFJJoZJfWXITNQZ9iUlEvoeWbvTMrOYdbl+uVA0ZLLD?= =?us-ascii?Q?iqRO7YqdNVYtOvqXGwDeKMASxPTRZOggLWAx0Namm2HKlPoLMmtcbPyNG8O7?= =?us-ascii?Q?/r81ksq3fdOXqsOQiIImvlUdsfZ0jWoyy/vSGJ0FrRyptbjhqr6Ruz6qh98T?= =?us-ascii?Q?50y7E2mhhec1bR1XqCrn/W7R8gLOL1Bl+g9ThMc72ZOh1+f53OGah9IiIJfu?= =?us-ascii?Q?m/QzG18TqK8HxlUxu27Zgq0ViksH7Mh0THhbEWVpZEIBXsNgGzM4rBSxSKBy?= =?us-ascii?Q?wN7Egtn7NiXBZLzMI7X4szPgp3ylPfm+jS+pCQTAsbJYkbeVGcO3ZUM77vrm?= =?us-ascii?Q?a4k2+pQzZ6ULZf5oHFpBmOU4PMR5dvXgj/OFOPpw57OEdjNLJJTqGQhBoqyN?= =?us-ascii?Q?UmuL009FZtapaO9n/MPAzMrzBDRsVEL3AwBFpvF7VzSd1OJBBY0LD2mwHxKA?= =?us-ascii?Q?1W2mlQnHav9BVVTuC1PPytzrFuj4vbzhOXoJdwjrtMyO9ER7ffSs9SFXHvHr?= =?us-ascii?Q?5qxxoXYxMXrADhkvD0CCi9SAI1gOF2nmhma6O2DjTPwLmBWf2o5WJh2KA6NK?= =?us-ascii?Q?895esv98cfwzdBIgeXf5Y90Ue3BsINIwpfkVCmFR?= X-MS-Exchange-CrossTenant-Network-Message-Id: 79b4adb5-c812-4053-a01b-08dde577842e X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8430.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2025 14:39:24.0754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R78ebHWzVsanvvGWA8kC9zUrDADZ8tt4bcBW1Idy4w0lJddxXCuSpHg1keJK2OSk93Gl4MeJZhEWG1rnaQqO2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4548 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Aug 21, 2025 at 03:14:44PM +0100, Tvrtko Ursulin wrote: > According to i915 before invalidating auxccs we must quiesce the memory > traffic by an extra flush. Perhaps we should be more specific about what commits exactly are mentioning this? > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/xe/xe_ring_ops.c | 7 ++++++- > drivers/gpu/drm/xe/xe_ring_ops_types.h | 2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c > index 761740d7769f..f56506ebbeca 100644 > --- a/drivers/gpu/drm/xe/xe_ring_ops.c > +++ b/drivers/gpu/drm/xe/xe_ring_ops.c > @@ -358,10 +358,15 @@ static void __emit_job_gen12_render_compute(struct xe_sched_job *job, > struct xe_gt *gt = job->q->gt; > struct xe_device *xe = gt_to_xe(gt); > bool lacks_render = !(gt->info.engine_mask & XE_HW_ENGINE_RCS_MASK); > + const bool aux_ccs = has_aux_ccs(xe); > u32 mask_flags = 0; > > i = emit_copy_timestamp(lrc, dw, i); > > + /* hsdes: 1809175790 */ in i915 I just see a mention to this HSD which is the 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") but that is not about emitting the flush, but about fixing the aux table invalidation itself. And that is in sync what written on this HSD, but I don't believe this patch is about that. So, although this patch itself kind of makes sense, I believe it deserves a better message. > + if (aux_ccs) > + i = emit_render_cache_flush(job, dw, i); > + > dw[i++] = preparser_disable(true); > if (lacks_render) > mask_flags = PIPE_CONTROL_3D_ARCH_FLAGS; > @@ -372,7 +377,7 @@ static void __emit_job_gen12_render_compute(struct xe_sched_job *job, > i = emit_pipe_invalidate(mask_flags, job->ring_ops_flush_tlb, dw, i); > > /* hsdes: 1809175790 */ > - if (has_aux_ccs(xe)) > + if (aux_ccs) > i = emit_aux_table_inv(gt, CCS_AUX_INV, dw, i); > > dw[i++] = preparser_disable(false); > diff --git a/drivers/gpu/drm/xe/xe_ring_ops_types.h b/drivers/gpu/drm/xe/xe_ring_ops_types.h > index d7e3e150a9a5..477dc7defd72 100644 > --- a/drivers/gpu/drm/xe/xe_ring_ops_types.h > +++ b/drivers/gpu/drm/xe/xe_ring_ops_types.h > @@ -8,7 +8,7 @@ > > struct xe_sched_job; > > -#define MAX_JOB_SIZE_DW 58 > +#define MAX_JOB_SIZE_DW 70 > #define MAX_JOB_SIZE_BYTES (MAX_JOB_SIZE_DW * 4) > > /** > -- > 2.48.0 >