Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Atwood <matthew.s.atwood@intel.com>
To: <John.C.Harrison@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: <Intel-Xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/xe/guc: Fix badly worded error message
Date: Thu, 4 Sep 2025 14:02:43 -0700	[thread overview]
Message-ID: <aLn-c_NgYoL9waYY@msatwood-mobl> (raw)
In-Reply-To: <20250904195752.3846138-3-John.C.Harrison@Intel.com>

On Thu, Sep 04, 2025 at 12:57:51PM -0700, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> If a GuC id lookup failed, the error message was 'Not engine present',
> which is bad in multiple ways - incorrect English and 'engines' are
> now called 'exec queues' in this context. So fix it.
> 
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 89b73f4df5d1..dc23ce9804cd 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -2029,7 +2029,7 @@ g2h_exec_queue_lookup(struct xe_guc *guc, u32 guc_id)
>  
>  	q = xa_load(&guc->submission_state.exec_queue_lookup, guc_id);
>  	if (unlikely(!q)) {
> -		xe_gt_err(gt, "Not engine present for guc_id %u\n", guc_id);
> +		xe_gt_err(gt, "No exec queue found for guc_id %u\n", guc_id);
>  		return NULL;
>  	}
>  
> -- 
> 2.49.0
> 

  reply	other threads:[~2025-09-04 21:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 19:57 [PATCH 0/2] drm/xe/guc: Assorted clean ups - dodgy defines, erroneous errors John.C.Harrison
2025-09-04 19:57 ` [PATCH 1/2] drm/xe/guc: Clean up of GuC 'CTL' defines John.C.Harrison
2025-09-04 19:57 ` [PATCH 2/2] drm/xe/guc: Fix badly worded error message John.C.Harrison
2025-09-04 21:02   ` Matt Atwood [this message]
2025-09-04 21:11 ` ✓ CI.KUnit: success for drm/xe/guc: Assorted clean ups - dodgy defines, erroneous errors Patchwork
2025-09-04 21:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-09-05 14:18 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLn-c_NgYoL9waYY@msatwood-mobl \
    --to=matthew.s.atwood@intel.com \
    --cc=John.C.Harrison@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox