From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 6/7] drm/xe: Use tile-oriented messages in GGTT code
Date: Tue, 9 Sep 2025 09:58:27 -0400 [thread overview]
Message-ID: <aMAyg_4YZ4MRMqxh@intel.com> (raw)
In-Reply-To: <20250903213712.6364-7-michal.wajdeczko@intel.com>
On Wed, Sep 03, 2025 at 11:36:11PM +0200, Michal Wajdeczko wrote:
> Use recently added macros to print tile-oriented messages.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(supposing that the xe_tile_ versions get gets in first ;))
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/xe_ggtt.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 71c7690a92b3..6a14bfdef41d 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -28,6 +28,7 @@
> #include "xe_pm.h"
> #include "xe_res_cursor.h"
> #include "xe_sriov.h"
> +#include "xe_tile_printk.h"
> #include "xe_tile_sriov_vf.h"
> #include "xe_tlb_inval.h"
> #include "xe_wa.h"
> @@ -269,7 +270,7 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
> gsm_size = probe_gsm_size(pdev);
>
> if (gsm_size == 0) {
> - drm_err(&xe->drm, "Hardware reported no preallocated GSM\n");
> + xe_tile_err(ggtt->tile, "Hardware reported no preallocated GSM\n");
> return -ENOMEM;
> }
>
> @@ -466,8 +467,8 @@ static void xe_ggtt_dump_node(struct xe_ggtt *ggtt,
>
> if (IS_ENABLED(CONFIG_DRM_XE_DEBUG)) {
> string_get_size(node->size, 1, STRING_UNITS_2, buf, sizeof(buf));
> - xe_gt_dbg(ggtt->tile->primary_gt, "GGTT %#llx-%#llx (%s) %s\n",
> - node->start, node->start + node->size, buf, description);
> + xe_tile_dbg(ggtt->tile, "GGTT %#llx-%#llx (%s) %s\n",
> + node->start, node->start + node->size, buf, description);
> }
> }
>
> @@ -499,9 +500,8 @@ int xe_ggtt_node_insert_balloon_locked(struct xe_ggtt_node *node, u64 start, u64
>
> err = drm_mm_reserve_node(&ggtt->mm, &node->base);
>
> - if (xe_gt_WARN(ggtt->tile->primary_gt, err,
> - "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
> - node->base.start, node->base.start + node->base.size, ERR_PTR(err)))
> + if (xe_tile_WARN(ggtt->tile, err, "Failed to balloon GGTT %#llx-%#llx (%pe)\n",
> + node->base.start, node->base.start + node->base.size, ERR_PTR(err)))
> return err;
>
> xe_ggtt_dump_node(ggtt, &node->base, "balloon");
> --
> 2.47.1
>
next prev parent reply other threads:[~2025-09-09 13:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 21:36 [PATCH 0/7] RFC: Add dedicated printk macros for tile and device Michal Wajdeczko
2025-09-03 21:36 ` [PATCH 1/7] drm/xe: Keep xe_gt_err() macro definitions together Michal Wajdeczko
2025-09-03 21:59 ` Lucas De Marchi
2025-09-03 21:36 ` [PATCH 2/7] drm/xe: Drop "gt_" prefix from xe_gt_WARN() macros Michal Wajdeczko
2025-09-03 22:00 ` Lucas De Marchi
2025-09-03 21:36 ` [PATCH 3/7] drm/xe: Prepare format for GT-oriented messages in one place Michal Wajdeczko
2025-09-09 13:55 ` Rodrigo Vivi
2025-09-03 21:36 ` [PATCH 4/7] drm/xe: Add dedicated printk macros for tile and device Michal Wajdeczko
2025-09-09 13:57 ` Rodrigo Vivi
2025-09-03 21:36 ` [PATCH 5/7] drm/xe: Define verbose debug macros Michal Wajdeczko
2025-09-03 22:06 ` Lucas De Marchi
2025-09-03 22:19 ` Michal Wajdeczko
2025-09-09 14:01 ` Rodrigo Vivi
2025-09-03 21:36 ` [PATCH 6/7] drm/xe: Use tile-oriented messages in GGTT code Michal Wajdeczko
2025-09-09 13:58 ` Rodrigo Vivi [this message]
2025-09-03 21:36 ` [PATCH 7/7] drm/xe: Use tile-oriented messages in LMTT code Michal Wajdeczko
2025-09-09 13:58 ` Rodrigo Vivi
2025-09-03 21:43 ` ✗ CI.checkpatch: warning for RFC: Add dedicated printk macros for tile and device Patchwork
2025-09-03 21:44 ` ✓ CI.KUnit: success " Patchwork
2025-09-03 22:21 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-09-04 4:49 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMAyg_4YZ4MRMqxh@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox