Re: [PATCH v2 2/2] drm/xe/sysfs: Simplify sysfs registration

[Raag Jadav <raag.jadav@intel.com>]

On Wed, Sep 17, 2025 at 02:38:14PM -0500, Lucas De Marchi wrote:
> On Wed, Sep 17, 2025 at 12:52:45PM +0200, Raag Jadav wrote:
> > On Wed, Sep 17, 2025 at 12:24:24PM +0200, Michal Wajdeczko wrote:
> > > On 9/17/2025 8:18 AM, Raag Jadav wrote:
> > > > On Tue, Sep 16, 2025 at 07:00:29PM +0200, Michal Wajdeczko wrote:
> > > > > Instead of manually maintaining each sysfs file define and use
> > > > > attribute groups and register them using device managed function.

Nit: Although this gets the point across, is there a punctuation missing here
or am I reading it wrong?

> > > > > Then use is_visible() to filter-out unsupported attributes.

...

> > > > >  	xe_pm_runtime_put(xe);
> > > >
> > > > The device is already in D0 while probing so runtime PM is probably
> > > > not needed here.
> > > 
> > > true, but this is how it was initially coded and I didn't want to change it now
> > > 
> > > we can either drop it completely or replace with
> > > 
> > > 	xe_pm_runtime_get_noresume(xe);
> > > 	xe_pm_runtime_put(xe);
> > > 
> > > do you want this to be done as part of this series or it can be done later as follow-up?
> > 
> > Since there's no functional impact, I don't see any harm in dropping
> > it as part of refactoring here. But whatever the maintainers think is
> > best.
> 
> Let's keep those changes separate so we avoid bundling multiple changes
> in one patch. One small patch on top to do that doesn't hurt. Please
> send it when you can.

Sure, thanks.

Raag