Re: [PATCH v1 2/2] drm/xe/sysfs: Drop redundant runtime PM usage

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Sep 18, 2025 at 05:18:04PM +0530, Raag Jadav wrote:
> The device is expected to be in D0 state during driver probe. No need to
> resume it in ->is_visible() callbacks or non I/O operations.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_device_sysfs.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_sysfs.c b/drivers/gpu/drm/xe/xe_device_sysfs.c
> index c5151c86a98a..ec9c06b06fb5 100644
> --- a/drivers/gpu/drm/xe/xe_device_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_device_sysfs.c
> @@ -38,13 +38,8 @@ vram_d3cold_threshold_show(struct device *dev,
>  {
>  	struct pci_dev *pdev = to_pci_dev(dev);
>  	struct xe_device *xe = pdev_to_xe_device(pdev);
> -	int ret;
>  
> -	xe_pm_runtime_get(xe);
> -	ret = sysfs_emit(buf, "%d\n", xe->d3cold.vram_threshold);
> -	xe_pm_runtime_put(xe);
> -
> -	return ret;
> +	return sysfs_emit(buf, "%d\n", xe->d3cold.vram_threshold);
>  }
>  
>  static ssize_t
> @@ -173,11 +168,8 @@ static umode_t late_bind_attr_is_visible(struct kobject *kobj,
>  	u32 cap = 0;
>  	int ret;
>  
> -	xe_pm_runtime_get(xe);
> -
>  	ret = xe_pcode_read(root, PCODE_MBOX(PCODE_LATE_BINDING, GET_CAPABILITY_STATUS, 0),
>  			    &cap, NULL);
> -	xe_pm_runtime_put(xe);
>  	if (ret)
>  		return 0;
>  
> -- 
> 2.34.1
>