Re: [PATCH v2] drm/xe/i2c: Don't rely on d3cold.allowed flag in system PM path

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Sep 18, 2025 at 04:02:00PM +0530, Raag Jadav wrote:
> In S3 and above sleep states, the device can loose power regardless of
> d3cold.allowed flag. Bring up I2C controller explicitly in system PM
> path to ensure its normal operation after loosing power.
> 
> v2: Cover S3 and above states (Rodrigo)
> 
> Fixes: 0ea07b69517a ("drm/xe/pm: Wire up suspend/resume for I2C controller")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index a303ed5780b4..00ced1f63776 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -198,7 +198,7 @@ int xe_pm_resume(struct xe_device *xe)
>  	if (err)
>  		goto err;
>  
> -	xe_i2c_pm_resume(xe, xe->d3cold.allowed);
> +	xe_i2c_pm_resume(xe, true);


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  
>  	xe_irq_resume(xe);
>  
> -- 
> 2.34.1
>