From: Matthew Brost <matthew.brost@intel.com>
To: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
John Harrison <John.C.Harrison@intel.com>
Subject: Re: [PATCH 4/4] drm/xe/guc: Increase wait timeout to 2sec after BUSY reply from GuC
Date: Mon, 22 Sep 2025 11:18:38 -0700 [thread overview]
Message-ID: <aNGS/jB1NqMBCCAj@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20250918073002.15242-10-satyanarayana.k.v.p@intel.com>
On Thu, Sep 18, 2025 at 01:00:07PM +0530, Satyanarayana K V P wrote:
> Some VF2GUC actions may take longer to process. Increase default timeout
> after received BUSY indication to 2sec to cover all worst case scenarios.
>
I think we need a little more detail which actions take more than 1s to
complete to get a full picture of the proper solution.
Matt
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: John Harrison <John.C.Harrison@Intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
> index e56c9c5c8845..1f67317907ac 100644
> --- a/drivers/gpu/drm/xe/xe_guc.c
> +++ b/drivers/gpu/drm/xe/xe_guc.c
> @@ -1469,7 +1469,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
> BUILD_BUG_ON((GUC_HXG_TYPE_RESPONSE_SUCCESS ^ GUC_HXG_TYPE_RESPONSE_FAILURE) != 1);
>
> ret = xe_mmio_wait32(mmio, reply_reg, resp_mask, resp_mask,
> - 1000000, &header, false);
> + 2000000, &header, false);
>
> if (unlikely(FIELD_GET(GUC_HXG_MSG_0_ORIGIN, header) !=
> GUC_HXG_ORIGIN_GUC))
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-09-22 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 7:30 [PATCH 0/4] Improve CCS save/restore series (cont..) Satyanarayana K V P
2025-09-18 7:20 ` ✓ CI.KUnit: success for " Patchwork
2025-09-18 7:30 ` [PATCH 1/4] drm/xe: Use PPGTT addresses for TLB invalidation to avoid GGTT fixups Satyanarayana K V P
2025-09-22 17:47 ` Matthew Brost
2025-09-22 17:58 ` Matthew Brost
2025-09-18 7:30 ` [PATCH 2/4] drm/xe/lrc: Add helper to query post-init ring tail Satyanarayana K V P
2025-09-18 7:30 ` [PATCH 3/4] drm/xe/vf: Post migration fixups for CCS save/restore Satyanarayana K V P
2025-09-22 17:57 ` Matthew Brost
2025-09-18 7:30 ` [PATCH 4/4] drm/xe/guc: Increase wait timeout to 2sec after BUSY reply from GuC Satyanarayana K V P
2025-09-22 18:18 ` Matthew Brost [this message]
2025-09-18 8:08 ` ✓ Xe.CI.BAT: success for Improve CCS save/restore series (cont..) Patchwork
2025-09-18 13:28 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNGS/jB1NqMBCCAj@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=John.C.Harrison@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=satyanarayana.k.v.p@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox