Re: [PATCH v1 1/5] drm/xe: add VM_BIND DECOMPRESS uapi flag

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Sep 18, 2025 at 07:55:25PM +0530, Nitin Gote wrote:
> Add DRM_XE_VM_BIND_FLAG_DECOMPRESS to the userspace API so callers
> can request GPU-side decompression on VM_BIND.
> 
> This flag is used by subsequent driver changes to trigger scheduling of
> GPU work that resolves compressed VRAM pages into an uncompressed PAT
> VM mapping.
> 
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
> ---
>  include/uapi/drm/xe_drm.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 40ff19f52a8d..6b652a6968a0 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -1119,6 +1119,7 @@ struct drm_xe_vm_bind_op {
>  #define DRM_XE_VM_BIND_FLAG_DUMPABLE	(1 << 3)
>  #define DRM_XE_VM_BIND_FLAG_CHECK_PXP	(1 << 4)
>  #define DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR	(1 << 5)
> +#define DRM_XE_VM_BIND_FLAG_DECOMPRESS	(1 << 6)

You need kernel doc explaining what this does and the semantics (i.e.,
where this flag is valid).

Matt

>  	/** @flags: Bind flags */
>  	__u32 flags;
>  
> -- 
> 2.25.1
>