Re: [PATCH 1/3] drm/xe: Fix copyright and function naming in xe_ttm_sys_mgr

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Oct 09, 2025 at 01:53:06PM -0400, Lin, Shuicheng wrote:
> On Thu, Oct 9, 2025 7:55 AM Rodrigo Vivi wrote:
> > On Mon, Oct 06, 2025 at 08:13:25PM +0000, Shuicheng Lin wrote:
> > > - Correct Red Hat copyright year from "2002" to "2022".
> > > - Rename ttm_sys_mgr_fini() to xe_ttm_sys_mgr_fini() to avoid
> > >   confusion with generic TTM helpers.
> > >
> > > No functional changes intended.
> > >
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> > 
> > I think you had already gotten a rv-b for this patch previously right?
> > if so, please add it here now as response to this email, but next time add to the
> > patch before resending it please.
> 
> No. I don't get r-b yet for this patch.
> There is another patch with very similar name and already be merged.
> " drm/xe: Fix copyright and function naming in xe_ttm_vram_mgr "

doh! and I was the one who merged it! :)

then,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> Shuicheng
> 
> > 
> > Thanks,
> > Rodrigo.
> > 
> > > ---
> > >  drivers/gpu/drm/xe/xe_ttm_sys_mgr.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> > > b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> > > index d38b91872da3..3e404eb8d098 100644
> > > --- a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> > > +++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> > > @@ -1,7 +1,7 @@
> > >  // SPDX-License-Identifier: MIT
> > >  /*
> > >   * Copyright (c) 2021-2022 Intel Corporation
> > > - * Copyright (C) 2021-2002 Red Hat
> > > + * Copyright (C) 2021-2022 Red Hat
> > >   */
> > >
> > >  #include "xe_ttm_sys_mgr.h"
> > > @@ -85,7 +85,7 @@ static const struct ttm_resource_manager_func
> > xe_ttm_sys_mgr_func = {
> > >  	.debug = xe_ttm_sys_mgr_debug
> > >  };
> > >
> > > -static void ttm_sys_mgr_fini(struct drm_device *drm, void *arg)
> > > +static void xe_ttm_sys_mgr_fini(struct drm_device *drm, void *arg)
> > >  {
> > >  	struct xe_device *xe = (struct xe_device *)arg;
> > >  	struct ttm_resource_manager *man = &xe->mem.sys_mgr; @@ -
> > 116,5
> > > +116,5 @@ int xe_ttm_sys_mgr_init(struct xe_device *xe)
> > >  	ttm_resource_manager_init(man, &xe->ttm, gtt_size >> PAGE_SHIFT);
> > >  	ttm_set_driver_manager(&xe->ttm, XE_PL_TT, man);
> > >  	ttm_resource_manager_set_used(man, true);
> > > -	return drmm_add_action_or_reset(&xe->drm, ttm_sys_mgr_fini, xe);
> > > +	return drmm_add_action_or_reset(&xe->drm, xe_ttm_sys_mgr_fini,
> > xe);
> > >  }
> > > --
> > > 2.49.0
> > >