Re: [PATCH v2 5/8] drm/xe/gt_throttle: Tidy up attribute definition

[Raag Jadav <raag.jadav@intel.com>]

On Sun, Oct 26, 2025 at 10:57:17PM -0700, Lucas De Marchi wrote:
> Move the attribute definitions to be grouped together rather than near
> the show() function: checkpatch keeps complaining about the missing
> newline when defining new attributes and it reads better to group
> everything, which should match e.g. the xe_pmu.c style.
> 
> While grouping them, also define a THROTTLE_ATTR_RO(), similar to
> DEVICE_ATTR_RO(), and use it to define all attributes. This makes it
> shorter and with a familiar syntax.
> 
> Finally, during the cri_throttle_attrs[] array definition, also
> highlight what's coming from common attributes and what is CRI-specific.
> 
> These 3 things could be done as separate commits, but they are all about
> the same thing: reduce the attribute definition verbosity and are very
> simple and mechanical.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Raag Jadav <raag.jadav@intel.com>