Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Nitin Gote <nitin.r.gote@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <matthew.auld@intel.com>
Subject: Re: [PATCH v3 0/3] drm/xe: add VM_BIND DECOMPRESS support and on‑demand decompression
Date: Fri, 17 Oct 2025 10:38:56 -0700	[thread overview]
Message-ID: <aPJ/MHpLDJ4yxF65@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20251015104709.44476-1-nitin.r.gote@intel.com>

On Wed, Oct 15, 2025 at 04:17:06PM +0530, Nitin Gote wrote:
> This series implements VM_BIND decompression support in the XE driver
> for both non-fault mode and fault mode.
> 
> Tested with https://patchwork.freedesktop.org/series/154711/
> which validates basic VM_BIND DECOMPRESS behavior for both
> regular and FAULT_MODE VMs.
> 

This series is getting close to being ready to merged - I'll do another
review shortly. But to merge this we will need a UMD PR which uses this
new uAPI. Has the compute UMD tested this code yet? Can you see if they
can post a PR which can be referenced in the cover letter?

Matt 

> v3: (Matt)
>    - s/xe_bo_schedule_decompress/xe_bo_decompress
>    - skip the decrompress step if the BO isn't in VRAM
>    - start/size not required in xe_bo_schedule_decompress
>    - Use xe_bo_move_notify instead of xe_vm_invalidate_vma
>      with respect to invalidation.
>    - Nits
>  
> v2:
>    - Add kernel doc (Matt)
>    - Move decompression work out of vm_bind ioctl. (Matt)
>    - Put that work in a small helper at the BO/migrate layer invoke it
>      from vma_lock_and_validate which already runs under drm_exec.
>    - Move lightweight checks to vm_bind_ioctl_check_args (Matthew Auld)
> 
> 
> Nitin Gote (3):
>   drm/xe: add VM_BIND DECOMPRESS uapi flag
>   drm/xe: add xe_migrate_resolve wrapper and is_vram_resolve support
>   drm/xe: implement VM_BIND decompression in vm_bind_ioctl
> 
>  drivers/gpu/drm/xe/xe_bo.c       | 50 ++++++++++++++++++
>  drivers/gpu/drm/xe/xe_bo.h       |  2 +
>  drivers/gpu/drm/xe/xe_migrate.c  | 90 ++++++++++++++++++++++----------
>  drivers/gpu/drm/xe/xe_migrate.h  |  7 +++
>  drivers/gpu/drm/xe/xe_vm.c       | 40 ++++++++++----
>  drivers/gpu/drm/xe/xe_vm_types.h |  2 +
>  include/uapi/drm/xe_drm.h        |  8 +++
>  7 files changed, 161 insertions(+), 38 deletions(-)
> 
> -- 
> 2.25.1
> 

      parent reply	other threads:[~2025-10-17 17:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 10:47 [PATCH v3 0/3] drm/xe: add VM_BIND DECOMPRESS support and on‑demand decompression Nitin Gote
2025-10-15 10:47 ` [PATCH v3 1/3] drm/xe: add VM_BIND DECOMPRESS uapi flag Nitin Gote
2025-10-17 21:54   ` Matthew Brost
2025-10-15 10:47 ` [PATCH v3 2/3] drm/xe: add xe_migrate_resolve wrapper and is_vram_resolve support Nitin Gote
2025-10-17 21:52   ` Matthew Brost
2025-10-15 10:47 ` [PATCH v3 3/3] drm/xe: implement VM_BIND decompression in vm_bind_ioctl Nitin Gote
2025-10-17 22:19   ` Matthew Brost
2025-10-15 16:15 ` ✓ CI.KUnit: success for drm/xe: add VM_BIND DECOMPRESS support and on‑demand decompression (rev3) Patchwork
2025-10-15 16:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-16  2:10 ` ✓ Xe.CI.Full: " Patchwork
2025-10-17 17:38 ` Matthew Brost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPJ/MHpLDJ4yxF65@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=nitin.r.gote@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox