Re: [PATCH 2/6] drm/xe: Add a trace point for VM close

[Matt Atwood <matthew.s.atwood@intel.com>]

On Mon, Oct 27, 2025 at 06:04:08PM +0000, Stuart Summers wrote:
> All better tracking of error cases when calling through
s/all/add
> xe_vm_close_and_put().
> 
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_trace_bo.h | 6 ++++++
>  drivers/gpu/drm/xe/xe_vm.c       | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
> index 86323cf3be2c..238311cfb816 100644
> --- a/drivers/gpu/drm/xe/xe_trace_bo.h
> +++ b/drivers/gpu/drm/xe/xe_trace_bo.h
> @@ -14,6 +14,7 @@
>  
>  #include "xe_bo.h"
>  #include "xe_bo_types.h"
> +#include "xe_exec_queue_types.h"
This doesnt appear to be required for this patch and should be included
in the patch titled "Add new exec queue trace points".

With its removal.

Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com>
>  #include "xe_vm.h"
>  
>  #define __dev_name_bo(bo)	dev_name(xe_bo_device(bo)->drm.dev)
> @@ -223,6 +224,11 @@ DEFINE_EVENT(xe_vm, xe_vm_free,
>  	     TP_ARGS(vm)
>  );
>  
> +DEFINE_EVENT(xe_vm, xe_vm_close,
> +	     TP_PROTO(struct xe_vm *vm),
> +	     TP_ARGS(vm)
> +);
> +
>  DEFINE_EVENT(xe_vm, xe_vm_cpu_bind,
>  	     TP_PROTO(struct xe_vm *vm),
>  	     TP_ARGS(vm)
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 00f3520dec38..e383982bad8a 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1672,6 +1672,8 @@ static void xe_vm_close(struct xe_vm *vm)
>  	bool bound;
>  	int idx;
>  
> +	trace_xe_vm_close(vm);
> +
>  	bound = drm_dev_enter(&xe->drm, &idx);
>  
>  	down_write(&vm->lock);
> -- 
> 2.34.1
>