From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C44CCCF9E0 for ; Tue, 28 Oct 2025 20:52:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEEF410E149; Tue, 28 Oct 2025 20:52:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CMVR2UUq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 823DC10E149; Tue, 28 Oct 2025 20:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761684769; x=1793220769; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MrFmi4nutVJ88C6N9UIN60oxiHIesmpQ4tsvTyjR+Ts=; b=CMVR2UUq8sqzIyCXLKKJWYpuwGTztctRN2Ck33tCkjy+z6JAcN70rAhm KbPyN1v8w/kpWfZ+OD/E3xAV4kWSRKYiDia6B62A2UHXZ/nBb6wzgbjpt Fl2TFJjWZbdGUjJeuVINymt5dYcL4pI5Bct1Rg3BWeEye0SBh6WHGTVaR 4aIeTdFwI8HL59oKMCITtmkJ3q+nom6KQKrex/fLlJ5tbVuRhmeQlN8jg xOEECwWiSAKnPkui70dcRvewilr0hsiUSWHjdr/cojtAACR2XmOH61aSt tvQVEDkCiF+LiUWKi1D2VqDez8DY3SNIXdrcl7sAoYqBBbkP8PyFSmDCl g==; X-CSE-ConnectionGUID: t6C4/db8RqKUD1D6IEJnSw== X-CSE-MsgGUID: M1IdLbPnSSm6nu3ZHCr9CQ== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="67440085" X-IronPort-AV: E=Sophos;i="6.19,262,1754982000"; d="scan'208";a="67440085" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2025 13:52:49 -0700 X-CSE-ConnectionGUID: opDK6Fe4SQyJydL/YF5G1Q== X-CSE-MsgGUID: gKdLiDTtTL2UdTwLcAaHHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,262,1754982000"; d="scan'208";a="222679629" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.244.169]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2025 13:52:46 -0700 Date: Tue, 28 Oct 2025 22:52:43 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Maxime Ripard Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Dan Carpenter Subject: Re: [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage Message-ID: References: <20251017163327.9074-2-ville.syrjala@linux.intel.com> <6bccb6ce0672f5b736bb8669060d8005@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6bccb6ce0672f5b736bb8669060d8005@kernel.org> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Oct 20, 2025 at 07:29:49AM +0000, Maxime Ripard wrote: > On Fri, 17 Oct 2025 19:33:27 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > drm_{crtc,plane,connector,private_obj}_get_state() must not > > be called after the atomic check phase. At that point the commit > > has been carved in stone and no new objects must be introduced > > > > [ ... ] > > Reviewed-by: Maxime Ripard Thanks. This is now in, so I guess we'll see if there are further issues still remaining anywhere. After any initial fires have been put out, I'm thinking we should change the implementation from just WARN to "WARN+return an error"... -- Ville Syrjälä Intel