Re: [PATCH] drm/xe/irq: Handle msix vector0 interrupt

["Vivekanandan, Balasubramani" <balasubramani.vivekanandan@intel.com>]

On 30.10.2025 20:40, Venkata Ramana Nayana wrote:
> Current gu2host handler registered as MSI-X vector 0 and as per bspec for
> an msix vector 0 interrupt, the driver must check the legacy registers
> 190008(TILE_INT_REG), 190060h (GT INTR Identity Reg 0) and other registers
> mentioned in "Interrupt Service Routine Pseudocode" otherwise it's block
> the next interrupts. To overcome this issue replacing guc2host handler
> with legacy xe_irq_handler.
> 
> Bspec: 62357
> Signed-off-by: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>

Please add the Fixes tag.

Fixes: da889070be7b2 ("drm/xe/irq: Separate MSI and MSI-X flows")

Few nitpicks

s/an msix/a msix
s/it's block/it will block

Rest looks good.

Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>

Regards,
Bala

> ---
>  drivers/gpu/drm/xe/xe_irq.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index e5ed0242f7b1..024e13e606ec 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -897,22 +897,6 @@ static int xe_irq_msix_init(struct xe_device *xe)
>  	return 0;
>  }
>  
> -static irqreturn_t guc2host_irq_handler(int irq, void *arg)
> -{
> -	struct xe_device *xe = arg;
> -	struct xe_tile *tile;
> -	u8 id;
> -
> -	if (!atomic_read(&xe->irq.enabled))
> -		return IRQ_NONE;
> -
> -	for_each_tile(tile, xe, id)
> -		xe_guc_irq_handler(&tile->primary_gt->uc.guc,
> -				   GUC_INTR_GUC2HOST);
> -
> -	return IRQ_HANDLED;
> -}
> -
>  static irqreturn_t xe_irq_msix_default_hwe_handler(int irq, void *arg)
>  {
>  	unsigned int tile_id, gt_id;
> @@ -1029,7 +1013,7 @@ int xe_irq_msix_request_irqs(struct xe_device *xe)
>  	u16 msix;
>  
>  	msix = GUC2HOST_MSIX;
> -	err = xe_irq_msix_request_irq(xe, guc2host_irq_handler, xe,
> +	err = xe_irq_msix_request_irq(xe, xe_irq_handler(xe), xe,
>  				      DRIVER_NAME "-guc2host", false, &msix);
>  	if (err)
>  		return err;
> -- 
> 2.34.1
>