From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3927DCF3188 for ; Wed, 19 Nov 2025 10:09:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF38D10E5CD; Wed, 19 Nov 2025 10:09:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="FYaT17tX"; dkim-atps=neutral Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by gabe.freedesktop.org (Postfix) with ESMTPS id 305CE10E5CD for ; Wed, 19 Nov 2025 10:09:25 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b725ead5800so792649066b.1 for ; Wed, 19 Nov 2025 02:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763546963; x=1764151763; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mZmwnZeJsVmH4Emd6Sk7OTkRxBmCW6aXF7g1I/Zjods=; b=FYaT17tXz9hnVh0b5oJUXY+NSfhWUh2JXjWI+0X3THd2NJdrJwj25G5bcrhDEEWjS9 z5XFHtkrmM1RplaxJEhxemh5AOb58SXfWMyYT5a/aIfk7Bge0XJz7jjZO28gjgKzoDIu P1cv3GYO2F30NTkVP4KE4NUiRHZg2cCKlaOUiQcILyEcSnkc4gNhc0PUx9Yddd0KcEtZ Gix8NKnU/S4+rCOy/4FvltuwBGOXwdwtPe7BYyAAz3p+/fQn5tVynOlAUwY2NuMJESOx 5Y31epf6tSWVfPa5crvYt/e/4Ipyxv25RN0QQzgGvAxFV2fGIm7z+1JtQIP8+/V3i8A8 yRmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763546963; x=1764151763; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mZmwnZeJsVmH4Emd6Sk7OTkRxBmCW6aXF7g1I/Zjods=; b=NiKpy9knSkwYDQl7/6CpkQF6rWQbnk6pKtlTgrZO8F7IWvxbcN5DPobtPHa03pK8xu QVrpE1N8wMd001iq4//Nm3wpW2Kh/kl3T4P/5ZUqhQhCNapjd/FDQZIDBad0oy1rQIFc sXcxJMNup6VcgpVT97zWSvmeIluqrQmekEaaZ2CxynG6vlXVhFMM0trBC2LfHPdXGTki p4rFZUBYCiU66q6dr+ioezZ9OxjTfnzvAaPKZdwscP+8ubQjRhif3h3LVn2xCmgcfRI8 cyy3mK5bz0S8FnlruL98u2n5X/YAlnkxQc8knzmvUBIUTRFRthv8h7sZMMZ9Oo8HW7RA wS9w== X-Forwarded-Encrypted: i=1; AJvYcCVjPuaU6JQd10N93PHZJpoo2qwVuUzxJgXP6g1sn7uf/G9l2zN8R+noztFKunMHHuLn8wnuJjQK/Q==@lists.freedesktop.org X-Gm-Message-State: AOJu0YzaSnbIHE5JtoyVRMpNQQGvq/fq7YnqmM/LzwcDajIdNzq1Tl5i BajZaXNJSwbCSqXYIATeGnRUHJ83tqjC60tvSiq6GCJZ6yEMselmPZQKgSJ/LSB/mhY= X-Gm-Gg: ASbGnct9012+D9zU/XsH1+ieFrcDFG6QMIjgnwoS2mPdwWQ9fkLHvaWtSYJomf3DJiR gBjk/Slw24iXyQeFu3UgEQS/B2z62veIxCBNUAqW6qUwdhJu8XXAcr9B2UarsII+5+5QGocsNm9 92TuoYUfQmQtkwSPKwii8GuVzirv34zMbWLY7yOMDxEWj71SiIigAXCsYHYwzqP0WHcmFz2cmum e5E3sxtjGq29MEIBwYcATzz1EphaWxSy6gw7lnV4zkjHM3HHbStRh8SihZDJ+njzF9NvOc167vR QztvgqdOQVNI7Tj+LaZ9nPQgilWD5dfU2xNLjW1FG9J6wyXmYpqzvBWIrQ458+cwqDmkqbON3SY VBMPS7r88K/mIBpsAQm9O7XZwMGC0cDANoO9cYdfa/jaYFnCVHPtd32eiJGLBWUTfWueUfCFQ3U PejhP34HxAP2Gm3jeqUbu4FyuS X-Google-Smtp-Source: AGHT+IHL60A5nBupA1OyvdeZdvK8rVJqcdAj2UJ8GMSSqilZDEkvpcYDaNSL65+yyn9lVOsemK499g== X-Received: by 2002:a17:907:1c81:b0:b72:d2df:641c with SMTP id a640c23a62f3a-b736795d498mr2006941666b.49.1763546963352; Wed, 19 Nov 2025 02:09:23 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fda8bc8sm1594056066b.49.2025.11.19.02.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 02:09:22 -0800 (PST) Date: Wed, 19 Nov 2025 11:08:01 +0100 From: Petr Mladek To: Andy Shevchenko Cc: Corey Minyard , Christian =?iso-8859-1?Q?K=F6nig?= , "Dr. David Alan Gilbert" , Alex Deucher , Thomas Zimmermann , Dmitry Baryshkov , Rob Clark , Matthew Brost , Ulf Hansson , Aleksandr Loktionov , Vitaly Lifshits , Manivannan Sadhasivam , Niklas Cassel , Calvin Owens , Vadim Fedorenko , Sagi Maimon , "Martin K. Petersen" , Karan Tilak Kumar , Hans Verkuil , Casey Schaufler , Steven Rostedt , Viacheslav Dubeyko , Max Kellermann , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, ceph-devel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Sumit Semwal , Gustavo Padovan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Konrad Dybcio , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Vladimir Oltean , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tony Nguyen , Przemek Kitszel , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Rodolfo Giometti , Jonathan Lemon , Richard Cochran , Stefan Haberland , Jan Hoeppner , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Satish Kharat , Sesidhar Baddela , "James E.J. Bottomley" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Xiubo Li , Ilya Dryomov , Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton Subject: Re: [PATCH v3 19/21] scsi: fnic: Switch to use %ptSp Message-ID: References: <20251113150217.3030010-1-andriy.shevchenko@linux.intel.com> <20251113150217.3030010-20-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251113150217.3030010-20-andriy.shevchenko@linux.intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu 2025-11-13 15:32:33, Andy Shevchenko wrote: > Use %ptSp instead of open coded variants to print content of > struct timespec64 in human readable format. I was about to commit the changes into printk/linux.git and found a mistake during the final double check, see below. > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c > index cdc6b12b1ec2..0a849a195a8e 100644 > --- a/drivers/scsi/fnic/fnic_trace.c > +++ b/drivers/scsi/fnic/fnic_trace.c > @@ -215,30 +213,26 @@ int fnic_get_stats_data(struct stats_debug_info *debug, > { > int len = 0; > int buf_size = debug->buf_size; > - struct timespec64 val1, val2; > + struct timespec64 val, val1, val2; > int i = 0; > > - ktime_get_real_ts64(&val1); > + ktime_get_real_ts64(&val); > len = scnprintf(debug->debug_buffer + len, buf_size - len, > "------------------------------------------\n" > "\t\tTime\n" > "------------------------------------------\n"); > > + val1 = timespec64_sub(val, stats->stats_timestamps.last_reset_time); > + val2 = timespec64_sub(val, stats->stats_timestamps.last_read_time); > len += scnprintf(debug->debug_buffer + len, buf_size - len, > - "Current time : [%lld:%ld]\n" > - "Last stats reset time: [%lld:%09ld]\n" > - "Last stats read time: [%lld:%ld]\n" > - "delta since last reset: [%lld:%ld]\n" > - "delta since last read: [%lld:%ld]\n", > - (s64)val1.tv_sec, val1.tv_nsec, > - (s64)stats->stats_timestamps.last_reset_time.tv_sec, > - stats->stats_timestamps.last_reset_time.tv_nsec, > - (s64)stats->stats_timestamps.last_read_time.tv_sec, > - stats->stats_timestamps.last_read_time.tv_nsec, > - (s64)timespec64_sub(val1, stats->stats_timestamps.last_reset_time).tv_sec, > - timespec64_sub(val1, stats->stats_timestamps.last_reset_time).tv_nsec, > - (s64)timespec64_sub(val1, stats->stats_timestamps.last_read_time).tv_sec, > - timespec64_sub(val1, stats->stats_timestamps.last_read_time).tv_nsec); > + "Current time : [%ptSp]\n" > + "Last stats reset time: [%ptSp]\n" > + "Last stats read time: [%ptSp]\n" > + "delta since last reset: [%ptSp]\n" > + "delta since last read: [%ptSp]\n", Both delta times are printed at the end. > + &val, > + &stats->stats_timestamps.last_reset_time, &val1, > + &stats->stats_timestamps.last_read_time, &val2); I think that this should be: &stats->stats_timestamps.last_reset_time, &stats->stats_timestamps.last_read_time, &val1, &val2); > stats->stats_timestamps.last_read_time = val1; The original code stored the current time in "val1". This should be: stats->stats_timestamps.last_read_time = val; > @@ -416,8 +410,8 @@ int fnic_get_stats_data(struct stats_debug_info *debug, > jiffies_to_timespec64(stats->misc_stats.last_ack_time, &val2); Just for record. Another values are stored into @val1 and @val2 at this point. > len += scnprintf(debug->debug_buffer + len, buf_size - len, > - "Last ISR time: %llu (%8llu.%09lu)\n" > - "Last ACK time: %llu (%8llu.%09lu)\n" > + "Last ISR time: %llu (%ptSp)\n" > + "Last ACK time: %llu (%ptSp)\n" > "Max ISR jiffies: %llu\n" > "Max ISR time (ms) (0 denotes < 1 ms): %llu\n" > "Corr. work done: %llu\n" > @@ -437,10 +431,8 @@ int fnic_get_stats_data(struct stats_debug_info *debug, > "Number of rport not ready: %lld\n" > "Number of receive frame errors: %lld\n" > "Port speed (in Mbps): %lld\n", > - (u64)stats->misc_stats.last_isr_time, > - (s64)val1.tv_sec, val1.tv_nsec, > - (u64)stats->misc_stats.last_ack_time, > - (s64)val2.tv_sec, val2.tv_nsec, > + (u64)stats->misc_stats.last_isr_time, &val1, > + (u64)stats->misc_stats.last_ack_time, &val2, So, this is correct! > (u64)atomic64_read(&stats->misc_stats.max_isr_jiffies), > (u64)atomic64_read(&stats->misc_stats.max_isr_time_ms), > (u64)atomic64_read(&stats->misc_stats.corr_work_done), Now, I think that there is no need to resend the entire huge patchset. I could either fix this when comitting or commit the rest and you could send only this patch for review. Best Regards, Petr PS: All other patches look good. Well, nobody acked 7th patch yet. But I think that the change is pretty straightforward and we could do it even without an ack.