Re: [PATCH] drm/xe/compat: remove unused i915_active.h and i915_active_types.h

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Dec 01, 2025 at 07:10:50PM +0200, Jani Nikula wrote:
> Commit 965930962a41 ("drm/i915/frontbuffer: Fix intel_frontbuffer
> lifetime handling") dropped the last xe display users of the
> headers. They're still used in intel_overlay.c, but it's not built as
> part of xe.

indeed, this patch moved the used ones to inside i915/gem...

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  .../drm/xe/compat-i915-headers/i915_active.h  | 22 -------------------
>  .../compat-i915-headers/i915_active_types.h   | 13 -----------
>  2 files changed, 35 deletions(-)
>  delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_active.h
>  delete mode 100644 drivers/gpu/drm/xe/compat-i915-headers/i915_active_types.h
> 
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_active.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_active.h
> deleted file mode 100644
> index 6f0ab3753563..000000000000
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_active.h
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -/* SPDX-License-Identifier: MIT */
> -/*
> - * Copyright © 2022 Intel Corporation
> - */
> -
> -#ifndef _I915_ACTIVE_H_
> -#define _I915_ACTIVE_H_
> -
> -#include "i915_active_types.h"
> -
> -static inline void i915_active_init(struct i915_active *ref,
> -				    int (*active)(struct i915_active *ref),
> -				    void (*retire)(struct i915_active *ref),
> -				    unsigned long flags)
> -{
> -	(void) active;
> -	(void) retire;
> -}
> -
> -#define i915_active_fini(active) do { } while (0)
> -
> -#endif
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_active_types.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_active_types.h
> deleted file mode 100644
> index 8c31f9a8b168..000000000000
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_active_types.h
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -/*
> - * SPDX-License-Identifier: MIT
> - *
> - * Copyright © 2019 Intel Corporation
> - */
> -
> -#ifndef _I915_ACTIVE_TYPES_H_
> -#define _I915_ACTIVE_TYPES_H_
> -
> -struct i915_active {};
> -#define I915_ACTIVE_RETIRE_SLEEPS 0
> -
> -#endif /* _I915_ACTIVE_TYPES_H_ */
> -- 
> 2.47.3
>