From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC329D12675 for ; Tue, 2 Dec 2025 22:18:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA2C810E6F3; Tue, 2 Dec 2025 22:18:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="loksk82z"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7588310E6F3 for ; Tue, 2 Dec 2025 22:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764713920; x=1796249920; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=H1CtI8+wfjKBO5F9MTrT7hfjeAu+JJoRy49aHn4rscM=; b=loksk82zfq8rRkAP1mLfWbQtmLgIpO3Iide03Syusb3mx2oBohJBzGJC xg0wI8nNEdFGzedJ+6uxw78CE8xMDSIE9YW7asBBPmtcK7cO9Rs/I/4xe Hm0+gyBTo3LXZSNr7VCz9llZR/Ds9zJghrsVGp8PgZqoVFge/6rhitcj+ t5v7Cec9QT/rq0YWkmvEAEnq7a1CaRFzhYjFHJMHmZUm1LYtDxwHoU8Mn Z60UFZzE14olr/RW5eBW7u2/kfQ9Y4WQPLJc8ySoF7QxLv6KaeWTa7Bs9 7+0iPX21FGcKHeTC5teRE/OTn9FnHPuhIYf7xt0YIujc+BXzU9A4lxEBD A==; X-CSE-ConnectionGUID: CDd/iqi5Q1+v7+XNYZqZyg== X-CSE-MsgGUID: BFsEakChQiK44LXUg45/Qw== X-IronPort-AV: E=McAfee;i="6800,10657,11631"; a="66658197" X-IronPort-AV: E=Sophos;i="6.20,244,1758610800"; d="scan'208";a="66658197" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2025 14:18:39 -0800 X-CSE-ConnectionGUID: AZur3+trQtmsFrgAlTdQSw== X-CSE-MsgGUID: nZi4N0LJSZu9bYQzW9Wpzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,244,1758610800"; d="scan'208";a="194381222" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2025 14:18:38 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 2 Dec 2025 14:18:38 -0800 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Tue, 2 Dec 2025 14:18:38 -0800 Received: from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.67) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 2 Dec 2025 14:18:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UDulakDpOKFLwJwz733MmUV+Br0oRHbhgr2nGzctWs0iitFNYr0eR0phVXFaGRlPbPKpY3ak6a9dwRURbhGDtkwU7v9wMvrDIUTLhqr3JKmYajZnQ89NMe3qDlPM5bGduDvxbh52jsEQMvW623/Tpwwf0IasL47ozu1Tmxh4WpkOYSSJ3vBbi1BqcFCbQJGTAmEgx+KR3WtlsOEWHNVmKgl3FY4nAf3MmqOZA89Vv1OARxp3OP6a/wfQSM/KV7dK2DaC/bBA5+ptzBgsQoh4Z7fr2HRovidY18+5bi800GVdeKgJ9go8QBuhHzTx0mgc+gP3Usaiuzlt/H28y0KJSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yzcA7r+2fI1k/w3yGFgptn9CWjZ2J83k3ltzO2xufAE=; b=F+C5wZpBESJpw7bOdFIgPFokB2QzuxAqmppsuxnr1pTslWYwsIeK1Iib6Ymuvc5dDm0uyB9bdX+WbTNlQSlL4BhCjULiEcoLCRrKJt4UJcsE4PIbVXNMyypEQp6jOMPoNtv/E5vqu45F5OrLqeMmr41aJdS2V0VUGfPbvpCuQAWROBi3gFLUbvLL23o6j6T4TFqBgR/D6XaOt0OHDrfCbzgmU71Lo+MMau9UiDiOGhrZJAH7uKNBPaQ/fFbi0dmesGfG/cJNCLycrc03Qaru+eamScgNouGYAuZXSgaFsOYo+x/wTwpF9PctORGCGfIAFvrmxiY0uEPZaWxhMfQ3LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) by PH3PPF1BAF94C4A.namprd11.prod.outlook.com (2603:10b6:518:1::d0d) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Tue, 2 Dec 2025 22:18:36 +0000 Received: from PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::9e94:e21f:e11a:332]) by PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::9e94:e21f:e11a:332%7]) with mapi id 15.20.9388.003; Tue, 2 Dec 2025 22:18:36 +0000 Date: Tue, 2 Dec 2025 14:18:33 -0800 From: Matthew Brost To: Brian Nguyen CC: , , , Subject: Re: [PATCH v2 03/11] drm/xe/xe_tlb_inval: Modify fence interface to support PPC flush Message-ID: References: <20251126230201.3782788-13-brian3.nguyen@intel.com> <20251126230201.3782788-16-brian3.nguyen@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20251126230201.3782788-16-brian3.nguyen@intel.com> X-ClientProxiedBy: MW4PR03CA0209.namprd03.prod.outlook.com (2603:10b6:303:b8::34) To PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6522:EE_|PH3PPF1BAF94C4A:EE_ X-MS-Office365-Filtering-Correlation-Id: 6feb8ba2-99b6-4e7a-7928-08de31f0bcd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?R0u7wrV4YLYA8bEdpTjmtF0uFS6H4lUfP441f77b/9sHW948fukTZqCPT0Jj?= =?us-ascii?Q?E0oZABZ7/UmA/804wxR2XDm2wvy7uclI9cnhrPKY1GXaY0zgEcbzW/TIa13C?= =?us-ascii?Q?0i8CCV9S3tY6gFSTyz4qMRTTuri2im8XeKf5KrMR28BmFVr3nhPyjQvVlbRD?= =?us-ascii?Q?Xsa747cSgPDE7qrJKwUSJF2DHNWnK44PNOByOmttlCl/2cvw1b78ZCzEIR/l?= =?us-ascii?Q?uOZRlrGnJHy2P+W6BD1zxmxNYARFSwy2NqBLz+OntEFy/2G7Sy7arjl40fMW?= =?us-ascii?Q?dMnCq1zDy7SocxWDjB83Up5Ta7dGCf3uIiwYOe/jJwRp36Fxz6aREEdO3pLk?= =?us-ascii?Q?PiHoHaUVmOv1vGAmg5+YmEbzsX3fU8VMSU7l7ku0CgZDh6gdOpwjP7JfqygK?= =?us-ascii?Q?SO7l+ShOoNZHSKSWr9scB8pUpZw6PoimLVvOrHRV2mRXMP87H8P4OqKADONw?= =?us-ascii?Q?Ecmbw7z84tBeR20nb8xspazrupsuWTQugngFkfx9ofyho3k0VGmsvSUa4LQu?= =?us-ascii?Q?v9wtMfgnRJFcruSRgqHJhV+VWSZ9i6yfK3WuVMnZdu5C6IcIp/gVNGBnQytx?= =?us-ascii?Q?bkByVTgMmHpTvAqRX07mcyNR4kF1XhX0jpSQanKrRz6uaLfEamZ4oquybHqi?= =?us-ascii?Q?SZxvTesNteHMY8zZdc8VRCWpapHkCmwjpkjGr7VdMIzgvH6lG7Tb/fhgxyOr?= =?us-ascii?Q?hFBDUAnfq+e2hV/IeOIyAQZs1jOK1/KATfjjsPm1mRj2V9lo9N9dMn5L37wA?= =?us-ascii?Q?OgKauovPDbVzKg7Jz67VkUjChDEwwoMHOrWRDrAlqeOGLK+VP4PzrLe5Dxe3?= =?us-ascii?Q?zRwuL28IamVCMgyzr1WE5mC5VFOX8BRxqG+Wx5/IOEFrz/Vx4KMWiUrFIH3x?= =?us-ascii?Q?JAtfJzKfaqHPuUX5pfUmweARZvHDelMCpM2lMAquAthSHBIVoZKWTfsOduUP?= =?us-ascii?Q?F9CzXlzHF1oUBy2wdDLvNc06W7ovWpK9snB1t1ppZsEbeJ7WrMrCG4TIsndE?= =?us-ascii?Q?ksZi4QdNFJd4mcbZckf7q5vjSqQkku6mQs0CIOWqOvphTH6ZdU/UPo3ZJoyN?= =?us-ascii?Q?TGcjgGV27FTkWeU6dj3KapEnUUTUPz2Q1KtWboZLtYcYUAoX+lGb1CmMHXgw?= =?us-ascii?Q?MIaysWEuTIVu/z+XPNa0ZnqRUT3Vl6iijqKMSJsW4PoDKkVOePPunXBeUwIl?= =?us-ascii?Q?fEWOU3DekXj1XPLCrl+FCtUFIpK7on/+TpkCRdZ/vjTY1x8q3VaIQWgp0AY5?= =?us-ascii?Q?s/DwjxgNMthDZNy0va7Ch3r+Pp49Y8zXKe7ecDPuRbP5DV88cWN6xCrO89xf?= =?us-ascii?Q?ly5MqNnQ3ZaU7OhuMtu9pOajA8EDC9Co/sdy9YY2wH+5FNu8cTCsHJRrkPV3?= =?us-ascii?Q?ppvdHGSdfxEOrCqn6g09gAKu0JPe+ZZxbrVY5m66Sj7lgQ0cdDD+mm48AUBl?= =?us-ascii?Q?jPkwsnG9rPepPr9Cki+FJm93ZipQ/Tb9?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6522.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Mpr3qodS68moLj+iTxH/eD3fY0eWbCPu1f5qe8izu647aVEpaxj+11lKin/?= =?us-ascii?Q?dkav4aalqg/Stw7MW+IFY93fBVgxCQzuKA7SkhrDJMHpdf5r6+YbtcT7Rnl5?= =?us-ascii?Q?GrPgFRVF1ErZ9V3zkIBDBKPKf1Y2XKK1IzLzCfNnW27gSppfqNQJane3IQS6?= =?us-ascii?Q?m7tv6+dnpwhiMTO4r9lp52YLxWqAYtVAvcuoxSJiXVQM1tZ+h5aqHOz6pGMQ?= =?us-ascii?Q?7nm6ADQQ2DIzqmxvdKxoxQWlTmS5ROkwya1y0elL/1rkPEjw/vSWiIq+p/OY?= =?us-ascii?Q?F52CzZ6iULZm0S56T5uCc+j2m6Cqil2myuYtLt6IYSAo50loi6scii+PnPaQ?= =?us-ascii?Q?9fXa29zw/ZVTwcuSkzUQnGMIPNAOMh85V3LRfT7kxf1mWOjYTYCxADSYq8XT?= =?us-ascii?Q?vxuELpH/ku+ssIaFbYLowPssqHRg4XULNTRIPAcZd/ygTxRDnjY+0e+DniB/?= =?us-ascii?Q?fb8DLBRT69w8WmtSAmf8XZxgJpdINMMUDm8fogAFL0JTFttl/JQZBm8+Pl2u?= =?us-ascii?Q?Ha+ZAX5iN5Kd1dDSfVpbXaJM1itd3iT9SYa8DKxTdSTBJgXr/pCgrpBIUwp4?= =?us-ascii?Q?j6oLH0jLb0JKsxkyjnE7nO0lZKPBVRsImGXZnbVyVMnjLIO7rEMIVvgrmZUw?= =?us-ascii?Q?CjpeojS9LcHTa6vWg6fNdMNcVevvuM0q9Whb8Khb8SoDL5KjhR2BUIKR3Cq/?= =?us-ascii?Q?frLgXJCDFXuTCvX9rUOKZ6qqAELPagMOkts/L8bIxpuJjc51/wdQ8hWZbaOu?= =?us-ascii?Q?PUEGKBN4hoX784krKKP9YJrWASMlAP8rluqbhXObTD2VxObLYarr9EpjVVJs?= =?us-ascii?Q?083TfBpewvV5ciGBeWrT1krwc45nM62y3mrCFVXIpMGquuxVuiXIkvkeEdxr?= =?us-ascii?Q?r/xOgaEk1f9DsxcvrDbpbO2VcL1fZEWd1j/R79oTl7fonm0HnXcHcjGlRkMP?= =?us-ascii?Q?Q+r9fHYsxrbByOkEAPpcco1HJW0kQPhlimsw/3dR41gNUyqgUjUfBVhWh930?= =?us-ascii?Q?cxKRDhji3dh7UKTOl/Uq6TxY9ASTn1mnOcoLRdCwDZiGZa/2Hb1oUwVkp+jJ?= =?us-ascii?Q?zYm5LK/UaoEvMPPSo+4aPiiZzSBUzZdIZv2GK3XS1yJf99WRgSshOUaNXWTo?= =?us-ascii?Q?pGXodqBFb8vTYWd5Rf0qfxJ/2fFzS3G0fR0cSX79jK5DLFd9LEG7kBe/WJdm?= =?us-ascii?Q?GVMb6Jg0+z/5UlPpj4ajhYcAkSNdLTSLUWIIpe9eWsRdSYLXJZ4j9+BymbR6?= =?us-ascii?Q?2etpfSgYHlcPJRM0v5h6aTX7dydoJgFNfYuTY82GlhJT4M+goALXobjPm3kj?= =?us-ascii?Q?x8QT0reomLWgu3OyClI1ywAh+9yuR60FkcLanPLitmer5TudBU45Mzqgo9B3?= =?us-ascii?Q?9mK8cxPLlc9gmnNRxF5WZPcPBPvW1Q0NEwy48lrLleD06NWPjzdAOTfVxnND?= =?us-ascii?Q?1L9vIKFUEoFuB7cYtgZ6y2KzrDW4vCfTivdIlF2OgyLxnvMeMBBDBBoyXFng?= =?us-ascii?Q?zd0DpijMAL3Ns0eikfuiZHODLeZw/Xqg+D43V2SFO9GJNu4Rcyh9GnZAKDBa?= =?us-ascii?Q?fk7AM8EaRHe5tTCeBTrtdowrjMV9keOundpAk7Kv85t5lFTYbD63mD6c8RMH?= =?us-ascii?Q?GA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6feb8ba2-99b6-4e7a-7928-08de31f0bcd1 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2025 22:18:36.4502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y1DUpgEV0eXyrB7UZHtvQIIFg/alZBRzosxn05KocUthAYdzg5EWzOTUIoFrBd6Bi8tO3zTBbhn5gSvkjRZiUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF1BAF94C4A X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Nov 27, 2025 at 07:02:04AM +0800, Brian Nguyen wrote: > Allow tlb_invalidation to control when driver wants to flush the > Private Physical Cache (PPC) as a process of the tlb invalidation > process. > > Default behavior is still to always flush the PPC but driver now has the > option to disable it. > > v2: > - Revise commit/kernel doc descriptions. (Shuicheng) > - Remove unused function. (Shuicheng) > - Remove bool flush_cache parameter from fence, > and various function inputs. (Matthew B) > > Signed-off-by: Brian Nguyen > Cc: Matthew Brost Reviewed-by: Matthew Brost > Cc: Shuicheng Lin > --- > drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c > index 848d3493df10..37ac943cb10f 100644 > --- a/drivers/gpu/drm/xe/xe_guc_tlb_inval.c > +++ b/drivers/gpu/drm/xe/xe_guc_tlb_inval.c > @@ -34,9 +34,12 @@ static int send_tlb_inval(struct xe_guc *guc, const u32 *action, int len) > G2H_LEN_DW_TLB_INVALIDATE, 1); > } > > -#define MAKE_INVAL_OP(type) ((type << XE_GUC_TLB_INVAL_TYPE_SHIFT) | \ > +#define MAKE_INVAL_OP_FLUSH(type, flush_cache) ((type << XE_GUC_TLB_INVAL_TYPE_SHIFT) | \ > XE_GUC_TLB_INVAL_MODE_HEAVY << XE_GUC_TLB_INVAL_MODE_SHIFT | \ > - XE_GUC_TLB_INVAL_FLUSH_CACHE) > + (flush_cache ? \ > + XE_GUC_TLB_INVAL_FLUSH_CACHE : 0)) > + > +#define MAKE_INVAL_OP(type) MAKE_INVAL_OP_FLUSH(type, true) > > static int send_tlb_inval_all(struct xe_tlb_inval *tlb_inval, u32 seqno) > { > @@ -152,7 +155,7 @@ static int send_tlb_inval_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno, > ilog2(SZ_2M) + 1))); > xe_gt_assert(gt, IS_ALIGNED(start, length)); > > - action[len++] = MAKE_INVAL_OP(XE_GUC_TLB_INVAL_PAGE_SELECTIVE); > + action[len++] = MAKE_INVAL_OP_FLUSH(XE_GUC_TLB_INVAL_PAGE_SELECTIVE, true); > action[len++] = asid; > action[len++] = lower_32_bits(start); > action[len++] = upper_32_bits(start); > -- > 2.52.0 >