From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D42CD3B7E2 for ; Mon, 8 Dec 2025 21:16:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3574410E147; Mon, 8 Dec 2025 21:16:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="eUGWbLWQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id B334210E147 for ; Mon, 8 Dec 2025 21:16:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765228574; x=1796764574; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=U9jLkcr5UihXQv5t9rfzAtldTM8WX0uP+3HA1drOWl4=; b=eUGWbLWQqOjlVPeUtJkNjW8ptX1iOsQqESFxe3i6vBthnPIqDbtPqCbN aiA34GvVVHp8ji9VyhkHMSXvncNTIk4VD3AXfzRVE+OV43Fy22xbiWWC5 5fuyoeCDa7V+conelU+uGFhO8JDCGDIjJdbfJ/bXhYKBonSn5/Y1GJ6r1 tfI46SEohfTOfoAKub67D2dU4e2lQBjAgTZfVIHfalUKqiFWcdZe9lA6H C8JOmmGRkQ3Sgi7nKUNbme2eBbpOZIPCesKRRTTH/Uui3p3XKgOwfgXQ+ k+p3IAOlcrttAv5nvy3A4O2PG+BbjlaqWfEtlwl3WbSkPaJ5jCk9P4rtl g==; X-CSE-ConnectionGUID: Vq5VlpNlR7WWDxC/TtAGEg== X-CSE-MsgGUID: VwMnRm1FSl21Tw33zq58Fw== X-IronPort-AV: E=McAfee;i="6800,10657,11636"; a="77503378" X-IronPort-AV: E=Sophos;i="6.20,259,1758610800"; d="scan'208";a="77503378" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2025 13:16:13 -0800 X-CSE-ConnectionGUID: bF18hxt9QKSa8cN5RubwEg== X-CSE-MsgGUID: nzH16I+wSp6TAVw5a8rY5Q== X-ExtLoop1: 1 Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2025 13:16:13 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Mon, 8 Dec 2025 13:16:12 -0800 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Mon, 8 Dec 2025 13:16:12 -0800 Received: from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.58) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Mon, 8 Dec 2025 13:16:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q8SPkPKjbGiPsJ5ns8IV2x1vF0lvrPnz66QdDZhotVRrTSm4b1GMIZXPO6LLmZVJqhZK+vpDACXKQEP3Xd24Sej+jIvBCL/1dR4hoTV+wUzUP2p4p5DPF025EvLByqPJ9LcfQ7QuMtjloKP16bGGKVRuH9KZ2eRdWckDcHlwpY+S5G6lW8eqccs1zQae8RyvJVDhVbcUUxytmmauOi6K5a6EezxAef7qJVLbV7V+d5YEhASxzRIxhlki9VjPMmnq3AiyNy5q2bp1jtbPrH+ckHYMlEehH+PbcLFcrPZ8CjnWfiPnCG1Avx99Oas2YK9kFXlDxZqpHpZq8hB6syd5kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FmNMlkP0Hk9e/OzbROPWNq86GnGV6kP1b38lIZD0GFg=; b=OUb0zi9ZEBCMmpNRHkYupd6mXVXuo1EcFkT07WwNAcQM+1mZ9KybIJqMtxUFlY7cJXJonnCdiwBLvGiIXagdtg1iMGY8nrt1yezAf380FT9HWYFYsEeuXrpqa2SR5xNhLGkFUHFCBNjowCM2CPKMurIMqLXGHUJeSAp4WhqAzpqTiri0Su8aDuPiD8ts+dIV9ySaWyf7nlZxoIzSg+jguUi++ZAswOIgYNf3IKXHAhf9AE6MAHqrdJS2LazzG/5ZddjAcT/8ZDQEnQA26WbqTKicXkDjY8OnzC/lZbNHHy3/NM7PIMVsCqh7HZEYV+iRoEwh4JwjNo68ptyjuQRboA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) by PH3PPF5AF05F6D9.namprd11.prod.outlook.com (2603:10b6:518:1::d24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.14; Mon, 8 Dec 2025 21:16:09 +0000 Received: from PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::9e94:e21f:e11a:332]) by PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::9e94:e21f:e11a:332%7]) with mapi id 15.20.9388.013; Mon, 8 Dec 2025 21:16:09 +0000 Date: Mon, 8 Dec 2025 13:16:06 -0800 From: Matthew Brost To: Satyanarayana K V P CC: , Michal Wajdeczko , Tomasz Lis Subject: Re: [PATCH v2 2/2] drm/xe/vf: Reset recovery_queued after issuing RESFIX_START Message-ID: References: <20251208072739.336647-4-satyanarayana.k.v.p@intel.com> <20251208072739.336647-6-satyanarayana.k.v.p@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20251208072739.336647-6-satyanarayana.k.v.p@intel.com> X-ClientProxiedBy: MW4P221CA0009.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::14) To PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6522:EE_|PH3PPF5AF05F6D9:EE_ X-MS-Office365-Filtering-Correlation-Id: 6eeec2dd-c563-4f19-1325-08de369f01c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Cchr81BiAvtZjbNibxtru3V1RYDzqcqton7BD7LXe6rr1fymmNbymiuf0s4+?= =?us-ascii?Q?KUbaPa950lF9H19JPb1gel8VWWotyr8Bzl4WUbNaMA2hsCP7vfjayPGpr8Dc?= =?us-ascii?Q?74vVOI9YZiejKDUm2rGjOtbnOeXawWjDsejnHU8lL0n32MOhHEIieBQfAY6m?= =?us-ascii?Q?vjYbuMhCqOezzjXzMlZa3CMQqhfl8Jo5DIJDZk8Ge8ZMNHOTwFKgQkXGc9pf?= =?us-ascii?Q?z33B/timLWCiOUlB/YVk8YEQeNfxZ/XHpL6u8h04wjf5pRShfV/K8wJH8eAR?= =?us-ascii?Q?BQbxpgbFCszGbZsi8QDVbjuVObDe2wqwZApYak14UUJ2zI6bZDLIqH/mdPHp?= =?us-ascii?Q?LkjX5rDolZDneXkAswOmd8oenh3XLJisjv+P2zdAkOgyI1xxrYADk/ny23Nr?= =?us-ascii?Q?D9lUM8xj6sZTP5Kjtu5qKsj1Z2Yq5b3Fe1DmzEb6A39g+NUsx0e/ZfStLhQk?= =?us-ascii?Q?8EyKVwzKkMRsoiyWiedzjrryCx7BPXa3P16VJ2/odvVxhNGJZVytFQpAN9Hv?= =?us-ascii?Q?11icxucmz30ExoFsox5rcUJlk2IFbQ9C3a0/3Dxp7IK/U+39A9uxwH4kDaFY?= =?us-ascii?Q?h6xlCZl9tQqvb06AazxghIBALIOX+oMQR5HZr3d5Qw85fcBFxGSMwEg0v6e1?= =?us-ascii?Q?3VkxA9Iisiu/fcxFK73s3xXEy5c+qIHmRqjIFUZCCYTLKIzvEGfpHHk3CXA/?= =?us-ascii?Q?xl+e4cGearpJfdtiNluxqoInQwoOWepeMCZU7II5HG+bPurLmq2mhvGEoxLH?= =?us-ascii?Q?JUdJk6cZaELoKJ47wEUhRN5ggvFBZOmhnr7avA0vVucA0Rvx+ohjkvdu34yE?= =?us-ascii?Q?W4xmwRQSvXBtjuqyk60dmXoy8yjjuTiZdoLh+ws9fzJOrq3U+Zs6r2PPYig8?= =?us-ascii?Q?4MZdpG5Jvu/bfDAQ9g11IT0U0+vmcn0F9Pa75tTqn0VFWOab2n6hwNH0QudH?= =?us-ascii?Q?WL2T3gAS08zaXvZDPnK7Xrdz0SrBsAqaCNuvbQ78H6C77qt8d1OMrOTw9SJ5?= =?us-ascii?Q?+D/SnC0IGqa1wHMwyHQp8x+QusQLQ7XFjo3C/YpUBamKqt+nryRHZjRhQH++?= =?us-ascii?Q?w/vBPtiDwXVzlLMzZGKB6D2PoQ7rYRJEcng7+qZe7LbcKGdCi5PAI/U4VIhr?= =?us-ascii?Q?mxuV2//jsZlZl4NxTatzWyhxNoUtO23x2xqYCtm7y/t3oIZ4XoFDa4ed+IpQ?= =?us-ascii?Q?ba66F2u72Mz+fQDmwtEzax1XndHb6wHSxJ7t9HWhQxvd+JiqshngxteTlJh4?= =?us-ascii?Q?SE3x+q62FKN3PTiosWbEG1Mn4TE20uTXFPUkr3E5DNs1j83yUWBHYiJR6biw?= =?us-ascii?Q?UZif4lXXIJ28vEJup0tA76QF40Kt0m/dekDT8AsM4jlywoHi/czn4dpgXSZL?= =?us-ascii?Q?ukznuLoD8Z1lJjB5K6WemaNubUURDy5gFz56nheDSqTb5CjcMfpT91PfPPXH?= =?us-ascii?Q?k1gVoicolzVPgS3DjudNm1161ftRHUea?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6522.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UZtoDokbN3AthYZt4XvDbTwXkk13TB7+hGv6OFnn6qlwIM+Foz+p93W4Gpxx?= =?us-ascii?Q?bvFy/7J01E7EGPl0lxPzIXF9z9Xlm3tKYCgvtj1ebOtttluNLd5CNo/FiAOH?= =?us-ascii?Q?Fcnecs/7ZrFUFWfl6DgHiKrRbUrqngwrXhs/mQgkWO6XvWitSipfLGKxBE0t?= =?us-ascii?Q?WNIxorxixmT5sLyTvU6a1+lGMQ9thzF/MFZMOeV1YzsdzkLc4XqfkqjPfOqh?= =?us-ascii?Q?CJmy1rizUKnK+HUnTesDtM7DBVbE/jApKuvonBFUuh0I08jnMVxpBZvuNLLm?= =?us-ascii?Q?g2jH9UZAe1X9Js/W42O2opMutjPHGC7caHtbdDSh1S/eSAk5/1uvudrVYCDV?= =?us-ascii?Q?m2+NcEukUszxOOOnH3HpLKAhCoDvwrvT4HHNAWYOMqj4lKGKSj3Uqw8TAmly?= =?us-ascii?Q?t4Ti0/xBh9qfQIgFe0/vsNz6266o/KNrPAaqfDv5ZQaaQhp8mkFaXmOvYqUv?= =?us-ascii?Q?X9zB4i9EFfsFXhFtHHDQDYd/Db7w8tRzgNqEtVxltL6Kn5aEv8vJ+YxrJx8n?= =?us-ascii?Q?DXpYiIV/jyMTH6bAHtr2WAmmh/OFTUca68JxkBQE8SrOvHHqL1yFuqx4Nn8h?= =?us-ascii?Q?sO5SK4fpWQxNg3kXFr/Cd7sx2xwvRf63rUJa8VR2Gf2NyOEpFsOVWh1I9uNA?= =?us-ascii?Q?gypsX1KkuSTMmDuRhwvGA9rclU2utkM6XtuQ7605uDci2CNyv5QKeloLvFe7?= =?us-ascii?Q?k3NWkKMNrK3uVGQ9NpQmu+vu5877R4Ep2wYN+ti6quUQT/0FLCfbigQ37jvO?= =?us-ascii?Q?qgPiQxRSJrtMrbfBSXu755LrnSoFOiaPf7MlGqZ2Ipy1gMMsXlq089MJWQwl?= =?us-ascii?Q?ODNQLLIHXhtbESSV+gYaIONTXZnnISEpgkE0ZTgRQUNC0x3W0fapSturDAHt?= =?us-ascii?Q?pf9yMo2sSKTqZeySYcFp+/RBcfHLtzUTzds5H58ySiECLEtJ+Jcqqh4ePzXK?= =?us-ascii?Q?M+YLNlLdLmiUGv1RP6kMkgFfSRLtSd8OqpajTf+v2quQiRFwf9dkHAM+Nc7k?= =?us-ascii?Q?xYIdHTYtt4CGzgjbpcNKnA635PVZICtYCOxWl5v6TgfYyHKn5yhh4imXj4rg?= =?us-ascii?Q?rQ2956Gx7KU7OcL5OJ3SHbE2QjG/77HgXMzjyeS0b+F+LoJLMVsIeLzBA6nS?= =?us-ascii?Q?Yi/UKOtneqQbP3Rs+JDMKGWLkmcofklyyuuJm3rluUfpS4JihG+1OecHyetf?= =?us-ascii?Q?ZyxxGGUwXhTgkNpBbJunyfk29pcnBJ+kClwtka/6cj1eaESCYOxf99ISr8pF?= =?us-ascii?Q?5G8liy7g8prZSpsc19/Ao07q8VMk/ogoSiWgSp4JP4kEbE3CDRT3Cn0H3Ttr?= =?us-ascii?Q?+LZOFVFhQEwAnxSHJlEjsprWgF3KKnghc0o+hAlM9B9FgjeIE74XG7PoOWJS?= =?us-ascii?Q?s0hT1+USz10jov+PpvyB8qfTU9Lq47yJalNqMV/ESsxJZciRGx/dXhDaCjfc?= =?us-ascii?Q?7K4xhpXXL49GkaqZAsPfUs5QxMp4oDJr6Eb2DTU9TQFmVZCIp4GgeZtPI53p?= =?us-ascii?Q?YXzv3N1E4uhwDXG6md5/iAusMje7WkYwQcIZK57t0AOevm2mpU8EjTvYxHk3?= =?us-ascii?Q?4D5fh1yOywrq33uJI8tavW+8HFZP/oPSJqsk0oV5u02xvK57F05Enuc7s74x?= =?us-ascii?Q?Og=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6eeec2dd-c563-4f19-1325-08de369f01c2 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2025 21:16:09.1510 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jsx6xdG3R4eZSp9QMLwXx2F4wsPQdmuqLy59X5pmOmae1f7XqPRd3UldDSi0pFFCsh+UnAiaQFUY3qpXL/WzZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF5AF05F6D9 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Dec 08, 2025 at 07:27:42AM +0000, Satyanarayana K V P wrote: > During VF_RESTORE or VF_RESUME, the GuC sends a migration interrupt and > clears the RESFIX_START marker. If migration or resume occurs before the > VF issues its own RESFIX_START, VF KMD may receive two back-to-back > migration interrupts. VF then sends RESFIX_START to indicate the beginning > of fixups and RESFIX_DONE to mark completion. However, the second > RESFIX_START fails because the GuC is already in the RUNNING state. > > Clear the recovery_queued flag after sending a RESFIX_START message to > ignore duplicated IRQs seen before we start actual recovery. > > This ensures the state is reset only after the fixup process begins, > avoiding redundant work item queuing. > > Fixes: b5fbb94341a2 ("drm/xe/vf: Introduce RESFIX start marker support") > Signed-off-by: Satyanarayana K V P > Cc: Michal Wajdeczko > Cc: Matthew Brost > Cc: Tomasz Lis > > --- > V1 -> V2: > - Fixed review comments (Michal W). > - Updated commit message. > - Used scoped_guard for spin_lock/unlock_irq. > --- > drivers/gpu/drm/xe/xe_gt_sriov_vf.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c > index 47612e67d462..23ab25e407dc 100644 > --- a/drivers/gpu/drm/xe/xe_gt_sriov_vf.c > +++ b/drivers/gpu/drm/xe/xe_gt_sriov_vf.c > @@ -1171,10 +1171,6 @@ static bool vf_post_migration_shutdown(struct xe_gt *gt) > return true; > } > > - spin_lock_irq(>->sriov.vf.migration.lock); > - gt->sriov.vf.migration.recovery_queued = false; > - spin_unlock_irq(>->sriov.vf.migration.lock); > - > xe_guc_ct_flush_and_stop(>->uc.guc.ct); > xe_guc_submit_pause_vf(>->uc.guc); > xe_tlb_inval_reset(>->tlb_inval); > @@ -1258,7 +1254,14 @@ static int vf_post_migration_resfix_done(struct xe_gt *gt, u16 marker) > > static int vf_post_migration_resfix_start(struct xe_gt *gt, u16 marker) > { > - return vf_resfix_start(gt, marker); > + int err; > + > + err = vf_resfix_start(gt, marker); > + > + scoped_guard(spinlock_irq, >->sriov.vf.migration.lock) Also you can just use guard here, but fine either way. > + gt->sriov.vf.migration.recovery_queued = false; > + > + return err; Extra space. Matt > } > > static u16 vf_post_migration_next_resfix_marker(struct xe_gt *gt) > -- > 2.43.0 >