From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F6B4D41C36 for ; Thu, 11 Dec 2025 14:05:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DADA10E817; Thu, 11 Dec 2025 14:05:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XeFJagqT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68D6610E720; Thu, 11 Dec 2025 14:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765461956; x=1796997956; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dzXHVkwC/M9NRU1IUfVXSf2jXX10b2DrCsYDrW/bCBE=; b=XeFJagqTC338aYsBrBL3ICEXk2vBcz0U+ZP7hwYP+mk/q/0SSSulkX1c SPRX6PihjKmUBp7Rnf4TN8a3RjHmurBV3hw0yjPezHO5QV7b63sgNxh1N seWzTdJ3vbmopHygpwSR6Hta+1IbqFS4OSAvbydbt0yk/6AMGtv90apM/ xeEFv3tQca9+6jEjxPvq56u27XUdlZGw9am8DMqe2/sDw05PIfIj15m8i 67wcFN0x74rI0sqLONw7aMAdpF7eYPOiTWfR+7gMI2cNQt7p2RWN71kyX 7pDVTfFGr6d+meJJneMgXpSF8Y/n/qjq0PMTiCz9ZCwrR+y7sSfQs/D4z w==; X-CSE-ConnectionGUID: CHCqlKDwQ1Gd27cLM8yzzQ== X-CSE-MsgGUID: ijC6Ci8TR4eId4vLaZ8pcg== X-IronPort-AV: E=McAfee;i="6800,10657,11639"; a="70024310" X-IronPort-AV: E=Sophos;i="6.21,141,1763452800"; d="scan'208";a="70024310" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2025 06:05:56 -0800 X-CSE-ConnectionGUID: ZCBkKRKbTiOh3hkRTKb4rw== X-CSE-MsgGUID: wdnlf7YcS6G5swgkblAQgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,141,1763452800"; d="scan'208";a="227460341" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2025 06:05:55 -0800 Date: Thu, 11 Dec 2025 15:05:52 +0100 From: Raag Jadav To: Jani Nikula Cc: Maarten Lankhorst , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Message-ID: References: <20251209151319.494640-3-dev@lankhorst.se> <20251209151319.494640-4-dev@lankhorst.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Dec 11, 2025 at 10:47:01AM +0200, Jani Nikula wrote: > On Wed, 10 Dec 2025, Maarten Lankhorst wrote: > > Hey, > > > > Just needs a typo fixed, Matthew Brost also commented that the second I915 here should be PREEMPT-RT instead. > > The commit message does not say what is being done here, and why. > > "no need for backporting"? > > "this is only useful for i915"? > > *what* "doesn't compile with PREEMPT-RT enabled"? > > Nobody's going to understand what any of this means if a bisect/blame > lands here a couple of years from now, even if it's an apparently simple > change. I've been looking at some of the AMD patches and found the template to be much useful. Subject: [WHAT] Commit message: [WHY] [HOW] Not a hard mandate but worth thinking in this direction? Raag > > Den 2025-12-10 kl. 09:56, skrev Jani Nikula: > >> On Tue, 09 Dec 2025, Maarten Lankhorst wrote: > >>> No need for backporting, this is only useful for i915, > >>> and it doesn't compile with I915 enabled. > >> > >> Please elaborate. There's just riddles here. > >> > >> BR, > >> Jani. > >> > >>> > >>> Signed-off-by: Maarten Lankhorst > >>> --- > >>> drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/i915/display/intel_lpe_audio.c b/drivers/gpu/drm/i915/display/intel_lpe_audio.c > >>> index 5b41abe1c64d5..172c0062237eb 100644 > >>> --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c > >>> +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c > >>> @@ -262,7 +262,7 @@ void intel_lpe_audio_irq_handler(struct intel_display *display) > >>> if (!HAS_LPE_AUDIO(display)) > >>> return; > >>> > >>> - ret = generic_handle_irq(display->audio.lpe.irq); > >>> + ret = generic_handle_irq_safe(display->audio.lpe.irq); > >>> if (ret) > >>> drm_err_ratelimited(display->drm, > >>> "error handling LPE audio irq: %d\n", ret); > >> > > > > -- > Jani Nikula, Intel